[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #42 from Fedora Update System --- python-feedgenerator-1.9-6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because:

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #40 from Fedora Update System --- python-feedgenerator-1.9-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #39 from

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #38 from Fedora Update System --- python-feedgenerator-1.9-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0d2c427d03 -- You are receiving this mail because: You are on

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #37 from Fedora Update System --- python-feedgenerator-1.9-6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-99c6bab44c -- You are receiving this mail because: You are on

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #36 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-feedgenerator -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #35

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #34 from Ankur Sinha (FranciscoD) --- Added: https://ankursinha.fedorapeople.org/python-feedgenerator/python-feedgenerator.spec https://ankursinha.fedorapeople.org/python-feedgenerator/python-feedgenerator-1.9-6.fc28.src.rpm --

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #33 from Germano Massullo --- (In reply to Germano Massullo from comment #32) > (In reply to Ankur Sinha (FranciscoD) from comment #31) > > I missed that! I've unbundled it and it builds just fine: > > Ok, now you must add

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #32 from Germano Massullo --- (In reply to Ankur Sinha (FranciscoD) from comment #31) > I missed that! I've unbundled it and it builds just fine: Ok, now you must add python-six (use the proper Python 2 and 3 macros) as runtime

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #31 from Ankur Sinha (FranciscoD) --- Hi Germano, I missed that! I've unbundled it and it builds just fine: https://ankursinha.fedorapeople.org/python-feedgenerator/python-feedgenerator.spec

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #30 from Germano Massullo --- The package ships a bundled python-six library, version 1.1.0 (from year 2011!) Could you please try unbundling it and check if feedgenerator works using the Fedora python-six package? -- You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added Flags||fedora-review? -- You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added CC||germano.massu...@gmail.com

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|fedora-review? | --- Comment #29 from

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Assignee|bunnya...@gmail.com |nob...@fedoraproject.org

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #28 from Chris King --- I'm not sure if assigning this to me is a sign that I've been sponsored or simply an accident... Just to clarify again, I am not yet (to my knowledge) sponsored, so I don't believe that I should have been

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added Assignee|germano.massu...@gmail.com |bunnya...@gmail.com -- You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #27 from Chris King --- With the added license it LGTM. If I were able to, I'd approve this package. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #26 from Ankur Sinha (FranciscoD) --- Hi Chris! Thank you for the review! Unfortunately upstream have not made a new release since updating the Manifest, so the pypi tar does not include the License file yet. I've used the

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #25 from Chris King --- > python3-feedgenerator.noarch: W: invalid-url URL: > https://github.com/getpelican/feedgenerator or service not known> > python2-feedgenerator.noarch: W: invalid-url URL: >

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Chris King changed: What|Removed |Added CC||bunnya...@gmail.com --- Comment #24

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com)

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added Flags||needinfo?(sanjay.ankur@gmai

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Whiteboard|AwaitingSubmitter |

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai |

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Elliott Sales de Andrade changed: What|Removed |Added CC|

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #18 from md...@tutanota.com --- Upstream issues are resolved, including LICENSE, and the spec file works correctly. Is anything else stopping inclusion at the moment? -- You are receiving this mail because: You are on the CC list

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #17 from jibecfed --- Licence issue is fixed: https://github.com/getpelican/feedgenerator/issues/10 This thread explains the reason why the Pelican maintainer created a new project for a standalone

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 md...@tutanota.com changed: What|Removed |Added CC||md...@tutanota.com --- Comment

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Matthias Runge changed: What|Removed |Added Blocks||1480922

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Georg Sauthoff changed: What|Removed |Added CC||fed...@georg.so

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #14 from Adam Williamson --- The pelican package explicitly requires a module called 'feedgenerator' now, so either that needs patching or this needs packaging. -- You are receiving this mail because: You

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Adam Williamson changed: What|Removed |Added Blocks||1379149

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #13 from Matthias Runge --- Ankur, since the issue was only about feedparser, I would accept a backport of the fix in feedparser from a later django version. -- You are receiving this mail because: You are on

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #12 from Ankur Sinha (FranciscoD) --- Ha! I'll provide it by the weekend hopefully. Should just be the one diff that carries the feedparser fix between the two django versions, or should I check the

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #11 from Matthias Runge --- (In reply to Ankur Sinha (FranciscoD) from comment #10) > > Sure, if you're willing to carry the patch? :D Provide it ;-) The diff between django and feedparser is quite minimal.

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #10 from Ankur Sinha (FranciscoD) --- (In reply to Matthias Runge from comment #9) > maybe we should backport the fix they did in django-1.10 to django-1.9 > rather than creating a new package, that is

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #9 from Matthias Runge --- maybe we should backport the fix they did in django-1.10 to django-1.9 rather than creating a new package, that is basically a (half) duplicate of django? I still don't see much value

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #7 from Ankur Sinha (FranciscoD) --- (In reply to Germano Massullo from comment #5) > Created attachment 1205204 [details] > sample spec file > > License file is missing. > 1) Go to upstream Github

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #8 from Ankur Sinha (FranciscoD) --- (In reply to Matthias Runge from comment #4) > feedgenerator is a fork of django. You > > Django's unit tests are fine in koji: >

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #6 from Germano Massullo --- And sorry if I seemed to be rude but I was doing 3 different things at the same time :D -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #5 from Germano Massullo --- Created attachment 1205204 --> https://bugzilla.redhat.com/attachment.cgi?id=1205204=edit sample spec file License file is missing. 1) Go to upstream Github website, fill

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #4 from Matthias Runge --- feedgenerator is a fork of django. You Django's unit tests are fine in koji: http://pkgs.fedoraproject.org/cgit/rpms/python-django.git/tree/python-django.spec#n229 -- You are

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #3 from Ankur Sinha (FranciscoD) --- Done. Updated spec/srpm: https://ankursinha.fedorapeople.org/feedgenerator/python-feedgenerator-1.9-2.fc24.src.rpm

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 --- Comment #2 from Germano Massullo --- Ankur, could you please: 1) replace %global srcname feedgenerator with %global pypi_name feedgenerator and all srcname occurrencies in the spec file 2) replace URL:

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Matthias Runge changed: What|Removed |Added CC||mru...@redhat.com

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added Priority|medium |urgent

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Germano Massullo changed: What|Removed |Added CC|