[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #20 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc27 has been pushed to the Fedora
27 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #19 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc26 has been pushed to the Fedora
26 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-10 22:25:15



--- Comment #18 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc25 has been pushed to the Fedora
25 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #17 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc27 has been pushed to the Fedora
27 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8a5b7ede07

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #16 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7470f3d312

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-037c9c218a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #14 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc25 has been submitted as an update
to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7470f3d312

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #12 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc27 has been submitted as an update
to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8a5b7ede07

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #13 from Fedora Update System  ---
golang-bazil-fuse-0-0.1.20160811git371fbbd.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-037c9c218a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-bazil-fuse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Scott Talbert  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Scott Talbert  ---
(In reply to Robert-André Mauchin from comment #9)
> All righty then, I've fixed it:

Well, I think technically it probably would be better for 'golang' to own it,
in case, like you said, if someone packaged zipfs.  But this is fine for now.

Approved.  Thanks for your work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #9 from Robert-André Mauchin  ---
All righty then, I've fixed it:


SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594947-golang-bazil-fuse/golang-bazil-fuse.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594947-golang-bazil-fuse/golang-bazil-fuse-0-0.1.20160811.git371fbbd.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #8 from Scott Talbert  ---
(In reply to Robert-André Mauchin from comment #7)
> > - What is the purpose of the unit-test-devel subpackage?  I'm not sure I
>   understand the usefulness of packaging the unit tests.
> 
> It is how Golang libraries are supposed to be packaged. See
> https://koji.fedoraproject.org/koji/search?match=glob=rpm=*unit-
> test-devel* All of these Golang libraries SPECs are generated by Gofed, the
> script recommended in Golang Draft Guidelines.

Strange.  I just don't see the purpose, but OK.

> > - Package doesn't own /usr/share/gocode/src/bazil.org directory.
> 
> No, because this directory is not specific to this package, it is shared
> with other Go project from Bazil. If I were to package golang-bazil-zipfs
> for example, I would also use /usr/share/gocode/src/bazil.org. The only
> specific directory are the ones one level below, for example
> /usr/share/gocode/src/bazil.org/fuse or /usr/share/gocode/src/bazil.org/zipfs

I see your point, but some package has to own the bazil.org directory.  It
appears that the 'golang' package owns the github.com directory[1] and a few
others, so probably it should own the bazil.org directory too?  Perhaps you can
file a bug or submit a PR for that?
[1] https://src.fedoraproject.org/rpms/golang/blob/master/f/golang.spec#_407

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #7 from Robert-André Mauchin  ---
Thanks for your review.

> - What is the purpose of the unit-test-devel subpackage?  I'm not sure I
  understand the usefulness of packaging the unit tests.

It is how Golang libraries are supposed to be packaged. See
https://koji.fedoraproject.org/koji/search?match=glob=rpm=*unit-test-devel*
All of these Golang libraries SPECs are generated by Gofed, the script
recommended in Golang Draft Guidelines.

> - Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/gocode/src/bazil.org/fuse
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Removed.

> - I believe the license field should include MIT as well (see the section
  in LICENSE that refers to fuse.go which appears to be MIT license).

I've added the reference to fuse.go under MIT.

> - Package doesn't own /usr/share/gocode/src/bazil.org directory.

No, because this directory is not specific to this package, it is shared with
other Go project from Bazil. If I were to package golang-bazil-zipfs for
example, I would also use /usr/share/gocode/src/bazil.org. The only specific
directory are the ones one level below, for example
/usr/share/gocode/src/bazil.org/fuse or /usr/share/gocode/src/bazil.org/zipfs


SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594632-golang-bazil-fuse/golang-bazil-fuse.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00594632-golang-bazil-fuse/golang-bazil-fuse-0-0.1.20160811.git371fbbd.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #6 from Scott Talbert  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- What is the purpose of the unit-test-devel subpackage?  I'm not sure I
  understand the usefulness of packaging the unit tests.
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/gocode/src/bazil.org/fuse
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- I believe the license field should include MIT as well (see the section
  in LICENSE that refers to fuse.go which appears to be MIT license).
- Technically, the package doesn't require the golang package, which owns
  /usr/share/gocode and /usr/share/gocode/src, but I don't know if this
  is a common omission in golang packaging?
- Package doesn't own /usr/share/gocode/src/bazil.org directory.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 78
 files have unknown license. Detailed output of licensecheck in
 /home/talbert/fedora-review/1475750-golang-bazil-fuse/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gocode/src/bazil.org
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/bazil.org
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = 

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Scott Talbert  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||s...@techie.net
   Assignee|nob...@fedoraproject.org|s...@techie.net
  Flags||fedora-review?



--- Comment #5 from Scott Talbert  ---
Taking this since you did one of my packages.  :)  I'm not familiar with Fedora
go packaging, but I am familiar with this particular go library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #4 from Robert-André Mauchin  ---
Added commitdate

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591298-golang-bazil-fuse/golang-bazil-fuse.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591298-golang-bazil-fuse/golang-bazil-fuse-0-0.1.20160811.git371fbbd.fc27.src.rpm

FAS username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #3 from Robert-André Mauchin  ---
SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584399-golang-bazil-fuse/golang-bazil-fuse.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584399-golang-bazil-fuse/golang-bazil-fuse-0-0.1.git371fbbd.fc27.src.rpm

FAS username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #2 from Robert-André Mauchin  ---
Fixed ExclusiveArch issue

Spec URL:
https://github.com/eclipseo/packaging/blob/27b7add/golang-bazil-fuse.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/1771/20801771/golang-bazil-fuse-0-0.1.git371fbbd.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20801758

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750



--- Comment #1 from Robert-André Mauchin  ---
Sorry, SRPM link is
https://kojipkgs.fedoraproject.org//work/tasks/5878/20795878/golang-bazil-fuse-0-0.1.git371fbbd.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475750

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1473314




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473314
[Bug 1473314] Review Request: rclone - rsync for cloud storage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org