[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-20 12:16:00



--- Comment #17 from Fedora Update System  ---
qesteidutil-3.12.10-2.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
qesteidutil-3.12.10-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #15 from Fedora Update System  ---
qesteidutil-3.12.10-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
qesteidutil-3.12.10-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #13 from Fedora Update System  ---
qesteidutil-3.12.10-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #12 from Germano Massullo  ---
(In reply to Fedora Update System from comment #11)
> qdigidoc-3.13.5-1.fc27 has been submitted as an update to Fedora 27.
> https://bodhi.fedoraproject.org/updates/FEDORA-2018-c6419c676b

My fault!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #11 from Fedora Update System  ---
qdigidoc-3.13.5-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c6419c676b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #10 from Robert-André Mauchin  ---
Ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #9 from Germano Massullo  ---
I think the package should be okay

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #8 from Germano Massullo  ---
(In reply to Robert-André Mauchin from comment #7)
> Well that's your patch, what does it do/why is it needed?

The patch was already in the retired package, it is not mine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #7 from Robert-André Mauchin  ---
Well that's your patch, what does it do/why is it needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #6 from Germano Massullo  ---
https://germano.fedorapeople.org/package_reviews/qesteidutil/qesteidutil.spec
https://germano.fedorapeople.org/package_reviews/qesteidutil/qesteidutil-3.12.10-1.fc27.src.rpm

I need some suggestions about what to write as comment for the patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #5 from Robert-André Mauchin  ---

 - Add a comment explaining what the patch is for

 - You never apply the patch in %prep, did you forget that part?

%patch0 -p1

 - Escape the macros in your last changelog entry by doubling the %:

* Thu Nov 30 2017 Germano Massullo  - 3.12.10-1
- forced %%{cmake} . -DBREAKPAD=FALSE because breakpad does not compile with
recent compilers. Source: Raul Metsma (upstream) on IRC chat, which showed me
also
https://github.com/open-eid/qesteidutil/commit/efdfe4c5521f68f206569e71e292a664bb9f46aa
- adjusted doc file names
- removed OpenSSL 1.1 patch because no longer necessary
- replaced make %%{?_smp_mflags} with %%make_build (see package review
#1519323)
- replaced make install DESTDIR=%%{buildroot} with %%make_install (see package
review #1519323)
- removed line %%clean and rm -rf %%{buildroot} (see package review #1519323)
- license file attached to %%license macro, instead of %%doc macro (see package
review #1519323)
- Replaced BuildRequires: openssl-devel with BuildRequires: pkgconfig(openssl)
(see package review #1519323)
- Replaced BuildRequires: qt5-qttools with BuildRequires:
pkgconfig(Qt5Designer) (see package review #1519323)
- Replaced BuildRequires: libpcsclite-devel >= 1.7 with BuildRequires:
pkgconfig(libpcsclite) >= 1.7 (see package review #1519323)


 - Convert this file to UTF-8:

qesteidutil.x86_64: W: file-not-utf8 /usr/share/doc/qesteidutil/AUTHORS



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/qesteidutil
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v2 or later)", "Unknown or generated",
 "GPL (v3) LGPL (v3)", "*No copyright* BSD (3 clause)", "MIT/X11 (BSD
 like)", "BSD (4 clause)", "curl", "*No copyright* Public domain",
 "Apache (v2.0) BSD (2 clause)", "*No copyright* Ms-RL", "Unicode
 strict BSD (3 clause)", "Unicode strict", "BSD (3 clause)", "LGPL
 (v2.1 or later)", "FSF All Permissive", "GPL (v3 or later)", "*No
 copyright* LGPL (v2.1 or later)". 359 files have unknown license.
 Detailed output of licensecheck in
 /home/bob/packaging/review/qesteidutil/review-
 qesteidutil/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in qesteidutil
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the 

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #4 from Germano Massullo  ---
https://germano.fedorapeople.org/package_reviews/qesteidutil/qesteidutil.spec
https://germano.fedorapeople.org/package_reviews/qesteidutil/qesteidutil-3.12.10-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #3 from Germano Massullo  ---
Are you sure about replacing
BuildRequires:  qt5-qttools
with
BuildRequires:  pkgconfig(Qt5Designer)
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
The package already exists https://src.fedoraproject.org/rpms/qesteidutil but
is orphaned. Did you follow the procedure to un-orphan it?
https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package

Package Review:

 - make %{?_smp_mflags} → %make_build

 - make install DESTDIR=%{buildroot} → %make_install

 - Not needed:

%clean
rm -rf %{buildroot}

 - The license file should be included with the %license macro, not %doc:

%files
%doc AUTHORS CONTRIBUTING.md README.md RELEASE-NOTES.md
%license LICENSE.LGPL

 - COPING is not needed as it is the license for the removed
qtsingleapplication bundle.

 - Please remove the excessive linebreak


 - Use pkgconfig for BR when you can:

BuildRequires:  cmake
BuildRequires:  desktop-file-utils
BuildRequires:  pkgconfig(openssl)
BuildRequires:  pkgconfig(Qt5Designer)
BuildRequires:  pkgconfig(libpcsclite) >= 1.7
BuildRequires:  libappstream-glib
BuildRequires:  qtsingleapplication-qt5-devel
Requires:   hicolor-icon-theme
Requires:   opensc%{?_isa}
Requires:   pcsc-lite-ccid%{?_isa}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #1 from Germano Massullo  ---
*** Bug 1513456 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323

Germano Massullo  changed:

   What|Removed |Added

Summary|qesteidutil - Estonian ID   |Review request: qesteidutil
   |card utility|- Estonian ID card utility



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org