[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|---

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #17 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/slop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #16 from Alois Mahdal --- > 20:20 <+mboddu> netvor: Okay, here's what we can do, can you comment on both > of the tickets that with you RH account saying that you want to give them to > "netvor", that way we can verify/confirm

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Blocks|177841

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #14 from Vít Ondruch --- (In reply to Alois Mahdal from comment #9) > (In reply to Robert-André Mauchin from comment #7) > > - libslopy-devel should Requires libslopy: > > > > %package -n libslopy-devel > > Summary:Select

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #13 from Alois Mahdal --- Spec URL: http://file.vornet.cz/tmp/fedora-submit-slop/r11/slop.spec SRPM URL: http://file.vornet.cz/tmp/fedora-submit-slop/r11/slop-7.4-1.fc28.src.rpm Description: slop (Select Operation) is an

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #12 from Alois Mahdal --- (In reply to Robert-André Mauchin from comment #11) > (In reply to Alois Mahdal from comment #9) > > (In reply to Robert-André Mauchin from comment #7) > > > - Use a more meaningful name for your

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #10 from Alois Mahdal --- Spec URL: http://file.vornet.cz/tmp/fedora-submit-slop/r7/slop.spec SRPM URL: http://file.vornet.cz/tmp/fedora-submit-slop/r7/slop-7.4-1.fc28.src.rpm Description: slop (Select Operation) is an

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #9 from Alois Mahdal --- (In reply to Robert-André Mauchin from comment #7) > - Use a more meaningful name for your archive: > > Source0: > https://github.com/naelstrof/slop/archive/v%{version}/%{name}-%{version}.tar. > gz

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #8 from Robert-André Mauchin --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #6 from Alois Mahdal --- The linked page says: > Packagers who want to support only Fedora 28+ in their spec files can > remove scriptlets entirely. For the rest, they should switch to use newly > created macros. I removed them

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #5 from Vít Ondruch --- Actually, if you want to build your package for stable Fedoras and EPEL, you might consider to use these macros instead:

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #4 from Vít Ondruch --- (In reply to Alois Mahdal from comment #2) > (In reply to Vít Ondruch from comment #1) > > * You should not need the %post/%postun sections anymore. > > I swear I saw it yesterday somewhere, but indeed,

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #3 from Alois Mahdal --- (In reply to Alois Mahdal from comment #0) > Spec URL: http://file.vornet.cz/tmp/fedora-submit-slop/slop.spec > SRPM URL: > http://file.vornet.cz/tmp/fedora-submit-slop/slop-7.4-0.scratch.1.src.rpm Spec

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 --- Comment #2 from Alois Mahdal --- (In reply to Vít Ondruch from comment #1) > I am not going to make a full review, but a few notes, since I already > opened the .spec file: > > * The Source0 is fishy. Why don't you get the sources from

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #1

[Bug 1586291] Review Request: slop - Select Operation

https://bugzilla.redhat.com/show_bug.cgi?id=1586291 Alois Mahdal changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced