[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #17 from Fedora Update System --- FEDORA-2020-a4d01ceff3 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #16 from Fedora Update System --- FEDORA-2020-1847d3836d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #15 from Fedora Update System --- FEDORA-2020-a4d01ceff3 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a4d01ceff3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a4d01ceff3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #14 from Fedora Update System --- FEDORA-2020-1847d3836d has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-1847d3836d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1847d3836d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #13 from Fedora Update System --- FEDORA-2020-1847d3836d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1847d3836d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #12 from Fedora Update System --- FEDORA-2020-a4d01ceff3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a4d01ceff3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Erich Eickmeyer changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-29 19:11:07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mudita24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Jerry James --- (In reply to Erich Eickmeyer from comment #9) > I'll bug them, but I can't make promises, especially if they haven't been > active in a while. Not the first time I've run into this address problem. Yes, that old address is still rampant in the open source world for some reason. You'd think 15 years would be long enough for people to notice. :-) Everything looks good now. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #9 from Erich Eickmeyer --- Thanks, Jerry. :) > - The %doc macro puts README into /usr/share/doc/mudita24. The package's > install target puts README.profiles int /usr/share/doc/mudiat24-1.1.0. That > seems wrong. We should create a single doc directory for both files. > You've > got at least these alternatives (I haven't tried any of them, so they may > need some tweaking): > [snip] I went with option #3, looks like it worked. > pkg-config Made the changes. > - Upstream hasn't been active for awhile, but could you ask them to fix the > FSF's address? It's probably best if they just grab a new copy of COPYING > from https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt as a few other > minor things have changed in the last decade and a half or so. I'll bug them, but I can't make promises, especially if they haven't been active in a while. Not the first time I've run into this address problem. Also made the change to the changelog. New files: Spec URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01415759-mudita24/mudita24.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01415759-mudita24/mudita24-1.1.0-1.20160218gite38b1a3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540
--- Comment #8 from Jerry James ---
All you can do is all I can ask.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= ISSUES =
- Remove these lines at the top of the spec file:
#find-debuginfo.sh does not pick-up the debuginfo for whatever reason.
#when built, the .debug file shows in usr/lib/debug/usr/bin
%global debug_package %{nil}
They are wrong. The debuginfo is generated correctly.
- The %cmake macro already includes -DCMAKE_INSTALL_PREFIX:PATH=/usr in its
expansion, so you don't need to specify it again. All you need is "%cmake
.".
- The %doc macro puts README into /usr/share/doc/mudita24. The package's
install target puts README.profiles int /usr/share/doc/mudiat24-1.1.0. That
seems wrong. We should create a single doc directory for both files. You've
got at least these alternatives (I haven't tried any of them, so they may
need some tweaking):
o Pass -Dmudita24_DOC_DIR:PATH=%{_docdir}/%{name} to %cmake and change the
last %files entry to %{_docdir}/%{name}/README.profiles
o At the end of %install, do this:
mv %{buildroot}%{_datadir}/doc/mudita24-%{version}
%{buildroot}%{_datadir}/doc/mudita24
and make the same %files change as above
o At the end of %install, do this:
rm -rf %{buildroot}%{_datadir}/doc/mudita24-%{version}
And then in %files do this:
%doc README mudita24/README.profiles
and just remove the last line in %files
- The %changelog entry has a '-' in the version where it should have a '.';
it should be 1.1.0-1.20160218gite38b1a3 instead of
1.1.0-1-20160218gite38b1a3.
- Since this package uses pkg-config to find its dependencies, use the
"pkgconfig" form of dependency for the BuildRequires. In particular,
"BuildRequires: pkgconfig(alsa)" instead of alsa-lib-devel, and
"BuildRequires: pkgconfig(gtk+-2.0)" instead of gtk2-devel. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
- Upstream hasn't been active for awhile, but could you ask them to fix the
FSF's address? It's probably best if they just grab a new copy of COPYING
from https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt as a few other
minor things have changed in the last decade and a half or so.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #7 from Erich Eickmeyer --- Hi Jerry, I'll see what I can do. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags|needinfo?(fed...@svgames.pl |fedora-review? |) | --- Comment #6 from Jerry James --- I can take this review. Erich, you offered to swap reviews on fedora-devel-list, with the caveat that you weren't sure of your ability. I think it would be good for you to do some reviews, to gain more familiarity with packaging guidelines. Could you attempt a review of bug 1840914? If it proves too much for you, that's okay. The fedora-review tool automates a lot of the steps, which should help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Erich Eickmeyer changed: What|Removed |Added Flags||needinfo?(fed...@svgames.pl ||) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #5 from Erich Eickmeyer --- Thanks, Artur. Either way, I made the correction in the above-posted links (Comment 3). :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Artur Iwicki changed: What|Removed |Added Flags|needinfo?(fed...@svgames.pl | |) | --- Comment #4 from Artur Iwicki --- >There is nothing in that link that says that `rm -rf $RPM_BUILD_ROOT` should >not be used. It says this: >The contents of the buildroot SHOULD NOT be removed in the first line of >%install I'd argue that nuking the directory counts as "removing its contents". ;) >Besides, that was part of the default rpm spec template, so does that mean >there's a bug in the template? I guess so. Since some time ago, templates are no longer active by default (i.e. "vim some_new_package.spec" opens with an empty file), so it's possible they've been neglected a bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 --- Comment #3 from Erich Eickmeyer --- Spec URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01398558-mudita24/mudita24.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01398558-mudita24/mudita24-1.1.0-1.20160218gite38b1a3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540 Erich Eickmeyer changed: What|Removed |Added Flags||needinfo?(fed...@svgames.pl ||) --- Comment #2 from Erich Eickmeyer --- >You should use the %cmake macro instead of a "raw" cmake call here, it'll >ensure that CFLAGS/CXXFLAGS/LDFLAGS are set up properly Fixed. >>%install >>rm -rf $RPM_BUILD_ROOT >Don't do this. >https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections There is nothing in that link that says that `rm -rf $RPM_BUILD_ROOT` should not be used. It says `BuildRoot:` should not be used, but that's not what is being done there. Besides, that was part of the default rpm spec template, so does that mean there's a bug in the template? I'll have new SRPM/SPEC files as soon as COPR starts working again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836540] Review Request: mudita24 - ALSA GUI control tool for Envy24 (ice1712) soundcards
https://bugzilla.redhat.com/show_bug.cgi?id=1836540
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Iwicki ---
>#find-debuginfo.sh does not pick-up the debuginfo for whatever reason.
>%global debug_package %{nil}
>[...]
>%build
>cmake . -DCMAKE_INSTALL_PREFIX=%{_prefix}
You should use the %cmake macro instead of a "raw" cmake call here, it'll
ensure that CFLAGS/CXXFLAGS/LDFLAGS are set up properly.
>%install
>rm -rf $RPM_BUILD_ROOT
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
