[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Pavel Raiskup  changed:

   What|Removed |Added

  Flags|needinfo?(praiskup@redhat.c |
   |om) |



--- Comment #18 from Pavel Raiskup  ---
Thanks to both,
- potential broken-upgrade-path fixed
- app-data patch added


Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/vim-syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/vim-syntastic-3.7.0-5.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #17 from Vít Ondruch  ---
Created attachment 1201568
  --> https://bugzilla.redhat.com/attachment.cgi?id=1201568&action=edit
AppData patch

Here is the patch adding the AppData file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(praiskup@redhat.c
   ||om)



--- Comment #16 from Randy Barlow  ---
I like the idea of renaming it with a vim- prefix, but that makes me inclined
to think that we should also do the obsoletes/provides stuff that a package
rename would do:

https://fedoraproject.org/wiki/Package_Renaming_Process

It sounds like this package was last in Fedora 21 maybe (based on the dead
package file saying that it was dropped in F22), so there could still be users
out there with the old packages that could benefit from the update.

Also, fedora-review is still failing to install the packages:

$ sudo /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 26 --disableplugin=local --setopt=deltarpm=false install
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-ada-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-scss-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-spec-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-scala-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-html-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-matlab-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-erlang-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vhdl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-cucumber-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-asciidoc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-sh-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-haskell-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-yacc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-javascript-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-d-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-perl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-json-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-glsl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-coq-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-yaml-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-tex-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-nasm-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-zsh-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vala-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-ruby-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-cpp-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-rnc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-go-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-c-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-coffee-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-python-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-php-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-eruby-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-xslt-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-haml-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-z80-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-objcpp-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vim-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-tcl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-css-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-cabal-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/v

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #15 from Pavel Raiskup  ---
(In reply to Pavel Raiskup from comment #12)
> TBH, I have no idea what Gnome Software is so I'm not the best
> person to write the patch.  If you can help here, I can include that now
> or in post-review time.

Let me fix my sentence ^^ here.  I wanted to write that if somebody can
help here and _write the patch_, I can include that no or anytime later :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #14 from Pavel Raiskup  ---
Thanks for the links Víťo, but sorry - I have zero motivation in this stuff
now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #13 from Vít Ondruch  ---
(In reply to Pavel Raiskup from comment #12)
> > 2. It is good idea to include AppData file in package, to make this plugin
> > visible in Gnome Software.
> 
> TBH, I have no idea what Gnome Software is so I'm not the best
> person to write the patch.  If you can help here, I can include that now
> or in post-review time.


There is not to much magic in it. Here is the guidelines [0]. You can take some
inspiration in vim-fugitive for example [1, 2 , 3]


[0]
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation
[1]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.metainfo.xml
[2]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.spec#n17
[3]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.spec#n81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #12 from Pavel Raiskup  ---
Thanks for having a look!

(In reply to Vít Ondruch from comment #11)
> 1. I consider good habit to include vim- prefix in vim plugin package name.

That's one of the notes I suggested in original review.

> 2. It is good idea to include AppData file in package, to make this plugin
> visible in Gnome Software.

TBH, I have no idea what Gnome Software is so I'm not the best
person to write the patch.  If you can help here, I can include that now
or in post-review time.

Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/vim-syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/vim-syntastic-3.7.0-4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #11 from Vít Ondruch  ---
Two notes here:

1. I consider good habit to include vim- prefix in vim plugin package name.

2. It is good idea to include AppData file in package, to make this plugin
visible in Gnome Software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #10 from Pavel Raiskup  ---
FTR: https://github.com/rpm-software-management/rpm/pull/91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #9 from Pavel Raiskup  ---
FYI: https://github.com/praiskup/syntastic-rpm/commit/fa3a37e273a538


Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/syntastic-3.7.0-3.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Pavel Raiskup  changed:

   What|Removed |Added

  Flags|needinfo?(praiskup@redhat.c |
   |om) |



--- Comment #8 from Pavel Raiskup  ---
I'll rewrite the thing into lua, as obviously 'fedora-review' doesn't like
the %files section in "append-like" macro.  Or, at least I'm not able to
reproduce without fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Randy Barlow  changed:

   What|Removed |Added

 CC||prais...@redhat.com
  Flags||needinfo?(praiskup@redhat.c
   ||om)



--- Comment #7 from Randy Barlow  ---
One thing to watch out for is that this line was printed several times at the
beginning of the fedora-review command:

warning: line 220: second %files

I think that might be happening due to the %{expand:%files_to_do} near the end,
but I'm not sure. I'm not sure if this is actually an error or not, but you may
want to ensure that things are getting packaged the way you expect. Remember,
getting the files into that fancy macro was just a suggestion on my part, so
it's not required for me to pass the review (though I think it would be easier
for you to maintain in the future if you can get it working!)

Also, fedora-review failed to install the packages to test them out. I tried to
run the same dnf command by hand and got this output:

$ sudo /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 26 --disableplugin=local --setopt=deltarpm=false install
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-nasm-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-haml-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-erlang-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-fortran-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-lisp-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-asm-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-cucumber-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-glsl-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-ruby-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-vim-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-pod-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-po-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-xslt-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-javascript-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-java-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-tcl-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-cobol-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-coq-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-scala-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-matlab-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-python-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-spec-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-less-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-json-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-ada-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-vala-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-cpp-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-lua-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-objc-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-verilog-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-xml-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-html-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-go-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-haskell-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-ocaml-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-sass-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-puppet-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-qml-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-sh-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-c-3.7.0-2.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-syntastic/results/syntastic-cabal-3.7.0-2.fc26.noarch.rp

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #6 from Pavel Raiskup  ---
Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/syntastic-3.7.0-2.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #5 from Pavel Raiskup  ---
(In reply to Randy Barlow from comment #4)
> * Use the %license macro instead of the %doc macro on the LICENSE file.
> * Each subpackage should also have the %license macro.

Done.

> * I think there may be an elixir executable in Fedora now, so the comment in
>   the install section might not be accurate.

Removed.

> * You've got a few lines of commented code - can you remove those?

I removed some of them, but feel free to submit pull request against github
repo.  TBH, to remove others would be too time expensive for me :(  I don't
know most of the file-types and also I don't want to do a huge research.

> * You might want to drop the explicit Requires: on libraries to get rid of the
>   rpmlint errors.

Done.

> * Maybe you can get the %files sections into that fancy macro so you don't
>   have to write all those subpackages' files sections out?

Done.

> * rpmlint is upset about the erlang script interpreter: E:
>   wrong-script-interpreter /usr/share/vim/vimfiles/syntax_checkers/erlang
>   /erlang_check_file.erl /usr/bin/env escript. There are a few more of these
>   about other languages as well.

Ok, I tried to fix this too.

> Once you fix those first two items, let me know and I'll check it out again.

Please take another look, and thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #4 from Randy Barlow  ---
Some things to fix:

* Use the %license macro instead of the %doc macro on the LICENSE file.
* Each subpackage should also have the %license macro.


Optional
* I think there may be an elixir executable in Fedora now, so the comment in
the
  install section might not be accurate.
* You've got a few lines of commented code - can you remove those?
* You might want to drop the explicit Requires: on libraries to get rid of the
  rpmlint errors.
* Maybe you can get the %files sections into that fancy macro so you don't have
  to write all those subpackages' files sections out?
* rpmlint is upset about the erlang script interpreter: E:
  wrong-script-interpreter /usr/share/vim/vimfiles/syntax_checkers/erlang
  /erlang_check_file.erl /usr/bin/env escript. There are a few more of these
  about other languages as well.


Once you fix those first two items, let me know and I'll check it out again.
Thanks for bringing this back!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #3 from Randy Barlow  ---
I love syntastic, and am happy to see it get un-retired!

https://admin.fedoraproject.org/pkgdb/package/rpms/syntastic/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Randy Barlow  changed:

   What|Removed |Added

 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #2 from Pavel Raiskup  ---
Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/syntastic-3.7.0-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

2016-09-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Pavel Raiskup  changed:

   What|Removed |Added

 CC||upstream-release-monitoring
   ||@fedoraproject.org



--- Comment #1 from Pavel Raiskup  ---
*** Bug 1190443 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org