[Bug 1419271] Review Request: leatherman - A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271
Bug 1419271 depends on bug 1502584, which changed state.

Bug 1502584 Summary: Review Request: boost-nowide - boost library making cross 
platform Unicode aware programming easier
https://bugzilla.redhat.com/show_bug.cgi?id=1502584

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman - A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-10-31 06:28:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman - A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Haïkel Guémar  changed:

   What|Removed |Added

Summary|Review Request: leatherman  |Review Request: leatherman
   |-A collection of C++ and|- A collection of C++ and
   |CMake utility libraries |CMake utility libraries



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from James Hogarth  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "BSL (v1.0)", "ISC", "Unknown or generated",
 "BSD (3 clause)". 176 files have unknown license. Detailed output of
 licensecheck in /home/james/workspace/fedora-
 scm/1419271-leatherman/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
 Note:   # false negative in f-r due to debug package changes
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 leatherman-debuginfo , leatherman-debugsource

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

   Assignee|jp...@redhat.com|james.hoga...@gmail.com
  Flags||fedora-review?



--- Comment #9 from James Hogarth  ---
Cool - I'll take over this review then :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Haïkel Guémar  changed:

   What|Removed |Added

  Flags|needinfo?(karlthered@gmail. |
   |com)|



--- Comment #8 from Haïkel Guémar  ---
Spec URL: https://hguemar.fedorapeople.org/reviews/leatherman.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/leatherman-1.3.0-3.fc27.src.rpm

I merged your spec, I only kept compatibility with CentOS SIGs repo which have
a newer boost159-devel, but diff is kept to a minimal by using a %boost_version
macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271
Bug 1419271 depends on bug 1502584, which changed state.

Bug 1502584 Summary: Review Request: boost-nowide - boost library making cross 
platform Unicode aware programming easier
https://bugzilla.redhat.com/show_bug.cgi?id=1502584

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #7 from James Hogarth  ---
The boost module is now available.

Are you okay to push this to the finish line?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271
Bug 1419271 depends on bug 1502584, which changed state.

Bug 1502584 Summary: Review Request: boost-nowide - boost library making cross 
platform Unicode aware programming easier
https://bugzilla.redhat.com/show_bug.cgi?id=1502584

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

 Blocks||1506504




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1506504
[Bug 1506504] Review Request: cpp-hocon - This is a port of the
TypesafeConfig library to C++
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

 Depends On||1502584



--- Comment #6 from James Hogarth  ---
Marking this blocked on the boost-nowide module as that's required to be
unbundled for this review to complete.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1502584
[Bug 1502584] Review Request: boost-nowide - boost library making cross
platform Unicode aware programming easier
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271



--- Comment #5 from James Hogarth  ---
You'll be pleased to know I'm nearly done then - let's join forces to complete
it :)

I'm just about to submit boost-nowide for review - if you want to take that and
do the magic on it?

The rapidjson can't be unbundled yet due to versioning issues (this is being
worked on upstream though to update the version included to the current
version) but seeing how that is linked and the FPC decision a few weeks ago
that's acceptable... and catch is only used in testing so that's fine.

Once boost-nowide is in place and this is building against it then it will be
fine to go through.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Haïkel Guémar  changed:

   What|Removed |Added

  Flags|needinfo?(karlthered@gmail. |
   |com)|



--- Comment #4 from Haïkel Guémar  ---
I'm still working on this but unbundling is far from trivial.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271



--- Comment #3 from James Hogarth  ---
Hi Haïkel,

Are you still going to be able to drive this forward?

If not I'll take it over as it's a blocker to updating facter.

Regards,

James

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com
 Blocks||1223593




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1223593
[Bug 1223593] facter-3.8.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Javier Peña  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Javier Peña  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jp...@redhat.com
   Assignee|nob...@fedoraproject.org|jp...@redhat.com



--- Comment #1 from Javier Peña  ---
Hi Haïkel,

I have found the following issues:

- There seems to be more more than one license in the code (see attached
licensecheck.txt file), we should reflect that in the spec

- The broad wildcard in the -devel subpackage for %{_includedir}/* makes it own
/usr/include/boost, which is owned by boost-devel

- The -devel subpackage includes a python script, should it then Require
python?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271



--- Comment #2 from Javier Peña  ---
Created attachment 1250815
  --> https://bugzilla.redhat.com/attachment.cgi?id=1250815=edit
licensecheck output

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks||1373513 (RDO-OCATA)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1373513
[Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org