[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #16 from Fedora Update System  ---
guile22-2.2.1-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #15 from Jan Synacek  ---
I did an additional round of testing and it seems to be working fine. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-27 16:53:07



--- Comment #14 from Fedora Update System  ---
guile22-2.2.1-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #13 from Fedora Update System  ---
guile22-2.2.1-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5845191ead

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
guile22-2.2.1-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff7cfe0522

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #11 from Fedora Update System  ---
guile22-2.2.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff7cfe0522

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #10 from Fedora Update System  ---
guile22-2.2.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5845191ead

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #9 from Miroslav Lichvar  ---
(In reply to Jason Tibbitts from comment #8)
> Just a note that unless this package contains version 22 of guile, the
> naming guidelines indicate that "guile2.2" is the correct name:
> 
> "
> [...] All other packages derived from it MUST include the base name suffixed
> by either:
> 
> * The package version, which SHOULD include the periods present in the
> original version. 
> [...]
>
> The idea is to avoid the confusion between version 2.2 and version 22.

Good point.

FWIW, I prefer guile22 to keep the naming consistent with compat-guile18. There
are other packages not using dots and I think it's very unlikely we would have
guile-2.2 and guile-22 packaged in Fedora at the same time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #8 from Jason Tibbitts  ---
Just a note that unless this package contains version 22 of guile, the naming
guidelines indicate that "guile2.2" is the correct name:

"
[...] All other packages derived from it MUST include the base name suffixed by
either:

* The package version, which SHOULD include the periods present in the original
version. 
[...]
"

https://fedoraproject.org/wiki/Packaging:Naming#Multiple_packages_with_the_same_base_name

The idea is to avoid the confusion between version 2.2 and version 22.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/guile22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

John Dulaney  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|mlich...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Miroslav Lichvar  ---
Looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

John Dulaney  changed:

   What|Removed |Added

  Flags|needinfo?(jdulaney@fedorapr |
   |oject.org)  |



--- Comment #5 from John Dulaney  ---
Spec URL: https://jdulaney.fedorapeople.org/guile22.spec
SRPM URL: https://jdulaney.fedorapeople.org/guile22-2.2.0-5.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

  Flags||needinfo?(jdulaney@fedorapr
   ||oject.org)



--- Comment #4 from Miroslav Lichvar  ---
Thanks for the update. Except some issues with the info files I think all good.

- %preun is needed to uninstall the info files correctly,
https://fedoraproject.org/wiki/Packaging:Scriptlets#Texinfo
- the install-info commands should (un)install the info files in the package
(guile22 and r5rs22)
- the info files need to be modified, see Jan's comment #2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

John Dulaney  changed:

   What|Removed |Added

  Flags|needinfo?(jdulaney@fedorapr |
   |oject.org)  |



--- Comment #3 from John Dulaney  ---
Spec URL: https://jdulaney.fedorapeople.org/guile22.spec
SRPM URL: https://jdulaney.fedorapeople.org/guile22-2.2.0-4.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #2 from Jan Synacek  ---
As I understand this review, the new guile22 is supposed to be installed
alongside the existing guile 2.0.x package. I think that there are some
potential problems with the spec.

1) You seem to be removing the old info pages in the %preun script. I don't
think that's going to work on updates, plus if need them for the old version,
the info pages are not there on the system anymore.

2) You still ship the compat symlinks to guile and guile-tools, which will
conflict with 2.0.x, will they not?

I created a very similar package some time ago [1], you can get the info pages
install side by side and work after installation with some sed magic.

[1]
https://copr.fedorainfracloud.org/coprs/jsynacek/gnu-guile-2.1.x/build/486009/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

 CC||jdula...@fedoraproject.org
  Flags||needinfo?(jdulaney@fedorapr
   ||oject.org)



--- Comment #1 from Miroslav Lichvar  ---
Thanks for preparing the package. My review follows.

Issues:
===
- I think it would be better for the names of the executables in /usr/bin to
  not include dash, similarly to the compat-guile18 and python3 packages
- The package should probably not include the /usr/bin/guile2{,-tools} symlinks
- Missing Provides: bundled(gnulib)
  See:
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle
- Package contains a libtool archive
/usr/lib64/guile/2.2/extensions/guile-readline.la
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Package has obsolete/wrong scriptlets:
  %triggerin -- guile and %postrans should be removed
  %triggerin -- slib needs to be updated, or removed if slib doesn't work with
guile2.2 yet
- Macro %define mver should be replaced with %global mver

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[-]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/guile/site(compat-
 guile18, guile), /usr/lib64/guile(guile), /usr/include/guile(guile-
 devel), /usr/share/guile(compat-guile18, guile)
 This looks ok.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
 package has .info files.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid 

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsyna...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org