[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 Javier Martinez Canillas changed: What|Removed |Added Status|POST|CLOSED

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #26 from Yunying Sun --- f27 has tpm2-tss 1.1.0, which does not provide resource manager daemon anymore. tpm2-abrmd is the replacing daemon, which is required when using many tpm2 userspace tools like those

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #25 from Yunying Sun --- Koji rawhide build completed for tpm2-abrmd-1.1.0-5: https://koji.fedoraproject.org/koji/taskinfo?taskID=21292902 -- You are receiving this mail because: You are on the CC list for

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #24 from Yunying Sun --- Understood. I will try koji build tomorrow. Thanks. BTW, according to https://pagure.io/fedora-infrastructure/issue/6235, seems the "IOError: [Errno 13] Unable to load configuration

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #23 from Robert-André Mauchin --- As far as I know: « The script [that picks up new packages] does currently only run once per hour and takes about 30min, so you could have a 1.5 hour gap there between a new

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #22 from Yunying Sun --- But "fedpkg build"(https://koji.fedoraproject.org/koji/taskinfo?taskID=21277310) failed with: FAILED: BuildError: package tpm2-abrmd not in list for tag f28-pending Is there

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #21 from Yunying Sun --- Thanks Robert-Andre. You are right, I made an empty commit by mistake and pushed. Just reverted the commit, and pushed a new one with valid files. -- You are receiving this mail

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #20 from Robert-André Mauchin --- I don't think this error is important, if it says it pushed master, it ushed master. However I see a commit here

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #19 from Yunying Sun --- Just tried. Still failed, but with different error. [test@SKLS02 tpm2-abrmd]$ fedpkg push /usr/lib/python2.7/site-packages/fedora/client/bodhi.py:48: DeprecationWarning:

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #18 from Robert-André Mauchin --- Could you retry now to see if it's fixed? Otherwise manifest yourself on this bug report https://pagure.io/fedora-infrastructure/issue/6236 -- You are receiving this mail

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #17 from Yunying Sun --- $fedpkg clone rpms/tpm2-abrmd /usr/lib/python2.7/site-packages/fedora/client/bodhi.py:48: DeprecationWarning: fedora.client.bodhi has been deprecated. Please use

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #16 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tpm2-abrmd -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #15 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tpm2-abrmd -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #14 from Yunying Sun --- New package request created: https://pagure.io/releng/fedora-scm-requests/issue/61 -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #13 from Yunying Sun --- Thanks Robert-Andre for the review and approve. I updated SPEC with the source0 url in your comment. * Wed Aug 16 2017 Sun Yunying - 1.1.0-5 - Updated

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 Robert-André Mauchin (afk until next Thu) changed: What|Removed |Added Status|NEW

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #11 from Yunying Sun --- * Tue Aug 15 2017 Sun Yunying - 1.1.0-4 - Rename and relocate udev rules file to _udevrulesdir - Update scriptlet to add service name after systemd_postrun

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 Robert-André Mauchin changed: What|Removed |Added Assignee|nob...@fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #10 from Robert-André Mauchin --- There's nothing after your %systemd_postun, didn't you forget to add the service file there? %systemd_postun tpm2-abrmd.service -- You are receiving this mail because: You are

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #9 from Robert-André Mauchin --- It looks good to me, it just need to be officially reviewed now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #8 from Yunying Sun --- SRPM URL should be: https://github.com/yunyings/share/raw/master/tpm2-abrmd-1.1.0-3.el7.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #7 from Yunying Sun --- %changelog * Tue Aug 1 2017 Sun Yunying - 1.1.0-3 - Use config option with-systemdsystemunitdir to set systemd unit file location Spec URL:

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #6 from Yunying Sun --- Thanks Robert. I've updated SPEC & SRPMS to address the issues in comment 2: Spec URL: https://raw.githubusercontent.com/yunyings/share/master/tpm2-abrmd.spec SRPM URL:

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #5 from Robert-André Mauchin --- Yes, in %install just move from the file from %{buildroot}/%{_libdir}/systemd/system/tpm2-abrmd.service to %{buildroot}/%{_unitdir} -- You are receiving this mail because: You

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #4 from Yunying Sun --- (In reply to Robert-André Mauchin from comment #2) > Hello, > > A couple of points first: > > - Systemd service files should be installed in %{_unitdir}. See >

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #3 from Yunying Sun --- Thanks Robert-Andre for the first review. With current upstream code base, tpm2-abrmd.service is installed at /usr/lib64/systemd/system/tpm2-abrmd.service, not /lib/systemd/system.

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 Robert-André Mauchin changed: What|Removed |Added CC|

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #1 from Yunying Sun --- Upstream repository: https://github.com/01org/tpm2-abrmd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this