[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Fedora Update System changed: What|Removed |Added Status|ON_QA

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #25 from Andy Li --- I will review the opam package once cmdliner arrive to rawhide. In the mean time, would you review https://bugzilla.redhat.com/show_bug.cgi?id=1517584 for me? -- You are receiving this

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Fedora Update System changed: What|Removed |Added Status|POST

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #24 from Fedora Update System --- ocaml-cmdliner-1.0.2-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2565327532 -- You are receiving this mail

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #23 from Ben Rosser --- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #22 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-cmdliner -- You are receiving this mail because: You are on the CC list for the

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Andy Li changed: What|Removed |Added Status|NEW |POST

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #20 from Ben Rosser --- Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner-1.0.2-5.fc26.src.rpm - Added archful

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Andy Li changed: What|Removed |Added Assignee|rjo...@redhat.com |a...@onthewings.net

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #19 from Andy Li --- Please revise: * You can copy the %doc line of ocaml-cmdliner to ocaml-cmdliner-devel to resolve "ocaml-cmdliner-devel.x86_64: W: no-documentation". * The devel package should

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #18 from Andy Li --- Yes, I will review it. I have just realized that being in the packager group grants me the right to prove packages according to https://fedoraproject.org/wiki/Package_Review_Process This

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #17 from Ben Rosser --- Andy, do you want to take the review then? I'd be happy to review swap for something in exchange. Otherwise I'll ask the devel list. -- You are receiving this mail because: You are

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #16 from Richard W.M. Jones --- I'm still making very slow progress through the OCaml rebuild in Fedora 28. If I were you I'd go onto the Fedora devel list and offer to do a "review swap" with someone. -- You

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Andy Li changed: What|Removed |Added CC||a...@onthewings.net

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #14 from Ben Rosser --- No worries! There have been some review swap threads on devel@ recently and I was just wondering if I should offer a swap for this review. I don't think there's any great rush. --

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Richard W.M. Jones changed: What|Removed |Added Flags|needinfo?(rjo...@redhat.com |

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Ben Rosser changed: What|Removed |Added Flags|

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Ben Rosser changed: What|Removed |Added Blocks||1501992

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Bug 1477363 depends on bug 1487877, which changed state. Bug 1487877 Summary: Review Request: ocaml-result - Compat result type https://bugzilla.redhat.com/show_bug.cgi?id=1487877 What|Removed |Added

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #11 from Ben Rosser --- Now that ocaml-result is in Rawhide, I added a BR on ocaml-result-devel and no longer patch cmdliner to use Pervasives.result instead. I think this should now be ready for review

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Ben Rosser changed: What|Removed |Added Depends On||1487877

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #10 from Ben Rosser --- I should probably go ahead and actually package ocaml-result, now that jbuilder is needed for opam anyway (and also accepted). Trying to build opam with jbuilder fails because I

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #9 from Ben Rosser --- > The final link doesn't include -g so that's one problem: I've fixed this by passing -lflag -g to ocamlbuild, which does add -g to the link step (though as far as I can see, this

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #8 from Richard W.M. Jones --- > %define libname ... I believe that all %define should be %global because of a weirdness of RPM

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #7 from Richard W.M. Jones --- (In reply to Ben Rosser from comment #6) > So it looks like setting true : debug (the equivalent of -tag debug, it > seems) in the _tags file does indeed generate debuginfo in the

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #6 from Ben Rosser --- So it looks like setting true : debug (the equivalent of -tag debug, it seems) in the _tags file does indeed generate debuginfo in the *.o files. However the debuginfo package still

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #5 from Richard W.M. Jones --- I believe you can change the ocamlbuild command line to add ocamlbuild ... -tag debug (https://nicolaspouillard.fr/ocamlbuild/ocamlbuild-user-guide.html) You'll also want to

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #4 from Ben Rosser --- Thanks for taking the review! > Most packages can create debuginfo. Make sure that -g is passed to > every invocation of ocamlc, ocamlopt, ocamlmklib (and maybe others). So cmdliner

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #3 from Richard W.M. Jones --- > %global opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0) Don't use this test. Instead use the %{ocaml_native_compiler} macro which lists arches that support the native

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Richard W.M. Jones changed: What|Removed |Added Assignee|nob...@fedoraproject.org

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #1 from Ben Rosser --- Upstream has since made an actual release incorporating the buildsystem changes that caused me to make a snapshot package. Updated spec and SRPM: Spec URL:

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Hanns-Joachim Uhl changed: What|Removed |Added Blocks|1478035 | -- You

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Hanns-Joachim Uhl changed: What|Removed |Added Blocks|1478034 | -- You

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Hanns-Joachim Uhl changed: What|Removed |Added Blocks||1478034

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

https://bugzilla.redhat.com/show_bug.cgi?id=1477363 Hanns-Joachim Uhl changed: What|Removed |Added Blocks||1478035