needinfo canceled: [Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for dper...@gmail.com's needinfo: Bug 1544239: Review Request: unison248 - There is a new incompatible version of unison240 https://bugzilla.redhat.com/show_bug.cgi?id=1544239 --- Comment #6 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239 dper...@gmail.com changed: What|Removed |Added Flags|needinfo?(dper...@gmail.com | |) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239 Robert-André Mauchin changed: What|Removed |Added Flags||needinfo?(dper...@gmail.com ||) --- Comment #4 from Robert-André Mauchin --- Any update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239
--- Comment #3 from Robert-André Mauchin ---
I am sorry I have forgotten this Review.
- Please use:
%global ver_patch 4
for the latest stable release. Otherwise the Source0 is 404.
- The new archive root folder is just named src/ Thus:
%setup -q -n src
- You'll need to coordinate with unison227 for this:
# Is this package the unisonNNN package with the highest ${ver_compat}
# available in this Fedora branch/release? If so, we provide unison.
%global provide_unison 1
Also try to bring Richard W.M. Jones (rjones) as a comaintainer.
- The package fails to build:
BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 25, characters
16-33:
BUILDSTDERR: Warning 3: deprecated: Stdlib.String.unsafe_set
BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 822, characters
20-21:
BUILDSTDERR: Error: This expression has type string but an expression was
expected of type
BUILDSTDERR: bytes
BUILDSTDERR: make: *** [Makefile.OCaml:435: unicode.cmx] Error 2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239
--- Comment #2 from dper...@gmail.com ---
Thank you for the feedback. I've implemented the requested changes ('Group:'
has been removed, the COPYING file is specified as a %license instead of %doc,
and and Appdata file has been added). Please see:
Spec URL: https://au2pb.org/srpms/unison248.spec
SRPM URL: https://au2pb.org/srpms/unison248-2.48.15v4-2.fc27.src.rpm
https://koji.fedoraproject.org/koji/taskinfo?taskID=24970440
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239 --- Comment #1 from Robert-André Mauchin --- A couple of preliminary remarks: - Group: is not needed anymore in Fedora - The license file (COPYING) must not be included with %doc, but with %license: %files %doc src/NEWS src/README unison-manual.html %license src/COPYING - Please consider adding an Appdata file for the gtk subpackage. See https://fedoraproject.org/wiki/Packaging:AppData -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240
https://bugzilla.redhat.com/show_bug.cgi?id=1544239 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
