[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979

Matt Tyson  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-07-02 23:21:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QSLXSWEELGRHXNR7O7LB32NSY7YA2MUA/

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #8 from Matt Tyson  ---
(In reply to Dan Callaghan from comment #7)
> (In reply to Matt Tyson from comment #6)
> > Where should I point this to? I'm only aware of the github page.  I have not
> > been able to find an official tarball release.  Only a git repo tag.
> 
> There are some special guidelines for the case where upstream only publishes
> git tags and no tarballs.
> 
> https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

Ah, perfect.  Thanks!

Spec file has been updated.

https://github.com/blueness/sthttpd/archive/2845bf5bff2b820d2336c8c8061cbfc5f271e720/sthttpd-2845bf5.tar.gz

or

https://mtyson.fedorapeople.org/sthttpd-2845bf5.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #7 from Dan Callaghan  ---
(In reply to Matt Tyson from comment #6)
> Where should I point this to? I'm only aware of the github page.  I have not
> been able to find an official tarball release.  Only a git repo tag.

There are some special guidelines for the case where upstream only publishes
git tags and no tarballs.

https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #6 from Matt Tyson  ---
(In reply to Itamar Reis Peixoto from comment #4)
>
> the counterpart thttpd has been removed from Fedora because no one cared
> about it, I think this package will have the same future.

I'm a developer on Beaker ( https://beaker-project.org/ ) and thttpd is used as
part of our automated test suite on the Fedora build machines.  thttpd was
dropped from Fedora before I joined Beaker and it's now a bit of a pain point
in our automated provisioning system.

If there's any issues in this package I will be happy to address them.

> 
> if the intention is only to get in @fedora-packager fas group, I think
> filling a ticket here should be better, 
> 

That was not my intention.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Yeah, the sysusers macro shouldn't be used just yet.
> 
> Source0 should be a full URL.

Where should I point this to? I'm only aware of the github page.  I have not
been able to find an official tarball release.  Only a git repo tag.

> 
> Requires: systemd → %?systemd_requires
> [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd]

Done

> 
> %setup -q + %patch0 -p1 → %autosetup -p1

Done

> 
> %{__perl} → perl [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
> only suggests macros for directories, there is no reason to obfuscate
> executable names like that]

Changed to /usr/bin/perl

> 
> /var/run → /run [https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun]

Done

> 
> make %{?_smp_mflags} → %make_build
> 

Done

> You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might
> be a full path. Use just the name of the service.
> %systemd_post %{SOURCE1} → %systemd_post thttpd.service

Done.

Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
Summary|Review Request: sthttpd -   |Review Request: sthttpd -
   |Tiny http server.   |Tiny http server



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Yeah, the sysusers macro shouldn't be used just yet.

Assuming that you actually want sthttpd in Fedora, here's my review:

Source0 should be a full URL.

Requires: systemd → %?systemd_requires
[https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd]

%setup -q + %patch0 -p1 → %autosetup -p1

%{__perl} → perl [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
only suggests macros for directories, there is no reason to obfuscate
executable names like that]

/var/run → /run [https://fedoraproject.org/wiki/Packaging:Guidelines#.2Frun]

make %{?_smp_mflags} → %make_build

You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might be
a full path. Use just the name of the service.
%systemd_post %{SOURCE1} → %systemd_post thttpd.service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #4 from Itamar Reis Peixoto  ---
https://fedoraproject.org/wiki/Changes/SystemdSysusers
https://pagure.io/packaging-committee/issue/442

the counterpart thttpd has been removed from Fedora because no one cared about
it, I think this package will have the same future.

https://src.fedoraproject.org/rpms/thttpd/blob/master/f/dead.package

if the intention is only to get in @fedora-packager fas group, I think filling
a ticket here should be better, 

https://pagure.io/packager-sponsors like I did in this one ->

https://pagure.io/packager-sponsors/issue/337

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #3 from Jason Tibbitts  ---
That macro is extremely new and not yet even permitted by the packaging
guidelines.  Not to mention the means by which the user is added bypasses the
audit system completely.  It's also, as far I understand things, not compatible
with any released version of Fedora.

It certainly shouldn't be suggested that anyone start using it at this point.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979



--- Comment #2 from Matt Tyson  ---
> I think you probably should learn about systemd %sysusers* macro.

Do you have a link to any documentation on this macro?  I can't find much info
about it and other packages in fedora that create users and groups don't seem
to use it either.  (httpd/njinx)

I've added gcc to the BuildRequires

I've sent patches upstream for the utf8 issue and my warnings patch.  I'll
update the specfile and srpm accordingly if/when upstream accepts my patches.

https://github.com/blueness/sthttpd/pull/8
https://github.com/blueness/sthttpd/pull/7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #1 from Itamar Reis Peixoto  ---
rawhide will stop having gcc in default buildroot.

I think you probably should learn about systemd %sysusers* macro.

fix that and send a patch to upstream -> 


for man in docs/*.8 docs/*.1; do
iconv -f iso8859-1 -t utf-8 -o tmp ${man}
mv -f tmp ${man}
done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552979] Review Request: sthttpd - Tiny http server.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552979

Matt Tyson  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org