[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #7 from Artem --- (In reply to Miro Hrončok from comment #6) > This should be called just pre-commit, not python-pre-commit and > python3-pre-commit, thanks. ✅ https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079071-pre-commit/pre-commit.spec ✅ https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079071-pre-commit/pre-commit-1.18.3-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #6 from Miro Hrončok --- This should be called just pre-commit, not python-pre-commit and python3-pre-commit, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 --- Comment #5 from Artem --- Fixed 'python-pre-commit' but not fixed Tests yet: https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079060-python-pre-commit/python-pre-commit.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01079060-python-pre-commit/python-pre-commit-1.18.3-1.fc31.src.rpm --- Packages which we still need to package for 'python-pre-commit': - nothing provides python3.7dist(aspy.yaml) needed by python3-pre-commit-1.18.3-1.fc31.noarch - nothing provides python3.7dist(cfgv) >= 2 needed by python3-pre-commit-1.18.3-1.fc31.noarch - nothing provides python3.7dist(identify) >= 1 needed by python3-pre-commit-1.18.3-1.fc31.noarch Will start packaging them in alphabetical order. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Artem changed: What|Removed |Added Flags|needinfo?(ego.cordatus@gmai | |l.com) | --- Comment #4 from Artem --- Sure. Apologize, it required many python packages which was not packaged when i am first time tried to build it. < 2 days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Miro Hrončok changed: What|Removed |Added Whiteboard||AwaitingSubmitter Flags||needinfo?(ego.cordatus@gmai ||l.com) --- Comment #3 from Miro Hrončok --- Can we please move this forward? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Bug 1694366 depends on bug 1724202, which changed state. Bug 1724202 Summary: Review Request: python-importlib-metadata - Read metadata from Python packages https://bugzilla.redhat.com/show_bug.cgi?id=1724202 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Miro Hrončok changed: What|Removed |Added Depends On||1724202 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1724202 [Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- JFYI I'm packaging importlib-metadata for new tox. Also, this should be called just pre-commit, not python-pre-commit and python3-pre-commit, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Your package is noarch, you don't need this:
%global debug_package %{nil}
No debuginfo is gathered for noarch packages.
- Bump to 1.15.1, drop the patch that has been merged
- Consider using: %?python_enable_dependency_generator
to automatically generates Requires instead of listing them. See
https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators#How_To_Test
(enabled by default in F30)
- Please remove all the trailing spaces in your SPEC. Whatever editor you use
there should be an option to remove trailing spaces on save.
- Seems you don't have all Requires packaged yet:
DEBUG util.py:554: BUILDSTDERR: Error:
DEBUG util.py:554: BUILDSTDERR: Problem: conflicting requests
DEBUG util.py:554: BUILDSTDERR: - nothing provides python3.7dist(aspy.yaml)
needed by python3-pre-commit-1.15.1-1.fc31.noarch
DEBUG util.py:554: BUILDSTDERR: - nothing provides
python3.7dist(importlib-metadata) needed by
python3-pre-commit-1.15.1-1.fc31.noarch
DEBUG util.py:554: BUILDSTDERR: - nothing provides python3.7dist(cfgv) >=
1.4.0 needed by python3-pre-commit-1.15.1-1.fc31.noarch
DEBUG util.py:554: BUILDSTDERR: - nothing provides python3.7dist(identify)
>= 1.0.0 needed by python3-pre-commit-1.15.1-1.fc31.noarch
- Run the tests with pytest
- Simply use:
Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 170 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/python-pre-commit/review-python-pre-
commit/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources
