[pacman-dev] [PATCH v2] libmakepkg: lint all arrays for empty values

2020-10-27 Thread morganamilo
Empty values break pacman's db format, as an empty line indicates an end of section. --- I've seen this out in the wild: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vim-coc-highlight-git=3063e1a6d3e72a35528 diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Andrew Gregory
On 10/28/20 at 01:17am, Morgan Adamiec wrote: > > > On 28/10/2020 01:13, Eli Schwartz wrote: > > On 10/27/20 8:59 PM, Morgan Adamiec wrote: > >> On 28/10/2020 00:46, Eli Schwartz wrote: > >>> It remains unclear to me, why the ambiguity matters. > >>> > >> > >> I guess if you were to officially

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Eli Schwartz
On 10/27/20 9:17 PM, Morgan Adamiec wrote: > So as it turns out -Qip shows the licenses. Installing the package and > doing -Qi only shows a. Confirmed... In /var/lib/pacman/local/e-1-1/desc I do see: ``` %LICENSE% 1 all the extra licenses even in the middle ``` $ pacman -Qi e Licenses

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Morgan Adamiec
On 28/10/2020 01:13, Eli Schwartz wrote: > On 10/27/20 8:59 PM, Morgan Adamiec wrote: >> On 28/10/2020 00:46, Eli Schwartz wrote: >>> It remains unclear to me, why the ambiguity matters. >>> >> >> I guess if you were to officially declare `Key =` means to set the key >> to none then that would

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Eli Schwartz
On 10/27/20 8:59 PM, Morgan Adamiec wrote: > On 28/10/2020 00:46, Eli Schwartz wrote: >> It remains unclear to me, why the ambiguity matters. >> > > I guess if you were to officially declare `Key =` means to set the key > to none then that would solve the issue of it being ambiguous > > Then

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Morgan Adamiec
On 28/10/2020 00:46, Eli Schwartz wrote: > On 10/27/20 8:25 PM, Morgan Adamiec wrote: >> On 28/10/2020 00:04, Allan McRae wrote: >> >>> pkgnames/depends/etc where it may be an issue. So I'm not sure this >>> check finds anything in the "break makepkg/pacman" category. >> >> I disagree, it

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Eli Schwartz
On 10/27/20 8:25 PM, Morgan Adamiec wrote: > On 28/10/2020 00:04, Allan McRae wrote: > >> pkgnames/depends/etc where it may be an issue. So I'm not sure this >> check finds anything in the "break makepkg/pacman" category. > > I disagree, it actually does break something, the srcinfio file > >

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Morgan Adamiec
On 28/10/2020 00:04, Allan McRae wrote: > pkgnames/depends/etc where it may be an issue. So I'm not sure this > check finds anything in the "break makepkg/pacman" category. I disagree, it actually does break something, the srcinfio file Consider the following pkgbuild: pkgbase=foo pkgname=(a

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Allan McRae
On 28/10/20 9:39 am, Morgan Adamiec wrote: > Accidentally sent off list. resending: > > Because there's no reason for a pkgbuild to ever do this so may as well > make it a hard error. AUR packages can't be trusted to get it right. > > We already make an effort to link pkgbuilds to make sure

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Morgan Adamiec
Accidentally sent off list. resending: Because there's no reason for a pkgbuild to ever do this so may as well make it a hard error. AUR packages can't be trusted to get it right. We already make an effort to link pkgbuilds to make sure they're right. I don't how this is different to the other

Re: [pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread Allan McRae
On 28/10/20 7:44 am, morganamilo wrote: > --- > > I've seen this out in the wild: > https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vim-coc-highlight-git=3063e1a6d3e72a35528 > Why would this be an error?I think it would be a warning at best. Also, I think PKGBUILD linting done by

[pacman-dev] [PATCH] libmakepkg: lint all arrays for empty values

2020-10-27 Thread morganamilo
--- I've seen this out in the wild: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vim-coc-highlight-git=3063e1a6d3e72a35528 diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in index 1bc49722..22f5fbbb 100644 ---