Re: [pacman-dev] [PATCH] update a bunch of links for https and to adapt to changing domains

2019-01-13 Thread Allan McRae
On 13/1/19 12:22 pm, Eli Schwartz wrote: > projects.archlinux.org and mailman.archlinux.org are both migrated to > new domains. > > Transifex supports https, so encourage its use by default. > > Signed-off-by: Eli Schwartz > --- > +* link:https://git.archlinux.org/abs.git/[abs] - ABS (Arch

Re: [pacman-dev] [PATCH] makepkg: propagate error codes when package failed to sign correctly

2019-01-09 Thread Allan McRae
On 10/1/19 3:58 pm, Eli Schwartz wrote: > Signed-off-by: Eli Schwartz > --- This patch is on top of something that is not accepted yet so does not apply. A

Re: [pacman-dev] [PATCH] libmakepkg: add routine for linting $SOURCE_DATE_EPOCH

2019-01-09 Thread Allan McRae
On 10/1/19 3:58 pm, Eli Schwartz wrote: > This can only ever be an int, and the specification states that a > malformed timestamp should be considered a fatal error. > > https://reproducible-builds.org/specs/source-date-epoch/ > Signed-off-by: Eli Schwartz > --- > scripts/Makefile.am

Re: [pacman-dev] [PATCH v2 3/3] makepkg: check_pkgver: Report what the bad pkgver is

2019-01-09 Thread Allan McRae
On 10/8/18 3:41 am, Luke Shumaker wrote: > From: Luke Shumaker > > For consistency with check_epoch and check_pkgrel. > > I think that this is important because if there are multiple > provides/depends/whatever that include a version, and one of them is > malformed, including the bad version in

Re: [pacman-dev] [PATCH v2 1/3] makepkg: Better error messages for versions in (check, make, opt)depends/provides/conflicts

2019-01-09 Thread Allan McRae
On 10/8/18 3:41 am, Luke Shumaker wrote: > From: Luke Shumaker > > Given the depends > > depends=('foo>=1.2-1.par2') > > and the error message > > ==> ERROR: pkgver in depends is not allowed to contain colons, forward > slashes, hyphens or whitespace. > > One would be lead to

Re: [pacman-dev] [PATCH v2 2/3] makepkg: check_pkgrel: Don't say "decimal" in the error message

2019-01-09 Thread Allan McRae
On 10/8/18 3:41 am, Luke Shumaker wrote: > From: Luke Shumaker > > If you have a malformed pkgrel, the error message says that it must be a > "decimal". That isn't quite true, as that would mean that `1.1 == 1.10`. > --- > scripts/libmakepkg/lint_pkgbuild/pkgrel.sh.in | 2 +- > 1 file changed,

Re: [pacman-dev] [PATCH] libmakepkg/lint_pkgbuild: check for invalid variables even if they're empty

2019-01-09 Thread Allan McRae
On 13/6/18 11:17 am, Eli Schwartz wrote: > Checking the length of the variable to be non-zero before considering it > an error is inconsistent; license=() and depends='' and `declare arch` > should be considered just as wrong. > > In fact the current check detects depends='' as non-zero and

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-101-g9b637cc2

2019-01-09 Thread Allan McRae
ow. - Log - commit 9b637cc27aba561e5270862a1a3eb515e4f3f744 Author: Allan McRae Date: Thu Jan 10 14:10:47 2019 +1000 be_local.c: remove aligment in local_pkg_ops The alignment was not overly helpful and caused unnecessary churn when a new

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-99-g238fa4af

2019-01-09 Thread Allan McRae
heck would never run. Fix by checking to see if we are trying to build either a package or a source package, and if so, checking for fakeroot. These are the only two situations where fakeroot is needed. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRa

[pacman-dev] [PATCH v2 1/2] libalpm/sync.c: change alpm_sync_newversion() to alpm_sync_get_new_version()

2019-01-09 Thread Allan McRae
emove this filtering altogether. Users of this function can filter the dbs passed to this function to achieve their desired output. Signed-off-by: Allan McRae --- This patch should address the comments Andrew made. I have not added the helper function for filtering databases by alpm_usage_type yet

[pacman-dev] [PATCH v2 2/2] Add [ignored] to -Qu output for packages in repos that are not Usage = Upgrade

2019-01-09 Thread Allan McRae
, which highlighted a larger problem to be fixed first: With-thanks-to: morganamilo With-thanks-to: Michael Straube Signed-off-by: Allan McRae --- src/pacman/query.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index 9ac6e930

[pacman-dev] [PATCH] Add -fstack-clash-protection to CFLAGS in debug builds if available

2019-01-09 Thread Allan McRae
Signed-off-by: Allan McRae --- Tested with GCC (supports this flag) and clang (does not support). Did not add to meson builds, as it appears that all these flags are not added to the build anywhere in the meson files. configure.ac| 1 + m4/acinclude.m4 | 19 +++ 2 files

Re: [pacman-dev] [PATCH] repo-add: don't break if delta package sources contain epoch

2019-01-04 Thread Allan McRae
On 5/1/19 9:23 am, Dave Reisner wrote: > On Fri, Jan 04, 2019 at 11:20:04AM +1000, Allan McRae wrote: >> On 28/12/18 9:15 am, Eli Schwartz wrote: >>> Our sed parser for xdelta3 headers will greedily match on ":" which >>> coincidentally is also the

Re: [pacman-dev] [PATCH] Add [ignored] to -Qu output for packages in repos that are not Usage = Upgrade

2019-01-03 Thread Allan McRae
On 4/1/19 2:21 pm, Allan McRae wrote: > The behaviour of "pacman -Qu" was very strange... It would only consider > packages from repos with Usage = Search (or All), and ignore those with > Usage = Sync, Install or Upgrade. > > This is because alpm_sync_newversion()

[pacman-dev] [PATCH] Add [ignored] to -Qu output for packages in repos that are not Usage = Upgrade

2019-01-03 Thread Allan McRae
llowing who provided initial patches to print [ignored] on -Qu operations, which highlighted the larger problem: morganamilo Michael Straube Signed-off-by: Allan McRae --- In comments on earlier patches, there was debate about what the alpm_sync_newversion() is doing. Although I expect users of thi

[pacman-dev] [PATCH] makepkg: Make pkgdir a local

2019-01-03 Thread Allan McRae
From: "Jan Alexander Steffens (heftig)" Causes it to be reset (to $pkgdirbase/$pkgbase) between subpackages. This shouldn't be visible. Signed-off-by: Allan McRae --- Rebase of https://patchwork.archlinux.org/patch/640/ . scripts/makepkg.sh.in | 4 ++-- 1 file changed, 2 insert

[pacman-dev] [PATCH] makepkg: Create a single-package packaging function

2019-01-03 Thread Allan McRae
From: "Jan Alexander Steffens (heftig)" Merge the similar code handling unsplit PKGBUILDs and individual packages in a split PKGBUILD and make it a new function. Signed-off-by: Allan McRae --- FYI: rebase of https://patchwork.archlinux.org/patch/639/ .FYI Changed run_solo

[pacman-dev] [PATCH v2] makepkg: Only backup package variables once

2019-01-03 Thread Allan McRae
From: "Jan Alexander Steffens (heftig)" We don't need to re-backup the variables we restored on the previous iteration. Signed-off-by: Allan McRae --- Rebase of https://patchwork.archlinux.org/patch/638/ . Posting here as a FYI. scripts/makepkg.sh.in | 2 +- 1 file changed, 1

Re: [pacman-dev] [PATCH v2 1/2] Move skipping of duplicate sync/remove targets into libalpm

2019-01-03 Thread Allan McRae
On 15/12/18 6:44 am, Michael Straube wrote: > sync: > As pointed out by Andrew Gregory there could be an error when adding > duplicates if they are two separate packages with the same name. Add a > check in alpm_add_pkg() to test whether the duplicate is actually the > same package, and if so, log

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-92-g984492b9

2019-01-03 Thread Allan McRae
the character we use to define a version with an epoch. While we are at it, simply use sed for the whole pipeline, rather than using both grep and sed. Fixes FS#61195 Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit 4778f1318853ac9fc1f838d836dbe017

Re: [pacman-dev] [PATCH] repo-add: don't break if delta package sources contain epoch

2019-01-03 Thread Allan McRae
On 28/12/18 9:15 am, Eli Schwartz wrote: > Our sed parser for xdelta3 headers will greedily match on ":" which > coincidentally is also the character we use to define a version with an > epoch. > > While we are at it, simply use sed for the whole pipeline, rather than > using both grep and sed. >

Re: [pacman-dev] [PATCH] repo-remove: fix removing packages with deltas

2019-01-03 Thread Allan McRae
On 27/12/18 1:58 pm, Eli Schwartz wrote: > We have code in order to remove deltas when removing a package, but it > is never run, since we try to remove the wrong file. > > This was broken in commit cb0f2bd0385f447e045e2b2aab9ffa55df3c2d8a which > modified the internal layout we use to modify the

Re: [pacman-dev] [PATCH 4/4] allow tests for disabled features to be skipped

2019-01-03 Thread Allan McRae
On 23/12/18 4:24 pm, Andrew Gregory wrote: > Previously, pacman's test suite would fail when compiled without > signature support. > > Adds a require_capability method to pmtest objects. Currently > recognized values are 'gpg', 'curl', and 'nls'; although only gpg is > used presently. Missing

Re: [pacman-dev] [PATCH] pacman/query: print ignored for updates in databases without usage upgrade

2018-12-17 Thread Allan McRae
On 17/12/18 4:24 am, Michael Straube wrote: > Updates in databases that are not "Usage = Upgrade" will be ignored in a > -Su operation. Add [ignored] to the -Qu output for such updates. > > Fixes FS#59854 > There was discussion about this task when a previous patch was submitted:

Re: [pacman-dev] [PATCH] pacman: print colored optdepends install status

2018-12-11 Thread Allan McRae
On 10/12/18 3:31 am, Michael Straube wrote: > Colorize [installed] and [pending] when printing optional dependencies. > > FS#34920 > > Signed-off-by: Michael Straube > --- Thanks for this patch. I think there was a reason this bug was sitting untouched since 2013... To me, adding colour here

[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.1-9-gcfa1e8b5

2018-12-11 Thread Allan McRae
--- commit cfa1e8b5e2b2fdf66fe41c72d04a8bbc23c28027 Author: Allan McRae Date: Wed Dec 12 11:11:12 2018 +1000 Pull updated translations from Transifex Mostly churn in string headers, but a few new or updated translations. Signed-off-by: A

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-84-gb109d709

2018-12-11 Thread Allan McRae
ave relied on this slash being there. Those tools should be fixed to prevent breaking when custom locations are set, but this is no reason not to fix it on our end as well. An extra trailng slash should never cause harm. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRa

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-81-gb67ec905

2018-12-09 Thread Allan McRae
that comes with PACMAN_DEBUG being defined. Signed-off-by: Allan McRae commit 36a5069a599f2f7d10eb8ad1a2074581f33ff040 Author: Michael Straube Date: Sun Dec 9 18:31:50 2018 +0100 scripts/library: fix typo in README Simply fix a typo: in written -> is written Signed-of

Re: [pacman-dev] [PATCH] Enable additional debug flags/logging with debugoptimized builds

2018-12-09 Thread Allan McRae
On 4/12/18 10:56 pm, Dave Reisner wrote: > On Tue, Dec 04, 2018 at 05:14:50PM +1000, Allan McRae wrote: >> On 4/12/18 12:36 am, Dave Reisner wrote: >>> This lets developers run a local build with optimizations but also the >>> added debug logging that comes with

Re: [pacman-dev] [PATCH] libmakepkg/executable: don't rely on scoped value of $ret to flag outcomes

2018-12-03 Thread Allan McRae
On 28/11/18 2:00 pm, Eli Schwartz wrote: > Elsewhere, we return 1 if a library dropin fails, and when running > functions in a loop, we use `|| ret=1` to preserve scope. This ensures > the return value of the function remains useful in isolation. Do the > same thing here as well. > > Drop trivial

[pacman-dev] [PATCH] configure.ac: use $datarootdir instead of $prefix/share

2018-12-02 Thread Allan McRae
Even worse, makepkg-template ignored $prefix completely. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index c369ca74..ba54c2dd 100644 --- a/configure.ac +++ b/configure.ac @@ -101,7 +101,7 @@ AC_ARG_WITH(buildscript, # Help

Re: [pacman-dev] [PATCH] Make `make distcheck` work again.

2018-12-02 Thread Allan McRae
On 3/12/18 11:44 am, Eli Schwartz wrote: > bash-completion uses pkg-config to determine the best installation > directory, but this does not take --prefix into account (although it > works fine with DESTDIR). The fallback value does attempt to set this > based on --prefix. > > The distcheck uses

Re: [pacman-dev] [PATCH 1/2] libalpm: Add dlclientcert and dlclientkey options.

2018-11-27 Thread Allan McRae
On 15/11/18 2:37 am, Maarten de Vries wrote: > These patches add support for client certificates to alpm and pacman. > > This can already be achieved currently by setting an XferCommand, > but doing so significantly reduces the quality of the feedback pacman > gives during the downloads.

Re: [pacman-dev] [PATCH v2 1/2] makepkg: add internal variable to track when we're building a package

2018-11-27 Thread Allan McRae
On 28/11/18 1:46 am, Eli Schwartz wrote: > On 11/27/18 6:33 AM, Allan McRae wrote: >> On 14/11/18 11:55 am, Eli Schwartz wrote: >>> There are state variables for everything else, and we use them to do >>> conditional checks on things, but it's currently a bit di

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-67-g44cfc095

2018-11-27 Thread Allan McRae
this value for the global default itself makes no sense. Signed-off-by: Andrew Gregory Signed-off-by: Allan McRae commit 61fe73804305a8bbb434cdc245944df5284f1964 Author: Andrew Gregory Date: Sat Nov 24 15:56:12 2018 -0800 always allow explicit empty siglevel for sync dbs

[pacman-dev] [PATCH] Remove Doxyfile from EXTRA_DIST

2018-11-27 Thread Allan McRae
We generate this now, so no need to distribute. Fixes "make dist". Signed-off-by: Allan McRae --- doc/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 711921fd..4bb0f01b 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -

Re: [pacman-dev] [PATCH v2 1/2] makepkg: add internal variable to track when we're building a package

2018-11-27 Thread Allan McRae
On 14/11/18 11:55 am, Eli Schwartz wrote: > There are state variables for everything else, and we use them to do > conditional checks on things, but it's currently a bit difficult to test > whether a package is being built, as it's the default action if *no* > options are specified. > >

Re: [pacman-dev] [PATCH] check localdb before upgrading package

2018-11-27 Thread Allan McRae
On 17/11/18 1:47 pm, Andrew Gregory wrote: > Commit 2ee7a8d89ad693617307260604e1d58757fd2978 replaced a manual check > for a local package with a check for the "oldpkg" member, which gets set > at the beginning of the transaction. If the package was also in the > remove list, such as when a

Re: [pacman-dev] [PATCH 1/3] add specific error for missing gpg support

2018-11-27 Thread Allan McRae
On 25/11/18 9:56 am, Andrew Gregory wrote: > "wrong or NULL argument passed" is a useless error for end users. > > Fixes FS#60880. > > Signed-off-by: Andrew Gregory > --- This patch series looks good to me. Allan

Re: [pacman-dev] [PATCH v3 2/2] Split prepare_buildenv() to libmakepkg

2018-11-27 Thread Allan McRae
On 27/11/18 7:23 pm, Que Quotion wrote: > From: Que Quotion > > This opens the door for third parties to provide libmakepkg > extentions for the purpose of altering the build environment. > > See makepkg-optimize in the AUR for examples. > > Signed-off-by: Que Quotion > --- OK. Caught a

Re: [pacman-dev] [PATCH v3 1/2] Split check_software() to libmakepkg

2018-11-27 Thread Allan McRae
On 27/11/18 7:23 pm, Que Quotion wrote: > From: Que Quotion > > This opens the door for third parties who provide extensions to > libmakepkg to supply scripts that confirm the presence of their > dependant executables. > > See makepkg-optimize in the AUR for examples. > > Signed-off-by: Que

Re: [pacman-dev] [PATCH 8/8] grouping requires semicolons

2018-11-13 Thread Allan McRae
On 5/11/18 11:27 pm, Que Quotion wrote: > From: Que Quotion > ^ this is where context goes. It will help me to understand why this patch is needed. > Signed-off-by: Que Quotion > --- > scripts/libmakepkg/executable/gpg.sh.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [pacman-dev] [PATCH 1/1 v2] Split prepare_buildenv() and check_software()

2018-11-13 Thread Allan McRae
On 6/11/18 12:27 pm, Que Quotion wrote: > From: Que Quotion > > This version is inclusive of all previous patches. > > Split prepare_builenv() and check_software() out of makepkg and into > individual .sh.in scripts for libmakepkg. Creates two new libmakepkg > modules: 'buildenv' and

Re: [pacman-dev] [PATCH] [PATCH 9/9] relocalize using_ccache

2018-11-13 Thread Allan McRae
On 5/11/18 11:50 pm, Que Quotion wrote: > From: Que Quotion > > Should have done this a when putting the two functions together > > Signed-off-by: Que Quotion > --- > scripts/libmakepkg/buildenv/compiler.sh.in | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [pacman-dev] [PATCH] Remove message; pollutes .SCRINFO files

2018-11-13 Thread Allan McRae
On 6/11/18 2:23 am, Que Quotion wrote: > From: Que Quotion > > Signed-off-by: Que Quotion > --- > scripts/libmakepkg/executable.sh.in | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/libmakepkg/executable.sh.in > b/scripts/libmakepkg/executable.sh.in > index

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-57-gde915c4f

2018-11-03 Thread Allan McRae
tabase in commit cb0f2bd0385f447e045e2b2aab9ffa55df3c2d8a and whole code block with message intact was moved into a for loop and run (and printed) twice. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit 3dfec574a36b6aacc2004df3e122dae9d17a4b0d Author: Eli Schwartz Date:

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-10-21 Thread Allan McRae
On 22/10/18 10:03 am, Dave Reisner wrote: > On Mon, Oct 22, 2018 at 09:56:04AM +1000, Allan McRae wrote: >> On 22/10/18 8:57 am, Eli Schwartz wrote: >>>> Also, most projects ship prebuilt man pages. I think some GNU ones >>>> commit the built page to the

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-10-21 Thread Allan McRae
On 22/10/18 8:57 am, Eli Schwartz wrote: >> Also, most projects ship prebuilt man pages. I think some GNU ones >> commit the built page to the tree, so that could be an option. > Both those things are also true about the configure and Makefile.in files... That is another good reason not to use

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-10-21 Thread Allan McRae
On 22/10/18 8:12 am, Dave Reisner wrote: > On Mon, Oct 22, 2018 at 07:54:57AM +1000, Allan McRae wrote: >> On 22/10/18 7:46 am, Dave Reisner wrote: >>> 3) No 'make dist' equivalent. Just run 'git archive' to generate a >>> suitable tarball for distribution. >

Re: [pacman-dev] [PATCH] Add meson.build files to build with meson

2018-10-21 Thread Allan McRae
On 22/10/18 7:46 am, Dave Reisner wrote: > 3) No 'make dist' equivalent. Just run 'git archive' to generate a > suitable tarball for distribution. Is there a way to include pregenerated man pages with git archive? A

Re: [pacman-dev] [PATCH] pacman-key: just accept one file to verify, and enforce detached sigs

2018-10-21 Thread Allan McRae
On 30/5/18 3:00 am, Eli Schwartz wrote: > Simply pass options on to gpg the same way gpg uses them -- no looping > through and checking lots of signatures. > > This prevents a situation where the signature file to be verified is > manipulated to contain a complete signature which is valid, but

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-51-gb5d62d2c

2018-10-21 Thread Allan McRae
Signed-off-by: Allan McRae commit 3561c872ca0980c76442fcbf3985cc92a8f572f7 Author: Eli Schwartz Date: Thu Jun 28 13:19:42 2018 -0400 message.sh: add modifications from output_format.sh In the spirit of making libmakepkg more useful as a library, and, critically, *using* th

Re: [pacman-dev] [PATCH 1/2] bash-completion: don't complete filenames when they're not wanted

2018-10-21 Thread Allan McRae
On 8/9/18 1:58 am, Eli Schwartz wrote: > Filename completion should only be generated for makepkg, when using the > options -p or --config... which means we should offer option completions > by default. > > Filename completion for pacman, should not be generated when using -Qu, > or -F without

Re: [pacman-dev] [PATCH] handle EINTR while polling scripts/hooks

2018-10-21 Thread Allan McRae
On 13/10/18 12:16 pm, Andrew Gregory wrote: > If poll() is interrupted by a signal, alpm was closing the socket it > uses for listening to script/hook output. This would drop script output > at the least and kill the script at the worst. > > Fixes FS#60396 > > Signed-off-by: Andrew Gregory

Re: [pacman-dev] [PATCH] reset signal handlers before running scripts/hooks

2018-10-21 Thread Allan McRae
On 3/10/18 5:42 pm, Andrew Gregory wrote: > Front-ends or libraries may set signals to be ignored, which gets > inherited across fork and exec. This can cause scripts to malfunction > if they expect the signal. To make matters worse, scripts written in > bash can't reset signals that were

Re: [pacman-dev] [PATCH] libmakepkg: fix linting arrays of empty strings

2018-10-21 Thread Allan McRae
On 17/10/18 3:49 am, morganamilo wrote: > [[ ${array[@]} ]] will resolve to false if array only contains empty > strings. This means that values such as "depends=('')" can be inserted > into a pkgbuild and bypass the linting. > > This causes makepkg to successfully build the package while pacman

Re: [pacman-dev] [PATCH v2] libalpm: parse {check, make}depends when reading database

2018-10-08 Thread Allan McRae
On 9/10/18 12:19 pm, Andrew Gregory wrote: > On 10/09/18 at 02:20am, Morgan Adamiec wrote: >> On 09/10/2018 2:15 am, Allan McRae wrote: >>> On 9/10/18 11:05 am, morganamilo wrote: >>>> static struct pkg_operations local_pkg_ops = { >>>> - .get_base

Re: [pacman-dev] [PATCH v2] libalpm: parse {check, make}depends when reading database

2018-10-08 Thread Allan McRae
On 9/10/18 11:05 am, morganamilo wrote: > static struct pkg_operations local_pkg_ops = { > - .get_base= _cache_get_base, > - .get_desc= _cache_get_desc, > - .get_url = _cache_get_url, > - .get_builddate = _cache_get_builddate, > - .get_installdate =

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-35-g7afe5117

2018-09-19 Thread Allan McRae
Signed-off-by: Allan McRae commit bae74c8e9e69b4f4e1a235eef21b9b27fb14aff0 Author: Eli Schwartz Date: Mon Oct 30 14:15:18 2017 -0400 makepkg: add support for the zst format Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit cd7b2d6e07bdbc11f8973bedef0cb0ef02f81563 Au

Re: [pacman-dev] [PATCH] during -Qu add [ignored] for repos without Usage = Upgrade

2018-09-19 Thread Allan McRae
On 20/9/18 3:18 am, Morgan Adamiec wrote: > Yeah -Qu is still a little funky. > >> It gets better... packages in databases with Usage = Upgrade do not >> show up in -Qu. That is clearly wrong! > > I left the requirement on Usage = Search after every one disagreed with > my patch [1] to change

Re: [pacman-dev] [PATCH] during -Qu add [ignored] for repos without Usage = Upgrade

2018-09-19 Thread Allan McRae
On 1/9/18 9:35 am, morganamilo wrote: > Fixes FS#59854 > > Signed-off-by: morganamilo > --- You patch is fine... But in testing it, I once again come to see how screwy -Qu is! We need to go back to your original issue. -Qu ignores databases with Usage = Sync or Install when calculating the

Re: [pacman-dev] [PATCH v3 3/4] makepkg: add support for the zst format

2018-09-19 Thread Allan McRae
On 4/9/18 6:14 pm, Eli Schwartz wrote: > On 12/7/17 12:51 AM, Allan McRae wrote: >> On 31/10/17 04:15, Eli Schwartz wrote: >>> Signed-off-by: Eli Schwartz >>> --- >> >> This and the repo-add patch look fine, but will not be pulled until >> li

Re: [pacman-dev] [PATCH 2/4] Create a convenience library for reused functionality

2018-09-19 Thread Allan McRae
On 6/7/18 12:42 am, Dave Reisner wrote: > This is shared between pacman and pacman-conf (and might be used by > other binaries in the future) -- no need to compile it once for each > consumer. > --- I don't understand this patch... (before) Making all in src/pacman CC check.o CC

Re: [pacman-dev] [PATCH 1/2] Change if-else chain to switch

2018-09-19 Thread Allan McRae
On 19/9/18 12:28 pm, David Phillips wrote: > --- > lib/libalpm/sync.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > Both patches are fine. Note that case statements should be indented one further than the switch statement. I have handed the adjustment. A >

Re: [pacman-dev] [PATCH] makepkg: lint_pkgver: Run even if PKGVERFUNC

2018-09-19 Thread Allan McRae
On 10/8/18 3:42 am, Luke Shumaker wrote: > From: Luke Shumaker > > lint_pkgver returns 0 if PKGVERFUNC, since it's likely that update_pkgver() > will change the value of pkgver anyway, and there's no point in linting the > old value. update_pkgver() will call check_pkgver() itself to validate

Re: [pacman-dev] [PATCH] during -Qu add [ignored] for repos without Usage = Upgrade

2018-09-19 Thread Allan McRae
On 1/9/18 9:35 am, morganamilo wrote: > Fixes FS#59854 > > Signed-off-by: morganamilo > --- Looks good. A > src/pacman/query.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/pacman/query.c b/src/pacman/query.c > index 00c39638..faa06e60 100644 > ---

Re: [pacman-dev] [PATCH v4 2/2] Show group status during file search

2018-09-18 Thread Allan McRae
On 4/9/18 11:47 pm, morganamilo wrote: > When doing "pacman -Fs", show the "(groupname)" > message just like "pacman -Ss". > > And refactor group printing to its own function. > > Signed-off-by: morganamilo > --- Thanks. Normally I'd prefer two patches. The first being the refactor, and the

Re: [pacman-dev] [PATCH] libmakepkg/lint_config: fix lint_variable actually running the PKGBUILD lint

2018-09-18 Thread Allan McRae
On 5/9/18 5:17 am, Eli Schwartz wrote: > Due to a copy-paste error when initially implementing this, it actually > uses a duplicate function name, usually resulting in lint_pkgbuild > overwriting the function definition. > > Then the PKGBUILD lint gets run twice, one time before the PKGBUILD is >

Re: [pacman-dev] [PATCH 1/2] User-visible log when validity check fails due to access

2018-09-18 Thread Allan McRae
On 10/9/18 10:59 am, David Phillips wrote: > Currently, if checking the validity of packages fails due to an access > error on one or more packages, the user must sift through debug output > in order to find the culprit package(s). This patch adds a call to > _alpm_log in such a case to make the

Re: [pacman-dev] [PATCH] pacman: check versioned optdepends in -Qi operation

2018-09-18 Thread Allan McRae
On 19/9/18 12:08 am, Eli Schwartz wrote: > Fixes FS#60106 > > Signed-off-by: Eli Schwartz > --- > src/pacman/package.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pacman/package.c b/src/pacman/package.c > index e80c5953..ee43dca7 100644 > ---

Re: [pacman-dev] [PATCH] scripts: deduplicate localized copyright messages

2018-09-18 Thread Allan McRae
On 18/9/18 11:10 pm, Eli Schwartz wrote: > On 9/18/18 7:51 AM, Allan McRae wrote: >> On 9/5/18 2:12 pm, Eli Schwartz wrote: >>> Fixes FS#58452 >>> Also consistently add a blank line after the copyright and before the >>> license terms. >>> >&g

Re: [pacman-dev] [PATCH] scripts: deduplicate localized copyright messages

2018-09-18 Thread Allan McRae
On 9/5/18 2:12 pm, Eli Schwartz wrote: > Fixes FS#58452 > Also consistently add a blank line after the copyright and before the > license terms. > > Signed-off-by: Eli Schwartz > --- > > Do the email address lines need to be translated? Anyway, currently > updating the pacman copyright year

Re: [pacman-dev] [PATCH] pacman-conf: add missing DisableDownloadTimeout

2018-09-17 Thread Allan McRae
On 11/9/18 7:41 am, morganamilo wrote: > Signed-off-by: morganamilo > --- > src/pacman/pacman-conf.c | 3 +++ > 1 file changed, 3 insertions(+) > Ack. A

Re: [pacman-dev] [PATCH 1/3] makepkg: use bash 4.4 to localize `set` without explicitly saving/restoring

2018-08-29 Thread Allan McRae
On 29/08/18 15:20, Eli Schwartz wrote: > On 8/29/18 12:54 AM, Allan McRae wrote: >> On 14/08/18 11:20, Eli Schwartz wrote: >>> Signed-off-by: Eli Schwartz >>> --- >>> scripts/makepkg.sh.in | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-08-28 Thread Allan McRae
On 29/08/18 14:59, Eli Schwartz wrote: >> My thoughts: >> >> 1) Implementing --print-format usage for -Su is the correct way to >> determine updates. (I guess in combination with --no-confirm?) > > It works today, though, as I mentioned above. The only "problem" is that > people never remember

Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

2018-08-28 Thread Allan McRae
On 14/08/18 11:20, Eli Schwartz wrote: > `run_function_safe pkgver` is evaluated in a subshell and therefore does > not abort when it should. Explicitly check the return outside of the > subshell and abort if necessary. > > Signed-off-by: Eli Schwartz > --- > scripts/makepkg.sh.in | 3 +++ > 1

Re: [pacman-dev] [PATCH 2/3] makepkg: don't save the same shopts twice

2018-08-28 Thread Allan McRae
On 14/08/18 11:20, Eli Schwartz wrote: > Both run_function and run_function_safe will save and restore `shopt -p` > but the former is only called from the latter. It makes sense to save > this as part of a "safe" runner, so let's just do it in one place, there > where we save and restore

Re: [pacman-dev] [PATCH 1/3] makepkg: use bash 4.4 to localize `set` without explicitly saving/restoring

2018-08-28 Thread Allan McRae
On 14/08/18 11:20, Eli Schwartz wrote: > Signed-off-by: Eli Schwartz > --- > scripts/makepkg.sh.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in > index 4024f477..bb8332c6 100644 > --- a/scripts/makepkg.sh.in > +++

Re: [pacman-dev] [PATCH 1/3] makepkg: send messages to stdout rather than stderr

2018-08-28 Thread Allan McRae
On 14/08/18 11:25, Eli Schwartz wrote: > On 6/28/18 1:19 PM, Eli Schwartz wrote: >> This behavior is confusing, since it means absolutely everything goes to >> stderr and makepkg itself is a quiet program that produces no expected >> output??? >> >> The only situation where messages should go to

Re: [pacman-dev] [PATCH v2] Show install status during file search

2018-08-28 Thread Allan McRae
On 17/08/18 14:41, morganamilo wrote: > When doing "pacman -Fs", show the "[installed: version]" > message just like "pacman -Ss". > > Signed-off-by: morganamilo > --- > > Fixed extra \n's > Great - this version looks good to me. A

Re: [pacman-dev] [PATCH] libalpm/sync.c: restrict alpm_sync_newversion by USAGE_UPGRADE

2018-08-28 Thread Allan McRae
On 25/07/18 04:48, Dave Reisner wrote: > On Tue, Jul 24, 2018 at 05:53:00PM +0100, morganamilo wrote: >> Commit 106d0fc54 Added the usage option for databases and >> alpm_sync_newversion was restricted by USAGE_SEARCH instead of >> USAGE_UPGRADE. > I don't recall exactly what my thinking was when

Re: [pacman-dev] [PATCH 1/3] common/ini: Depend on util-common, not util

2018-08-28 Thread Allan McRae
On 20/08/18 07:43, Dave Reisner wrote: > --- > src/common/ini.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/common/ini.c b/src/common/ini.c > index 9d656781..8e646528 100644 > --- a/src/common/ini.c > +++ b/src/common/ini.c > @@ -24,7 +24,7 @@ > #include > >

Re: [pacman-dev] [PATCH] makepkg: Fix whirlpoolsums support

2018-08-27 Thread Allan McRae
On 28/08/18 06:02, Luke Shumaker wrote: > I'm not particularly attached to whirlpool support, and if your > reaction is "let's formally drop whirlpool", I wouldn't be upset by > that. That is my reaction. A

Re: [pacman-dev] [PATCH] Show install status during file search

2018-08-09 Thread Allan McRae
On 12/06/18 06:17, morganamilo wrote: > When doing "pacman -Fs", show the "[installed: version]" > message just like "pacman -Ss". > > Signed-off-by: morganamilo > --- Something not quite right here. Note I have pacman-git installed. allan@kamala ~/arch/code/pacman (patchqueue) $

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-13-g7d05ffce

2018-08-09 Thread Allan McRae
any other notification email; so we list those revisions in full, below. - Log - commit 7d05ffceaf9161a6572505d25b5017e1eb33bf0e Author: Allan McRae Date: Tue May 29 13:57:13 2018 +1000 Remove the last traces of the pacman --fo

Re: [pacman-dev] [PATCH] libalpm: ignore .hook suffix when sorting hooks

2018-08-03 Thread Allan McRae
On 04/08/18 02:29, Eli Schwartz wrote: > On 08/03/2018 12:16 PM, Jouke Witteveen wrote: >>> This one was omitted from 5.1.1, but the documentation was included! >> >> Shall I wait two more years and try again ;-)? >> >> Regards, >> - Jouke > > It's queued for post-5.1.1: >

[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.1

2018-07-26 Thread Allan McRae
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, release/5.1.x has been updated via 7e081d2adf8321f25165255fd21fab61d4055a53 (commit)

[pacman-dev] [GIT] The official pacman repository annotated tag, v5.1.1, created. v5.1.1

2018-07-26 Thread Allan McRae
e5089 (tag) tagging 7e081d2adf8321f25165255fd21fab61d4055a53 (commit) replaces v5.1.0 tagged by Allan McRae on Fri Jul 27 13:07:10 2018 +1000 - Log - elibrokeit -BEGIN PGP SIGNATURE- iQEzBAABCAAdFiEEZkWwqMcAXnj

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.0-32-g7e081d2a

2018-07-26 Thread Allan McRae
ail; so we list those revisions in full, below. - Log - commit 7e081d2adf8321f25165255fd21fab61d4055a53 Author: Allan McRae Date: Fri Jul 27 11:05:51 2018 +1000 Release v5.1.1 Signed-off-by: Allan McRa

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.0-29-g13fb2430

2018-07-26 Thread Allan McRae
--- commit 13fb2430e8e2c5f266e43da85d9adbe5284f0080 Author: Allan McRae Date: Thu Jul 19 14:12:04 2018 +1000 Pull updated translations from Transifex Signed-off-by: Allan McRae commit 0827aff85ee3ac9a02031cbeeb49cae2ae088529 Author: Allan McRae Date: Thu Jul 19 13:54:54

[pacman-dev] [PATCH v3] Handle root prefix in overwrite operations

2018-07-26 Thread Allan McRae
-by: Allan McRae --- v3 - Don't recalculate root prefixed path lib/libalpm/conflict.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 35946de5..716d0088 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm

[pacman-dev] [PATCH] Handle root prefix in overwrite operations

2018-07-18 Thread Allan McRae
-by: Allan McRae --- lib/libalpm/conflict.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 35946de5..2e87cfa1 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -401,8 +401,12 @@ static alpm_pkg_t

[pacman-dev] [PATCH] Remove checking of pkgver in depends entries

2018-07-18 Thread Allan McRae
g. a function or evaluating in a subshell). While not catching these "issues" can result in incorrect SRCINFO, the resulting packages are fine. Stop aborting on these issues until the large number of broken PKGBUILDs are fix, and the restrictions of the PKGBUILD format are documented. Sig

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.0-23-gacef70c1

2018-07-18 Thread Allan McRae
at are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit acef70c1036e3234fe07f2dd1d105f0f59480baa Author: Allan McRae Date: Thu Jun 21 15:36:05 2018 +1000 libmakep

Re: [pacman-dev] [PATCH v2] Merge expac into src/pacman

2018-07-18 Thread Allan McRae
On 11/07/18 03:58, Dave Reisner wrote: > This introduces code which has long been maintained at: > > https://github.com/falconindy/expac > >>From the README: > > expac is a data extraction tool for alpm databases. It features > printf-like flexibility and aims to be used as a simple tool for

Re: [pacman-dev] [RFC PATCH] makepkg: extend the .BUILDINFO for enhanced reproducible support

2018-07-18 Thread Allan McRae
On 19/07/18 08:15, Eli Schwartz wrote: > On 07/18/2018 06:07 PM, Allan McRae wrote: >> On 19/07/18 02:12, Eli Schwartz wrote: >>> Encode information about the compiler and strip flags used, as these >>> will impact the resulting generated binaries. >>

Re: [pacman-dev] interest in using meson over autotools?

2018-07-07 Thread Allan McRae
On 08/07/18 09:13, Dave Reisner wrote: > Yes, some of this could be resolved by fixing/rewriting the autotools > madness to not use recursive make, but I'd suggest we just drop > autotools and adopt meson. Meson can easily fix all of the above. I had a branch on a old dead laptop that rewrote

Re: [pacman-dev] Add --nolist option for transactions

2018-07-07 Thread Allan McRae
On 07/07/18 10:32, m...@dk0.us wrote: > From: Dmitry Kudriavtsev > > Adds a --nolist option for package transactions. This option removes the list > display of packages to be installed or removed. > > Signed-off-by: Dmitry Kudriavtsev > --- I don't think this is a good option to include. >

Re: [pacman-dev] [PATCH 7/7] libmakepkg: disallow using 'any' with other arches

2018-06-23 Thread Allan McRae
On 24/06/18 11:24, Morgan Adamiec wrote: >> Please append a version of you patch in the subject line. e.g. >> [PATCH 7/7 v3] > > Eli gave me a little walk through on the best practises for patches, > next patches will include this. > >> I'm still not happy with this patch. Why not just

Re: [pacman-dev] pacman 5.1.1 and the "final" makepkg bug

2018-06-20 Thread Allan McRae
On 21/06/18 14:38, Eli Schwartz wrote: > On 06/20/2018 09:41 PM, Allan McRae wrote: >> Hi all, >> >> I think we are near the point for a pacman-5.1.1 release. My intention >> is for it to be basically what on master current + the couple of patches >> in my p

<    1   2   3   4   5   6   7   8   9   10   >