Re: [pacman-dev] [PATCH v3 1/2] makepkg: Move parseopts from library to libmakepkg

On 10/08/2016 01:34 PM, Alad Wenter wrote: > parseopts is used in makepkg and other scripts such as pacman-key as a > getopt replacement. > > Instead of including it in those scripts via a macro, move it to > libmakepkg/util/option.sh and have scripts source libmakepkg where > appropriate. Is it

[pacman-dev] [PATCH v3 1/2] makepkg: Move parseopts from library to libmakepkg

parseopts is used in makepkg and other scripts such as pacman-key as a getopt replacement. Instead of including it in those scripts via a macro, move it to libmakepkg/util/option.sh and have scripts source libmakepkg where appropriate. To keep the parseopts test, a new variable was introduced:

[pacman-dev] [PATCH v3 2/2] libmakepkg: generate scripts in util

util/util.sh, util/message.sh, and util/option.sh were the only remaining scripts which were not generated by make. Signed-off-by: Alad Wenter --- scripts/Makefile.am | 5 - scripts/libmakepkg/util/{message.sh => message.sh.in} | 0

Re: [pacman-dev] [PATCH 1/1] lint_pkgbuild/pkgname: pkgname is not allowed to be empty

2016-10-04 10:21 GMT+02:00 Christian Hesse : > From: Christian Hesse > > We checked for empty array elements, but did not catch empty array. Add > a check for that case as well. > > Signed-off-by: Christian Hesse > --- >

Re: [pacman-dev] [PATCH v2] makepkg: Move parseopts from library to libmakepkg

2016-10-08 7:18 GMT+02:00 Alad Wenter : > Signed-off-by: Alad Wenter > --- > v2: Add missing signoff. > > scripts/libmakepkg/util/option.sh | 157 ++ > > scripts/library/README| 20 - >

Re: [pacman-dev] shellcheck conformity for makepkg

On 07.10.2016 03:52, Alad Wenter wrote: > The idea would be that each warning, if applicable, is addressed in a > separate patch. Good idea. If a warning appears multiple times and requires different ways of dealing with it in certain situations, please split that into multiple patches. It