On Sun, 24 Jun 2018 at 03:26, Eli Schwartz wrote:
> But Allan's point seems to be that we shouldn't try to stop people from
> using variables that makepkg does not utilize, just because they look
> vaguely like something makepkg might have used.
The thing is makepkg does use these variables to
On 06/23/2018 10:01 PM, Morgan Adamiec wrote:
> Silly mistakes aside.
>
>> These are not variables being overridden... pkgname_i686 is just not a
>> thing as far as makepkg is concerned.
>
> The point of this is specifically disallow things like 'pkgname_i686'
> rather than just ignore them.
Silly mistakes aside.
> These are not variables being overridden... pkgname_i686 is just not a
> thing as far as makepkg is concerned.
The point of this is specifically disallow things like 'pkgname_i686'
rather than just ignore them.
> Also, this is nothing to do with
> overriding in a
On Sun, 24 Jun 2018 at 02:31, Allan McRae wrote:
>
> On 24/06/18 11:24, Morgan Adamiec wrote:
> >> Please append a version of you patch in the subject line. e.g.
> >> [PATCH 7/7 v3]
> >
> > Eli gave me a little walk through on the best practises for patches,
> > next patches will include this.
>
On 24/06/18 11:24, Morgan Adamiec wrote:
>> Please append a version of you patch in the subject line. e.g.
>> [PATCH 7/7 v3]
>
> Eli gave me a little walk through on the best practises for patches,
> next patches will include this.
>
>> I'm still not happy with this patch. Why not just
> Please append a version of you patch in the subject line. e.g.
> [PATCH 7/7 v3]
Eli gave me a little walk through on the best practises for patches,
next patches will include this.
> I'm still not happy with this patch. Why not just explicitly check that
> "any" is specified on its own,
On Wed, 20 Jun 2018 at 00:52, Allan McRae wrote:
>
> On 20/06/18 05:54, Eli Schwartz wrote:
> > On 06/19/2018 08:28 AM, Allan McRae wrote:
> >> On 09/06/18 05:33, Eli Schwartz wrote:
> >>> On 06/08/2018 02:18 PM, morganamilo wrote:
> We already ensure arch is an array but if arch is never
