Re: [pacman-dev] [PATCH] allow querying fileowner for directories

On Sun, 20 Nov 2011 12:39:11 -0500 Dave Reisner wrote: > On Sun, Nov 20, 2011 at 12:18:59PM -0500, andrew.gregor...@gmail.com > wrote: > > From: Andrew Gregory > > > > Not allowing fileowner queries for directories was an unnecessary > > limitation. Que

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

0-1 /usr/bin/firefox is owned by firefox 8.0-1 error: No package owns / error: failed to read file '/nonexistent': No such file or directory >From 280c6f32deed745a21ff3d059b7b956370425f6e Mon Sep 17 00:00:00 2001 From: Andrew Gregory Date: Sun, 20 Nov 2011 12:01:15 -0500 Subject: [PA

Re: [pacman-dev] [PATCH] allow querying fileowner for directories

On Tue, Nov 22, 2011 at 8:12 PM, wrote: > From: Andrew Gregory > > Removed restriction on querying the owner of a directory. > Replaced mbasename and mdirname with pbasename and pdirname, > similar to their POSIX namesakes except that they do not > modify path, subsequent c

Re: [pacman-dev] [PATCH] libalpm/remove.c - add doxygen

On Sun, 20 May 2012 22:46:58 -0500 Dan McGee wrote: > On Sun, May 20, 2012 at 9:18 PM, wrote: ... > > > > -/** Transaction preparation for remove actions. > > +/** > > + * @brief Transaction preparation for remove actions. > Why the switch away from the existing format? Honestly outside of > al

Re: [pacman-dev] [PATCH] Allow querying directory ownership

returned for a given directory. > Additionally attempt to minimise the number of files getting through > to the slow realpath call. > > This combines ideas from two patches that have been around for a long > time. > > Original-work-by: Andrew Gregory > Original-work-b

Re: [pacman-dev] [PATCH] Allow querying directory ownership

On Tue, 22 May 2012 16:38:42 +1000 Allan McRae wrote: > On 22/05/12 11:20, Andrew Gregory wrote: > > On Tue, 22 May 2012 08:28:11 +1000 > > Allan McRae wrote: > > > >> The restriction of not checking the ownership of a directory is > >> unnecessary given

Re: [pacman-dev] [PATCH v3] Allow querying directory ownership

From: Andrew Gregory --- I did this as a patch against your working branch since it requires changes outside the scope of your original patch. This adds a check that all files/directories are within root before we bother looking for an owner which removes the need for a special check just for

Re: [pacman-dev] [PATCH] add man page for pactree

Found a couple typos and a missing implied option. On Thu, 21 Jun 2012 16:05:16 -0700 ramb...@gmail.com wrote: ... > diff --git a/doc/pactree.8.txt b/doc/pactree.8.txt > new file mode 100644 > index 000..d7a5b4a > --- /dev/null > +++ b/doc/pactree.8.txt > @@ -0,0 +1,64 @@ > +/ > +vim:set

[pacman-dev] [PATCH 1/2] pactree: consolidate both walk_deps functions

Signed-off-by: Andrew Gregory --- src/util/pactree.c | 89 +- 1 file changed, 28 insertions(+), 61 deletions(-) diff --git a/src/util/pactree.c b/src/util/pactree.c index aa02c80..6c91a0a 100644 --- a/src/util/pactree.c +++ b/src/util

[pacman-dev] [PATCH 2/2] pactree: show tree vertical "limbs"

Showing vertical limbs makes the tree easier to follow. Old:New: |--pkg |--pkg |--dep1 |--dep1 |--dep2 | |--dep2 |--dep3 |--dep3 |--dep4 |--dep4 Signed-off-by: Andrew Gregory --- src/util/pactree.c | 80

[pacman-dev] [PATCH] query_fileowner: break/continue pkgfile loop

Break out of pkgfile loop on match or continue if the pkgfile path is too long. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 4 1 file changed, 4 insertions(+) diff --git a/src/pacman/query.c b/src/pacman/query.c index 9b1ea6f..a14b3e3 100644 --- a/src/pacman/query.c +++ b/src

Re: [pacman-dev] [PATCH] query_fileowner: break/continue pkgfile loop

On Sun, 15 Jul 2012 19:23:22 +1000 Allan McRae wrote: > On 08/07/12 05:12, Andrew Gregory wrote: > > Break out of pkgfile loop on match or continue if > > the pkgfile path is too long. > > I agree with the continue - it is stupid we check the length and then do &g

[pacman-dev] [PATCH 1/3] query_fileowner: remove resolve_path function

resolve_path is a equivalent to calling realpath(path, NULL) except that the returned string is guaranteed to be PATH_MAX long. We never append to the returned string, so this is unnecessary. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 23 +++ 1 file changed, 3

[pacman-dev] [PATCH 2/3] query_fileowner: resolve root early

Resolving root early prevents later calls to realpath from having to do the work of actually resolving any symlinks in root. Also removes the unnecessary root variable. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 34 +- 1 file changed, 25 insertions

[pacman-dev] [PATCH 3/3] query_fileowner: remove trailing '/' from targets

Trailing '/' in paths causes lstat to dereference symlinks to directories which causes it to break even though the symlink is a valid target. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/pacman/query.c b/src/pacm

[pacman-dev] [PATCH] query_fileowner: resolve root early

Resolving root early prevents later calls to realpath from having to do the work of actually resolving any symlinks in root. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/src/pacman

[pacman-dev] [PATCH] query_fileowner: remove trailing '/' from targets

Trailing '/' in paths causes lstat to dereference symlinks to directories which causes it to break even though the symlink is a valid target. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/pacman/query.c b/src/pacm

Re: [pacman-dev] [PATCH 2/5] Add _alpm_filelist_resolve

On Sun, 29 Jul 2012 09:50:13 -0400 Dave Reisner wrote: > On Sun, Jul 29, 2012 at 04:18:32PM +1000, Allan McRae wrote: > > From: Andrew Gregory > > > > The _alpm_filelist_resolve function takes a filelist and creates > > a list with any symlinks in directory paths re

[pacman-dev] [PATCH] Add _alpm_filelist_resolve

The _alpm_filelist_resolve function takes a filelist and creates a list with any symlinks in directory paths resolved. Signed-off-by: Andrew Gregory --- Made changes according to Dave's suggestions. Also made some minor adjustments to bring it better into line with the coding standard

[pacman-dev] [PATCH 1/2] _alpm_filelist_resolve: use original filenames where possible

If a filename isn't resolved, the original can be used instead of strdup()ing it. Signed-off-by: Andrew Gregory --- Modified to account for changes to the previous patch. lib/libalpm/filelist.c | 37 + lib/libalpm/package.c | 19 +-- 2

[pacman-dev] [PATCH 2/2] _alpm_filelist_resolve: add useful return code

Return -1 if a path is too long to resolve or we run out of memory. Signed-off-by: Andrew Gregory --- lib/libalpm/filelist.c | 81 -- lib/libalpm/filelist.h | 4 +-- 2 files changed, 47 insertions(+), 38 deletions(-) diff --git a/lib/libalpm

[pacman-dev] [PATCH 0/4] Miscellaneous query_fileowner cleanup

These patches apply on top of my previous query.c patches sitting in Allan's working-split/query-owner branch. Also available under the dirowner_split branch of my repo at https://bitbucket.org/andrewgregory/pacman

[pacman-dev] [PATCH 1/4] query_fileowner: remove assumption that root is "/"

Returning "/" from mdirname removes it as a special case which allows us to test it like any other directory. This corrects a false positive when querying a file in / and root is not set to /. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 31 ++-

[pacman-dev] [PATCH 3/4] query_fileowner: don't append '/' if path is "/"

Signed-off-by: Andrew Gregory --- src/pacman/query.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index 9afe680..d882e5a 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -123,8 +123,10 @@ static int query_fileowner

[pacman-dev] [PATCH 2/4] query_fileowner, mdirname: add error checks

Also consolidates cleanup for query_fileowner. Signed-off-by: Andrew Gregory --- src/pacman/query.c | 28 ++-- src/pacman/util.c | 5 - 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index b1e51a6..9afe680

[pacman-dev] [PATCH 4/4] query.c: fix coding standard violations

--- src/pacman/query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index d882e5a..7381c4e 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -58,7 +58,7 @@ static int search_path(char **filename, struct stat *bufptr)

Re: [pacman-dev] [PATCH 3/4] query_fileowner: don't append '/' if path is "/"

On Mon, 27 Aug 2012 17:24:54 +1000 Allan McRae wrote: > On 12/08/12 07:35, Andrew Gregory wrote: > > Signed-off-by: Andrew Gregory > > --- > > src/pacman/query.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/

[pacman-dev] [PATCH] query_fileowner: don't append '/' if path is "/"

Signed-off-by: Andrew Gregory --- src/pacman/query.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index fc2c90c..92219e8 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -123,8 +123,10 @@ static int query_fileowner

[pacman-dev] [PATCH] Allow querying directory ownership

of files getting through to the slow realpath call. Original-work-by: Dan McGee Original-work-by: Allan McRae Signed-off-by: Andrew Gregory --- Applies on top of my other -Qo patches queued in Allan's working-split/query-owner branch. src/pacman/query.c

Re: [pacman-dev] [PATCH] Allow querying directory ownership

On Fri, 07 Sep 2012 21:56:48 +1000 Allan McRae wrote: > On 07/09/12 21:06, Menachem Moystoviz wrote: > > I'm not a dev, nor the original author of the patch, but... > > > > On Fri, Sep 7, 2012 at 10:29 AM, Allan McRae wrote: > >> On 0

[pacman-dev] [PATCH v2] Allow querying directory ownership

of files getting through to the slow realpath call. Original-work-by: Dan McGee Original-work-by: Allan McRae Signed-off-by: Andrew Gregory --- src/pacman/query.c | 60 +- 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/src

[pacman-dev] [PATCH 1/2] pactree: fix --sync getopt value

The long --sync options has apparently never worked. Signed-off-by: Andrew Gregory --- src/util/pactree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/pactree.c b/src/util/pactree.c index 4488645..ab5d90a 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c

[pacman-dev] [PATCH 2/2] pactree: style last branch node differently

\--dep4 Signed-off-by: Andrew Gregory --- src/util/pactree.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/util/pactree.c b/src/util/pactree.c index ab5d90a..77be629 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c

[pacman-dev] [PATCH] pactree: unindent first limb

Removing the leader for the toplevel package shifted the name left but not it's limb. Signed-off-by: Andrew Gregory --- For the pactree-cleanup branch. src/util/pactree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/pactree.c b/src/util/pactree.c index 7b

[pacman-dev] [PATCH] query.c: simplify is_foreign

Signed-off-by: Andrew Gregory --- src/pacman/query.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index b6913f0..7c4aebd 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -367,19 +367,13 @@ static int

[pacman-dev] [PATCH] Plug various minor memory leaks

Signed-off-by: Andrew Gregory --- lib/libalpm/be_local.c | 1 + lib/libalpm/dload.c| 1 + lib/libalpm/sync.c | 2 +- src/pacman/pacman.c| 5 +++-- src/pacman/util.c | 2 ++ 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm

[pacman-dev] [PATCH] remove isatty check before reading from stdin

The old behavior is undocumented and we already require the user to explicitly request reading from stdin so we should oblige them whether stdin is a tty or not. Signed-off-by: Andrew Gregory --- src/pacman/pacman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pacman

Re: [pacman-dev] [PATCH] remove isatty check before reading from stdin

On Sat, 24 Nov 2012 13:37:25 -0500 Dan McGee wrote: > On Sat, Nov 24, 2012 at 1:29 PM, Dave Reisner > wrote: > > On Sat, Nov 24, 2012 at 01:15:17PM -0500, Andrew Gregory wrote: > >> The old behavior is undocumented and we already require the user > >> to explicitly

[pacman-dev] [PATCHv2] query.c: simplify is_foreign

Signed-off-by: Andrew Gregory --- src/pacman/query.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index b6913f0..1ae11b9 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -367,19 +367,12 @@ static int

[pacman-dev] [PATCH 0/4] [RFC] add caller prefix to alpm_logaction

rification. > [2012-12-20 16:29] [ALPM-SCRIPTLET] >>> See: > https://www.archlinux.org/news/having-pacman-verify-packages > [2012-12-20 16:29] [PACMAN] installed pacman (4.0.3-5) Andrew Gregory (4): alpm_handle_t: add program name for use in log prefix _alpm_logaction: add

[pacman-dev] [PATCH 1/4] alpm_handle_t: add program name for use in log prefix

Signed-off-by: Andrew Gregory --- lib/libalpm/alpm.c | 2 ++ lib/libalpm/alpm.h | 3 +++ lib/libalpm/handle.c | 18 ++ lib/libalpm/handle.h | 1 + lib/libalpm/log.c| 11 --- 5 files changed, 24 insertions(+), 11 deletions(-) diff --git a/lib/libalpm/alpm.c b

[pacman-dev] [PATCH 2/4] _alpm_logaction: add support for prefix

Signed-off-by: Andrew Gregory --- lib/libalpm/log.c | 2 +- lib/libalpm/util.c | 6 +- lib/libalpm/util.h | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/log.c b/lib/libalpm/log.c index 5c4bf9a..0b48d26 100644 --- a/lib/libalpm/log.c +++ b/lib/libalpm

[pacman-dev] [PATCH 3/4] log.c: add alpm_plogaction

Signed-off-by: Andrew Gregory --- lib/libalpm/add.c| 22 +++--- lib/libalpm/alpm.h | 1 + lib/libalpm/log.c| 37 + lib/libalpm/remove.c | 6 +++--- lib/libalpm/util.c | 2 +- 5 files changed, 53 insertions(+), 15 deletions

[pacman-dev] [PATCH 4/4] pacman: set program name for logging

Signed-off-by: Andrew Gregory --- src/pacman/conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index bbec281..f012908 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -621,6 +621,7 @@ static int setup_libalpm(void

[pacman-dev] [PATCH] README: update alpm options

Signed-off-by: Andrew Gregory --- Includes local_file_siglevel and remote_file_siglevel, still in Allan's working branch. README | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/README b/README index 54e8dd6..b4c9978 100644 --- a/README +++ b/R

[pacman-dev] [PATCH v2 1/2] add caller prefix to alpm_logaction

prefix defaults to "UNKOWN" if null or an empty string is provided. Signed-off-by: Andrew Gregory --- lib/libalpm/add.c | 36 ++-- lib/libalpm/alpm.h| 3 ++- lib/libalpm/log.c | 17 - lib/libalpm/log.h | 2 ++ l

[pacman-dev] [PATCH v2 2/2] paclog-pkglist: parse entries with caller info

Signed-off-by: Andrew Gregory --- I'm not very familiar with awk, so there is probably a better way to do this. contrib/paclog-pkglist.sh.in | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/contrib/paclog-pkglist.sh.in b/contrib/paclog-pkglist.

Re: [pacman-dev] [PATCH 1/2] pacsort: add -f, --files option for sorting filenames

On Sat, 19 Jan 2013 11:06:45 -0500 Dave Reisner wrote: > + if(opts.filemode) { > + if(fnmatch("*-*.pkg.tar.?z", name1, 0) == 0 && > + fnmatch("*-*.pkg.tar.?z", name2, 0) == 0) { > + char *s, *e; > + > + s = strchr(name

[pacman-dev] [PATCH] add doxygen comments to conflict.c

Signed-off-by: Andrew Gregory --- lib/libalpm/conflict.c | 94 ++ 1 file changed, 80 insertions(+), 14 deletions(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 0080e7c..610e5ad 100644 --- a/lib/libalpm/conflict.c +++ b/lib

[pacman-dev] [PATCH v3] paclog-pkglist: parse entries with caller info

Signed-off-by: Andrew Gregory --- contrib/paclog-pkglist.sh.in | 24 +--- contrib/updpkgsums.sh.in | 0 2 files changed, 17 insertions(+), 7 deletions(-) mode change 100755 => 100644 contrib/updpkgsums.sh.in diff --git a/contrib/paclog-pkglist.sh.in b/contrib/pac

[pacman-dev] [PATCH v4] paclog-pkglist: parse entries with caller info

Signed-off-by: Andrew Gregory --- Let's try that again without the sneaky permission change this time... contrib/paclog-pkglist.sh.in | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/contrib/paclog-pkglist.sh.in b/contrib/paclog-pkglist.sh.in

Re: [pacman-dev] [PATCH] Provide full path names in warning messages

On Sat, 26 Jan 2013 15:48:53 -0500 Richard Pougnet wrote: > Fix bug #31558 by printing filename instead of entryname > > Signed-off-by: Richard Pougnet > --- Am I missing something? This doesn't look related to FS#31558 - List file containing $srcdir

Re: [pacman-dev] [PATCH] Fix FS#33318 - Make makepkg check for $pkgdir and $srcdir before manpage compression.

On Sat, 26 Jan 2013 16:17:13 -0500 Richard Pougnet wrote: > Call check_package() before calling tidy_package to check for > references to $srcdir and $pkgdir before manpages are compressed. > This allows any references inserted into manpages during the build to > be retained. --- > scripts/makep

Re: [pacman-dev] [PATCH] Update NEWS for pacman-4.1

On Wed, 14 Nov 2012 14:33:11 +1000 Allan McRae wrote: > Signed-off-by: Allan McRae > --- > > DRAFT! > This assumes everything on my working branch will be committed for the 4.1 > release. A couple updates. > + - remove Cygwin and Darwin (OSX) support Darwin support was ultimatel

Re: [pacman-dev] [PATCH] inline libarchive compat wrappers

On Tue, 29 Jan 2013 09:25:18 -0500 Dave Reisner wrote: > Suggested-by: Dan McGee > Signed-off-by: Dave Reisner > --- > lib/libalpm/Makefile.am | 2 +- > .../{libarchive-compat.c => libarchive-compat.h} | 19 > +++ > 2 files changed, 12 inser

[pacman-dev] [PATCH 1/2] unset executable bit on updpkgsums.sh.in

No other contrib script is executable. Signed-off-by: Andrew Gregory --- The scripts in test/scripts are also inconsistent, but I'm not sure whether they should be executable or not. contrib/updpkgsums.sh.in | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>

[pacman-dev] [PATCH 2/2] add missing utilities to contrib/README

Signed-off-by: Andrew Gregory --- contrib/README | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/contrib/README b/contrib/README index 04b656f..b9f6524 100644 --- a/contrib/README +++ b/contrib/README @@ -4,11 +4,14 @@ PKGBUILD.vim - a vim/gvim syntax file

[pacman-dev] [PATCH] document that stdin must not be a tty to read from it

Signed-off-by: Andrew Gregory --- I think I'm alone in wanting to remove the isatty check, but we can at least document it. doc/pacman.8.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index de28b9c..358d506 100644 ---

[pacman-dev] [PATCH] make test/scripts/human_to_size.sh executable

Signed-off-by: Andrew Gregory --- test/scripts/human_to_size_test.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 test/scripts/human_to_size_test.sh diff --git a/test/scripts/human_to_size_test.sh b/test/scripts/human_to_size_test.sh old mode 100644

Re: [pacman-dev] [PATCH] Implement two TODOs about missing error handling

On Thu, 25 Oct 2012 16:57:37 +0200 Alexander Rødseth wrote: > Signed-off-by: Alexander Rødseth > --- The commit message could be more descriptive of what this actually does. Maybe something like 'report errors from _alpm_remove_single_package'. > lib/libalpm/remove.c | 16 +++- >

[pacman-dev] [PATCH] use strtok_r to parse multi-value config options

This prevents multiple spaces between values from being parsed as empty values. Signed-off-by: Andrew Gregory --- src/pacman/conf.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 1bea2b0..d407296 100644 --- a/src

Re: [pacman-dev] [PATCH] use strtok_r to parse multi-value config options

On Sat, 2 Feb 2013 12:39:11 -0500 Dave Reisner wrote: > On Sat, Feb 02, 2013 at 10:16:19AM -0500, Andrew Gregory wrote: > > This prevents multiple spaces between values from being > > parsed as empty values. > > > > Signed-off-by: Andrew Gregory > >

Re: [pacman-dev] [PATCH] Document LocalFileSigLevel and RemoveFileSigLevel

On Tue, 5 Feb 2013 10:56:24 +1000 Allan McRae wrote: > Signed-off-by: Allan McRae > --- Small typo in the commit message. RemoveFileSigLevel -> RemoteFileSigLevel

Re: [pacman-dev] [PATCH] [makepkg] fix -r and --needed conflict

On Sat, 9 Feb 2013 01:54:42 -0600 William Giokas <1007...@gmail.com> wrote: > In makepkg, passing -sr --needed causes there to be a conflict when > pacman goes to remove the dependencies, as the --needed flag is not an > option for pacman -R. This patch sanitizes the PACMAN_OPTS in the > remove_d

[pacman-dev] [PATCH] fix clang -Wformat-nonliteral warnings

GCC is smart enough not to issue a warning when calling a printf function using a va_list; clang is not. Selectively disable the warning using pragmas to allow building with warnings using clang. Signed-off-by: Andrew Gregory --- Adding a bunch of pragmas doesn't strike me as an ideal sol

Re: [pacman-dev] [PATCH] Add format attributes to all required functions

On Sun, 10 Feb 2013 16:51:52 +1000 Allan McRae wrote: > Fixes all clang warnings with -Wformat-literal. > > Also, fix genuine formating issue discovered once adding these attributes > and add a cast to prevent a gcc warning. > > Signed-off-by: Allan McRae > --- Much better than all those prag

[pacman-dev] [PATCH 5/7] fix off-by-one error in _alpm_filelist_resolve

Signed-off-by: Andrew Gregory --- lib/libalpm/filelist.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/libalpm/filelist.c b/lib/libalpm/filelist.c index f29bb7c..c2ca1ca 100644 --- a/lib/libalpm/filelist.c +++ b/lib/libalpm/filelist.c @@ -198,12 +198,15

[pacman-dev] [PATCH 1/7] remove trailing whitespace

Signed-off-by: Andrew Gregory --- lib/libalpm/md5.c | 2 +- lib/libalpm/util.c | 6 ++--- m4/gpgme.m4| 8 +++ m4/libtool.m4 | 2 +- m4/lt~obsolete.m4 | 2 +- test/pacman/README | 70 +++--- 6 files changed, 45 insertions

[pacman-dev] [PATCH 3/7] fix alpm_validation_t comment

Signed-off-by: Andrew Gregory --- lib/libalpm/alpm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 14443bb..5037859 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -68,7 +68,7 @@ typedef enum _alpm_pkgfrom_t

[pacman-dev] [PATCH 2/7] fix style violations

Signed-off-by: Andrew Gregory --- lib/libalpm/be_package.c | 5 +++-- lib/libalpm/signing.c| 3 ++- lib/libalpm/sync.c | 8 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 5361893..3b43ed8 100644 --- a

[pacman-dev] [PATCH 4/7] add alpm_logaction to API updates

Signed-off-by: Andrew Gregory --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index b4c9978..35074d8 100644 --- a/README +++ b/README @@ -464,6 +464,7 @@ API CHANGES BETWEEN 4.0 AND 4.1 - alpm_depend_t - additional desc member - alpm_filelist_t - additional

[pacman-dev] [PATCH 6/7] pmtest: install filesystem entries before packages

local packages should not override explicitly set filesystem contents. Signed-off-by: Andrew Gregory --- test/pacman/pmtest.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/pacman/pmtest.py b/test/pacman/pmtest.py index d141567..6dc0ee6 100644 --- a/test/pacman

[pacman-dev] [PATCH 7/7] find_fileconflicts: reduce path resolution calls

Signed-off-by: Andrew Gregory --- lib/libalpm/conflict.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 610e5ad..96f2109 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -414,6 +414,11

Re: [pacman-dev] [PATCH 6/7] pmtest: install filesystem entries before packages

On Thu, 14 Feb 2013 12:12:50 +1000 Allan McRae wrote: > On 14/02/13 09:54, Andrew Gregory wrote: > > local packages should not override explicitly set filesystem contents. > > > I'm possibly missing something here... local packages were being > installed the

Re: [pacman-dev] [PATCH 5/7] fix off-by-one error in _alpm_filelist_resolve

On Thu, 14 Feb 2013 22:12:59 +1000 Allan McRae wrote: > On 14/02/13 09:54, Andrew Gregory wrote: > > Signed-off-by: Andrew Gregory > > --- > > OK... I'm tired, so feel free to point out where I am wring here... > > AFAIK, realpath will not return a trail

Re: [pacman-dev] [PATCH] Perform limited conflict checking with --force

On Fri, 15 Feb 2013 15:06:17 +1000 Allan McRae wrote: > On 12/02/13 22:23, Allan McRae wrote: > > On 12/02/13 22:05, Allan McRae wrote: > >> Pacman currently bails when trying to extract a file over a directory > >> when using --force. Instead of ignoring all conflict, perform the > >> check and

[pacman-dev] [PATCH 0/5] Use resolved paths for filelist operations

Properly handling symlinks requires using resolved paths. I'm not sure if returning strings instead of file_t structs is the best solution, but it seemed like the least drastic one as we prepare for 4.1 and we weren't using the extra information anyway. Andrew Gregory (5): use alpm

[pacman-dev] [PATCH 2/5] add fileconflict tests for cases with symlinks

Signed-off-by: Andrew Gregory --- test/pacman/tests/fileconflict022.py | 21 + test/pacman/tests/fileconflict023.py | 20 test/pacman/tests/fileconflict024.py | 19 +++ test/pacman/tests/fileconflict025.py | 20 4

[pacman-dev] [PATCH 1/5] use alpm_list_free on filelist intersection

alpm_filelist_intersection returns a list of pointers to internal file_t struct's, so only the list itself should be freed. Signed-off-by: Andrew Gregory --- lib/libalpm/conflict.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/conflict.c b/lib/li

[pacman-dev] [PATCH 3/5] return resolved paths from filelist_intersection

We were comparing files based on resolved paths but returning the original file_t structures, which were not necessarily in the same order. The additional file_t information was never used, so just return the resolved path. Signed-off-by: Andrew Gregory --- lib/libalpm/conflict.c

[pacman-dev] [PATCH 4/5] return resolved paths from filelist_difference

return the resolved path. Signed-off-by: Andrew Gregory --- lib/libalpm/conflict.c | 36 ++-- lib/libalpm/filelist.c | 10 -- test/pacman/tests/fileconflict024.py | 2 -- test/pacman/tests/fileconflict025.py | 2 -- 4 files

[pacman-dev] [PATCH 5/5] use resolved_path for filelist_contains

alpm_filelist_contains was being used to search for resolved paths, but searching in the unresolved paths, causing it to miss matches. Signed-off-by: Andrew Gregory --- lib/libalpm/alpm.h | 2 +- lib/libalpm/conflict.c | 5 + lib/libalpm/filelist.c

Re: [pacman-dev] [PATCH 5/5] use resolved_path for filelist_contains

On Sun, 17 Feb 2013 10:32:48 +1000 Allan McRae wrote: > On 16/02/13 12:02, Andrew Gregory wrote: > > alpm_filelist_contains was being used to search for resolved paths, but > > searching in the unresolved paths, causing it to miss matches. > > > > Si

Re: [pacman-dev] Remove directory symlink support in pacman-4.2 - Was: Use resolved paths for filelist operations

On Sun, 17 Feb 2013 11:14:29 +1000 Allan McRae wrote: > On 16/02/13 12:02, Andrew Gregory wrote: > > Properly handling symlinks requires using resolved paths. I'm not sure if > > returning strings instead of file_t structs is the best solution, but it > > seemed >

Re: [pacman-dev] Remove directory symlink support in pacman-4.2 - Was: Use resolved paths for filelist operations

On Mon, 18 Feb 2013 13:47:54 +1000 Allan McRae wrote: > On 18/02/13 12:52, Andrew Gregory wrote: > > Having reviewed the related code far more than I never wanted to, I > > believe I can get the number of resolved paths down to a manageable > > level while keeping full

Re: [pacman-dev] Remove directory symlink support in pacman-4.2 - Was: Use resolved paths for filelist operations

On Mon, 18 Feb 2013 14:46:14 +1000 Allan McRae wrote: > > Sorry, I meant that one of the packages has a directory that exists on > > the filesystem as a symlink, for example: > > > > filesystem: > > /lib -> /usr/lib > > > > pkg1: > > /lib/foo > > > > pkg2: > > /usr/lib/foo > > > > Without res

[pacman-dev] [PATCHv2] use resolved_path for filelist_contains

can't be called from alpm_filelist_contains. Signed-off-by: Andrew Gregory --- lib/libalpm/alpm.h | 2 +- lib/libalpm/conflict.c | 5 + lib/libalpm/filelist.c | 15 --- lib/libalpm/remove.c | 3 +++ test/pacman/

[pacman-dev] [PATCH] add SYMEXPORT to alpm_filelist_contains

alpm_filelist_contains is listed in alpm.h and should be public but was not exported. Signed-off-by: Andrew Gregory --- lib/libalpm/filelist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libalpm/filelist.c b/lib/libalpm/filelist.c index 6a24903..697dd23 100644 --- a

Re: [pacman-dev] [PATCH] Use non-ascii identifiers for overloaded optflags

On Thu, 21 Feb 2013 13:42:20 -0500 Dave Reisner wrote: > This prevents "non-sensical" combinations of flags from being > misinterpreted, such as: > > $ pacman -Si --changelog $package > --changelog is -c, meaning --clean for -S > > $ pacman -Q --sysupgrade > --sysupgrade is -u, mean

Re: [pacman-dev] Big pause with "pacman -R "

On Wed, 27 Feb 2013 10:04:35 -0500 Dave Reisner wrote: > On Thu, Feb 28, 2013 at 12:23:27AM +1000, Allan McRae wrote: > > Anyone else seeing a massive pause when using "pacman -R" with the > > latest git? Just as the progress bar starts? > > > > Allan > > > > Works for me, with the caveat th

Re: [pacman-dev] [PATCH 01/16] refactor common code in query_search/sync_search

On 03/01/13 at 04:32pm, Simon Gomizelj wrote: > Signed-off-by: Simon Gomizelj > --- > src/pacman/package.c | 77 > > src/pacman/package.h | 3 ++ > src/pacman/query.c | 56 +- > src/pacman/sync.c| 76

Re: [pacman-dev] [PATCH 02/16] remove :: prefix from all message

On 03/01/13 at 04:32pm, Simon Gomizelj wrote: > This will substantially simplify the logic to add colours to messages. > > Signed-off-by: Simon Gomizelj > --- > src/pacman/callback.c | 26 +- > src/pacman/remove.c | 2 +- > src/pacman/sync.c | 14 +++--- >

Re: [pacman-dev] [PATCH 06/16] add a config settings and flag for colors

On 03/01/13 at 04:32pm, Simon Gomizelj wrote: > Colours can be enabled in two ways: > > - Add Color to pacman.conf. This enables colours automatically. > - Use --color=WHEN where WHEN is none/auto/always. > > WHEN as 'never' disables colours (overrides config file), as 'auto' > enables colours wh

Re: [pacman-dev] [PATCH 12/16] colorize the output if -Qi/Si

On 03/01/13 at 04:32pm, Simon Gomizelj wrote: > Signed-off-by: Simon Gomizelj > --- > src/pacman/package.c | 6 +++--- > src/pacman/util.c| 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/pacman/package.c b/src/pacman/package.c > index 6daf745..1486f41 10064

Re: [pacman-dev] [PATCH 07/16] introduce colstr for colourizing

On 03/01/13 at 04:32pm, Simon Gomizelj wrote: > colstr_t colstr will hold the colourizing agents. > > Signed-off-by: Simon Gomizelj > --- > src/pacman/conf.c | 36 > src/pacman/conf.h | 7 +++ > 2 files changed, 43 insertions(+) > > diff --git a/src/pac

[pacman-dev] [PATCH 1/2] pmpkg: add missing directories to test packages

Several tests require complete file lists in order to provide accurate results. These can be non-obvious. Adding missing parent directories helps insure the integrity of tests against human error. Signed-off-by: Andrew Gregory --- test/pacman/pmpkg.py | 11 +++ 1 file changed, 11

[pacman-dev] [PATCH 2/2] fix typos in pacman tests

Signed-off-by: Andrew Gregory --- test/pacman/tests/fileconflict006.py | 4 ++-- test/pacman/tests/fileconflict016.py | 2 +- test/pacman/tests/symlink002.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/pacman/tests/fileconflict006.py b/test/pacman/tests

Re: [pacman-dev] [PATCH] libalpm: Fix installing update of a replaced package

On 03/04/13 at 05:45am, Allan McRae wrote: > On 04/03/13 05:43, Allan McRae wrote: > > On 01/03/13 04:06, Olivier Brunel wrote: > >> During a sysupgrade, if a package is replaced by another, and an update > >> for the > >> former package is found (on another repo) the replaced package would be > >

Re: [pacman-dev] [PATCH] libalpm: Fix installing update of a replaced package

On 03/04/13 at 06:29am, Allan McRae wrote: > On 04/03/13 06:26, Andrew Gregory wrote: > > On 03/04/13 at 05:45am, Allan McRae wrote: > >> On 04/03/13 05:43, Allan McRae wrote: > >>> On 01/03/13 04:06, Olivier Brunel wrote: > >>>> During a sysupgrade

[pacman-dev] [PATCHv2] pmpkg: add missing directories to test packages

didn't seem to be a good place to do this that was always guaranteed to be run, so this adds a finalize() function to packages that will always be run before the package is actually used to allow for this type of tidying. Fixes FS#30723 Signed-off-by: Andrew Gregory --- Not quite as simple

  1   2   3   4   5   6   7   8   9   10   >