[pacman-dev] [PATCH] src/pacman/query.c: do not exit -Qo with error if file does not exist

2017-11-12 Thread iff
From: Ivy Foster Query operations act on the local db, not the filesystem. Also, a valid use case for -Qo is to discover what package owns a deleted file so it can be reinstalled. Closes FS#55856. Signed-off-by: Ivy Foster --- I've opted to simply remove

[pacman-dev] [PATCH v2 1/2] pacman/query.c: in query_fileowner, make is_dir an int

2018-01-24 Thread iff
From: Ivy Foster S_ISDIR is int and "returns non-zero" if the file is a directory. Signed-off-by: Ivy Foster --- I know this is super trivial; I just noticed it while working on the following patch, and didn't want to make an unrelated change in it.

[pacman-dev] [PATCH v3 2/2] src/pacman/query.c: do not exit -Qo with error if file does not exist

2018-01-24 Thread iff
From: Ivy Foster Query operations act on the local db, not the filesystem. Also, a valid use case for -Qo is to discover what package owns a deleted file so it can be reinstalled. Closes FS#55856. Signed-off-by: Ivy Foster --- My apologies for missing the

[pacman-dev] [PATCH v4 1/2] pacman/query.c: in query_fileowner, make is_dir an int

2018-01-25 Thread iff
From: Ivy Foster S_ISDIR is int and "returns non-zero" if the file is a directory. Signed-off-by: Ivy Foster --- src/pacman/query.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index

[pacman-dev] [PATCH v4 2/2] src/pacman/query.c: do not exit -Qo with error if file does not exist

2018-01-25 Thread iff
From: Ivy Foster Query operations act on the local db, not the filesystem. Also, a valid use case for -Qo is to discover what package owns a deleted file so it can be reinstalled. Closes FS#55856. Signed-off-by: Ivy Foster --- This version checks to make

[pacman-dev] [PATCH 5/5] pacman-conf.c: make parse_opts only parse opts

2018-02-08 Thread iff
From: Ivy Foster Previously, it also parsed the config file instead of simply setting the (global) config_file variable Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH 2/5] pacman-conf: simplify usage()

2018-02-08 Thread iff
From: Ivy Foster Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index

[pacman-dev] [PATCH 3/5] pacman-conf: Make myname and myver into cpp macros MYNAME and MYVER

2018-02-08 Thread iff
From: Ivy Foster This allows MYNAME to be used in place of the literal string "pacman-conf" in usage Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH 0/5] Miscellaneous pacman-conf tweaks

2018-02-08 Thread iff
From: Ivy Foster I started fiddling around with pacman-conf today, because I wanted to add short options to it, and then just sort of...kept on for a bit. Oh, I could be wrong, but I think that 'pacman-conf --repo ' pretty much covers [FS#25568][1]. [1]:

[pacman-dev] [PATCH 4/5] pacman-conf: Make cleanup run automagically at exit

2018-02-08 Thread iff
From: Ivy Foster Since using atexit(3) draws in stdlib anyway and this changes every exit call at large and return call in main(), go ahead and use EXIT_SUCCESS and EXIt_FAILURE, too. Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 29

[pacman-dev] [PATCH 1/5] pacman-conf: accept short options

2018-02-08 Thread iff
From: Ivy Foster Also change '-?' no longer to be an error, because if we're going to check for it anyway, why make it an error? Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[pacman-dev] [PATCH] doc/.gitignore: ignore all manpages

2018-02-10 Thread iff
From: Ivy Foster They're all generated during make. --- I was going to add BUILDINFO.5 to the list, but this way covers future additions. doc/.gitignore | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/doc/.gitignore b/doc/.gitignore index

[pacman-dev] [PATCH v2 5/5] pacman-conf.c: make parse_opts only parse opts

2018-02-10 Thread iff
From: Ivy Foster Previously, it also parsed the config file instead of simply setting the (global) config_file variable Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH v2 2/5] pacman-conf.c: simplify usage()

2018-02-10 Thread iff
From: Ivy Foster Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index

[pacman-dev] [PATCH v2 4/5] pacman-conf.c: Make cleanup run automagically at exit

2018-02-10 Thread iff
From: Ivy Foster Since using atexit(3) draws in stdlib anyway and this changes every exit call at large and return call in main(), go ahead and use EXIT_SUCCESS and EXIt_FAILURE, too. Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 29

[pacman-dev] [PATCH v2 3/5] pacman-conf: Make myname and myver into cpp macros MYNAME and MYVER

2018-02-10 Thread iff
From: Ivy Foster This allows MYNAME to be used in place of the literal string "pacman-conf" in usage Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH v2 1/5] pacman-conf.c: accept short options

2018-02-10 Thread iff
From: Ivy Foster Signed-off-by: Ivy Foster --- This verion of the patch simply drops the check for '?', since it's caught by "default" anyway. The other patches are unchanged, except where rebased against this modified patch. src/pacman/pacman-conf.c | 3

[pacman-dev] [PATCH v3 1/5] pacman-conf.c: accept short options

2018-02-10 Thread iff
From: Ivy Foster Signed-off-by: Ivy Foster --- As per agregory's request in #archlinux-pacman, this version of the patch leaves the check for '?' well enough alone. '?' is getopt_long(3)'s way of indicating user error, and we can think of default: as

[pacman-dev] [PATCH v3 5/5] pacman-conf.c: make parse_opts only parse opts

2018-02-10 Thread iff
From: Ivy Foster Previously, it also parsed the config file instead of simply setting the (global) config_file variable Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH v3 3/5] pacman-conf: Make myname and myver into cpp macros MYNAME and MYVER

2018-02-10 Thread iff
From: Ivy Foster This allows MYNAME to be used in place of the literal string "pacman-conf" in usage Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[pacman-dev] [PATCH v3 2/5] pacman-conf.c: simplify usage()

2018-02-10 Thread iff
From: Ivy Foster Signed-off-by: Ivy Foster --- src/pacman/pacman-conf.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index

[pacman-dev] [PATCH] pacman-conf.c: exit if cannot set rootdir or parse config file

2018-02-16 Thread iff
From: Ivy Foster --- src/pacman/pacman-conf.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index 4ffa24a3..aa0cdf22 100644 --- a/src/pacman/pacman-conf.c +++ b/src/pacman/pacman-conf.c @@ -77,7

[pacman-dev] [PATCH v4 2/2] pacman-conf.c: exit if cannot create config data structure

2018-02-15 Thread iff
From: Ivy Foster --- src/pacman/pacman-conf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index ab73d896..4ffa24a3 100644 --- a/src/pacman/pacman-conf.c +++ b/src/pacman/pacman-conf.c @@ -400,7

[pacman-dev] [PATCH v4 1/2] pacman-conf.c: add short options

2018-02-15 Thread iff
From: Ivy Foster --- src/pacman/pacman-conf.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index 1e6f55f9..ab73d896 100644 --- a/src/pacman/pacman-conf.c +++ b/src/pacman/pacman-conf.c