Re: [Patch] Fix issue for pass generate 0

2018-02-08 Thread Jason A. Donenfeld
LHS is implicitly quoted in bash's [[. On Feb 9, 2018 00:54, "Bernardo da Costa" < bernardo.da-co...@polytechnique.org> wrote: On Thu, Feb 08, 2018 at 11:11:55PM +0100, mauli wrote: > Hi, > > in the IRC someone was having issues with 100% CPU use when generating a > password with length 0, I

Re: [Patch] Fix issue for pass generate 0

2018-02-08 Thread Bernardo da Costa
On Thu, Feb 08, 2018 at 11:11:55PM +0100, mauli wrote: > Hi, > > in the IRC someone was having issues with 100% CPU use when generating a > password with length 0, I found that read -r -n 0 just keeps on going. > I cannot find this behavior documented if NCHARS is set to 0. > > --- > diff --git

Re: [Patch] Fix issue for pass generate 0

2018-02-08 Thread Jason A. Donenfeld
Thanks! Patched here: https://git.zx2c4.com/password-store/commit/?id=ffef92ee0ed10551b20521f2d6e5637c8f9da798 ___ Password-Store mailing list Password-Store@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/password-store

[Patch] Fix issue for pass generate 0

2018-02-08 Thread mauli
Hi, in the IRC someone was having issues with 100% CPU use when generating a password with length 0, I found that read -r -n 0 just keeps on going. I cannot find this behavior documented if NCHARS is set to 0. --- diff --git a/src/password-store.sh b/src/password-store.sh index e3e5659..2afb51b

Re: [PATCH 0/6] Add new option: --next-clip,-C for commands: `generate`, `show` that will enable using an alternative clipboard than the default

2018-02-08 Thread Doron Behar
You are right, I forgot about your comment when I started to actually add this feature. How about `-p` and `--prim`? It could be very symmetric to `-c` and `--clip`. Now that I'm thinking about it, perhaps this way we don't even need `$PASSWORD_STORE_DEFAULT_X_SELECTION` or