Re: [PATCH] views: don't duplicate tags in patch message when generating mbox

2016-11-22 Thread Andrew Donnellan
On 23/11/16 18:01, Andrew Donnellan wrote: When generating an mbox for a patch with tags in the original commit message, e.g.: Example patch This patch is awesome! Signed-off-by: Andrew Donnellan Acked-by: Russell Currey the

[PATCH] views: don't duplicate tags in patch message when generating mbox

2016-11-22 Thread Andrew Donnellan
When generating an mbox for a patch with tags in the original commit message, e.g.: Example patch This patch is awesome! Signed-off-by: Andrew Donnellan Acked-by: Russell Currey the tags from the original email are duplicated:

Re: [PATCH v2 10/13] REST: Add id field to all endpoints

2016-11-22 Thread Andy Doan
On 11/19/2016 10:51 AM, Stephen Finucane wrote: Signed-off-by: Stephen Finucane Cc: Andy Doan --- patchwork/api/check.py | 2 +- patchwork/api/patch.py | 6 +++--- patchwork/api/person.py | 2 +- patchwork/api/project.py | 2 +-

Re: [PATCH v2 09/13] tests: Rework REST API tests

2016-11-22 Thread Andy Doan
On 11/19/2016 10:51 AM, Stephen Finucane wrote: - Combine anonymous user tests with authenticated user tests - Rename and simplify some tests - Improve documentation Signed-off-by: Stephen Finucane Cc: Andy Doan Works for me. At one point, I could

Re: [PATCH v2 08/13] REST: Make 'User.first_name', 'last_name' editable

2016-11-22 Thread Andy Doan
On 11/19/2016 10:51 AM, Stephen Finucane wrote: These would be valuable to change via the API. Signed-off-by: Stephen Finucane Cc: Andy Doan --- I never anticipated much value from this. ie - if someone wants to change their name, I'd think they'd

Re: [PATCH v2 04/13] REST: Make use of the 'source' property

2016-11-22 Thread Andy Doan
On 11/19/2016 10:51 AM, Stephen Finucane wrote: This is apparently the correct way to rename fields, and will ensure a future API version that supports writes will work correctly. Signed-off-by: Stephen Finucane Cc: Andy Doan Much better:

Re: [PATCH v2 02/13] REST: Remove '_url' suffixes

2016-11-22 Thread Andy Doan
On 11/19/2016 10:51 AM, Stephen Finucane wrote: This was a design decision made when implementing the REST API. The idea was that these items were URLs to related objects and should be indicated as such. However, this was a faulty assumption as the Patchwork API, unlike other some other APIs