Re: [PATCH] README: Add travis badge

2016-09-07 Thread Daniel Axtens
Stephen Finucane writes: > Signed-off-by: Stephen Finucane Reviewed-by: Daniel Axtens Regards, Daniel > --- > README.md | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/README.md b/README.md > index

Re: [PATCH 7/7] Test Django 1.6 and 1.7 under Python 2.7 in Travis

2016-09-07 Thread Daniel Axtens
Stephen Finucane writes: > On 09 Aug 14:55, Daniel Axtens wrote: >> This will hopefully catch any other breaking changes sooner! >> >> Signed-off-by: Daniel Axtens > > Merged into the other patch, along with some Python environments that > seemed

[PATCH 1/2] parsemail: Convert to a management command

2016-09-07 Thread Stephen Finucane
Management comands allow applications to register their own actions with 'manage.py'. This provides some advantages, like automatically configuring Django (removing the need for 'django.setup' calls) and removing the need to set the PYTHON_PATH. The 'parsemail' script is a natural fit for this

Re: [PATCH v2 3/6] parser: Add series parsing

2016-09-07 Thread Stephen Finucane
On 05 Sep 14:31, Russell Currey wrote: > On Mon, 2016-09-05 at 14:25 +1000, Andrew Donnellan wrote: > > On 05/09/16 14:19, Russell Currey wrote: > > > > > > In testing v2 I found a weird issue I didn't find before. Try this: in 'find_series', reverse the result of the 'find_references' call

[PATCH 2/3] settings: noqa the secret key

2016-09-07 Thread Stephen Finucane
This is a development setting file. Dismiss the 'dodgy' warning on landscape.io. Signed-off-by: Stephen Finucane --- patchwork/settings/dev.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py

[PATCH 3/3] fields: Stub out unused arguments

2016-09-07 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- patchwork/fields.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/fields.py b/patchwork/fields.py index c0a1b4d..6c000c0 100644 --- a/patchwork/fields.py +++ b/patchwork/fields.py @@ -46,7 +46,7 @@

Re: [PATCH 2/2] utils: Rename to 'notifications'

2016-09-07 Thread Stephen Finucane
On 01 Sep 22:38, Stephen Finucane wrote: > Every function in this file is related to notifications. Rename the > file and functions therein to something more meaningful. > > Signed-off-by: Stephen Finucane This is unrelated to the previous patch and tests are

Re: [PATCH 1/3] gitignore: Don't ignore all hidden files

2016-09-07 Thread Stephen Finucane
On 07 Sep 20:53, Stephen Finucane wrote: > On 05 Sep 20:23, Daniel Axtens wrote: > > Hey Stephen, > > > > > -*~ > > > -\#*\# > > > > It looks like you've dropped *~ and \#*\# - is that deliberate? > > Nope - I'll add when I merge :) > > Stephen Resolved and merged.

Re: [PATCH 2/3] Add landscape.io configuration file

2016-09-07 Thread Stephen Finucane
On 05 Sep 20:25, Daniel Axtens wrote: > Hi Stephen, > > I can't test this but I'm supportive of more automatic testing :) > > Regards, > Daniel > > Stephen Finucane writes: > > > Signed-off-by: Stephen Finucane ...and merged.

Re: [PATCH] views: Avoid mutable default arguments

2016-09-07 Thread Stephen Finucane
On 04 Sep 01:29, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane Obvious code quality fix. Merged. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH] tox: Don't create '.pyc' files

2016-09-07 Thread Stephen Finucane
On 03 Sep 21:08, Stephen Finucane wrote: > In '8e58c29', code was added to delete '.pyc' files. However, this was > later reverted in '9fd161' due to the increase in run time that this > incurred. However, the need to avoid stale '.pyc' files still exists. > To resolve this, add the

Re: [PATCH 1/2] templates: Include Patchwork version in footer

2016-09-07 Thread Stephen Finucane
On 07 Sep 10:48, Daniel Axtens wrote: > Hi Stephen, > > > This is managed using a combination of hardcoded string, for > > installations from tarball, and 'git describe', for installations from > > a Git repo. > > > > This includes installing Git in the Docker environment, to enable this > > in

Re: [PATCH 01/10] stick django version to 1.8

2016-09-07 Thread Thomas Monjalon
2016-09-07 10:42, Daniel Axtens: > >> > --- a/requirements-prod.txt > >> > +++ b/requirements-prod.txt > >> > @@ -1,2 +1,2 @@ > >> > -Django>=1.8,<1.10 > >> > +Django>=1.8,<1.9 > > > > Unfortunately, the requirement <1.9 does not download Django 1.8 > > but a release candidate of the version 1.9.