Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-16 Thread Daniel Richard G .
On Thu, 15 Nov 2012, Zoltán Herczeg wrote: Hi Daniel, Only problem is, it's not clear how the assembly should refer to local variables (from and to). I was reviewing this article... I may misunderstand something here, but I thought you target sparc not x86. Yes; the document is

Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-16 Thread Zoltán Herczeg
It would be easy enough to test---just disable the cpp case that uses __cpuid(). I cannot. GCC supports ATT sytax only. Visual C does not support any inline assembly in 64 bit mode: http://msdn.microsoft.com/en-us/library/wbk4z78b.aspx (And I can confirm that is true). However, we might be

Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-16 Thread Zoltán Herczeg
Hi, Well, our audience here isn't just people following the list today, but also people Googling for this information years from now. Hello readers in 2017! :-) still feels out of scope. SourceForge provides some kind of forum, perhaps we could use that:

Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-15 Thread Daniel Richard G .
On Thu, 15 Nov 2012, Zoltán Herczeg wrote: Hi Daniel, Could you split the patch into two: Okay, I'll work on that. 1) Older solaris support I think an #if based soultion could work here: #if defined(old_solaris) asm for old solaris #else original code #endif Only problem is, it's not

Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-15 Thread Zoltán Herczeg
Hi Daniel, Only problem is, it's not clear how the assembly should refer to local variables (from and to). I was reviewing this article... I may misunderstand something here, but I thought you target sparc not x86. Why not provide an Intel-syntax equivalent of the ATT assembly instead of an

Re: [pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-14 Thread Zoltán Herczeg
Hi Daniel, thanks for the patch! Would it be a problem, if I would land it after the next pcre release? We focus on fixes now, and this is kind of a new feature. * Added defined(__INTEL_COMPILER) to the appropriate conditionals * Moved the 64-bit _MSC_VER case up so that this is used in

[pcre-dev] [PATCH] JIT support with Intel compiler, older Solaris

2012-11-13 Thread Daniel Richard G .
I've encountered some further issues in building PCRE with JIT support in some less-than-usual environments. One is using the Intel compiler (icc) on 64-bit Linux. Normally, it #defines __GNUC__ and compiles the same code as GCC, but in my case, the compatibility was causing me trouble and I