Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-13 Thread Zoltán Herczeg
Hi am I understand correctly that no JIT is involved here? You tell me :-) I certainly built PCRE with JIT support... pcretest runs tests without JIT by default. -s+ needs to be passed to pcretest, or s+ to a specific test to enable JIT. The bad pattern has s flag, bot no plus so it is

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-12 Thread Zoltán Herczeg
Hi, am I understand correctly that no JIT is involved here? The output stops after: ~(\w+)/?(.)*/(\1)~smgI The test itself requires a huge stack. (Did you enlarge the stack area for pcretest?) Could you try this test manually: pcretest.exe -q mytest The mytest should only contain this

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-12 Thread Daniel Richard G .
On Wed, 12 Dec 2012, Zoltán Herczeg wrote: Hi, am I understand correctly that no JIT is involved here? You tell me :-) I certainly built PCRE with JIT support... The output stops after: ~(\w+)/?(.)*/(\1)~smgI The test itself requires a huge stack. (Did you enlarge the stack area for

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-12 Thread Graycode
On Wed, 12 Dec 2012, Daniel Richard G. wrote: I linked it with /STACK:1000; should that be enough? Whether it's enough depends on many factors. As Philip recently reminded me, the pcrestack man page states: The actual amount of stack used per recursion can vary quite a lot, depending

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-08 Thread Philip Hazel
On Thu, 6 Dec 2012, Daniel Richard G. wrote: On Thu, 6 Dec 2012, Graycode wrote: Yet the CMakeLists.txt file currently contains: IF(MSVC) ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE) ENDIF(MSVC) I'm not a Cmake user, but that seems a more appropriate place for settings

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-08 Thread Zoltán Herczeg
Thank you, Philip. Daniel, please test the current code, and let me know if any other issues remain. Regards, Zoltan Philip Hazel p...@hermes.cam.ac.uk írta: On Thu, 6 Dec 2012, Daniel Richard G. wrote: On Thu, 6 Dec 2012, Graycode wrote: Yet the CMakeLists.txt file currently contains:

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-06 Thread Graycode
On Wed, 5 Dec 2012, Daniel Richard G. wrote: The attached patch adds _CRT_SECURE_NO_WARNINGS to the CMake config header template to shoo these away. Yet the CMakeLists.txt file currently contains: IF(MSVC) ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE) ENDIF(MSVC) I'm not a Cmake user,

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-06 Thread Zoltán Herczeg
Hi, I landed a somewhat bigger patch, which contains all changes you reported in the last few weeks. Thanks for porting and testing! I saw there are some conversion related warnings as well, let me know if you have any fixes for them. Regards, Zoltan -- ## List details at

Re: [pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-06 Thread Daniel Richard G .
On Thu, 6 Dec 2012, Graycode wrote: Yet the CMakeLists.txt file currently contains: IF(MSVC) ADD_DEFINITIONS(-D_CRT_SECURE_NO_DEPRECATE) ENDIF(MSVC) I'm not a Cmake user, but that seems a more appropriate place for settings that are unique to a particular compiler brand and version.

[pcre-dev] [PATCH] Quash deprecation warnings on Windows

2012-12-05 Thread Daniel Richard G .
In building PCRE 8.32 on Windows, I noticed the following warnings come up numerous times: 8 warning #1786: function fopen (declared at line 237 of C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\INCLUDE\stdio.h) was declared deprecated (This function or variable may be