I THink it should really be:
if((x-x_file = sys_fopen(filename-s_name, r)) == 0)
sys_fopen returns NULL (also known as 0) on failure, otherwise a pointer;
it makes no sense to check the sign of a pointer as far as I know.
cheers
Miller
On Fri, Apr 04, 2014 at 11:21:37PM -0400, Martin Peach
Hi Miller,
On my windows machines (XP and 8.1), if I tried to open with mode 'r', the
later call to ov_open would fail. If I change the mode to 'rb', the later
call to ov_open works fine. I also read somewhere that the 'b' mode does
nothing on Unix (I still have to test that when I'm back to my
I also find it strange that using the external on pd-vanilla by copying the
dll to the extra folder in the vanilla directory works fine. Any ideas
why? Maybe has something to do with compiler environment differences
between vanilla and extended? Do you guys use MinGW for both?
On Sat, Apr 5,
I think vanilla is compiled with MSVC and extended with MinGW so there
are incompatibilities in the c runtime especially where file pointers
are concerned. Sometimes externals will work on both versions but if the
external opens its own files using Pd functions to find the path then it
Extended on MinGW and my libpd project on MinGW show the same problem, that
makes sense. Thanks, Martin!
On Sat, Apr 5, 2014 at 10:49 AM, Martin Peach martin.pe...@sympatico.cawrote:
I think vanilla is compiled with MSVC and extended with MinGW so there are
incompatibilities in the c runtime
On 04/05/2014 05:48 AM, Simon Wise wrote:
On 05/04/14 14:21, Martin Peach wrote:
I think it's here:
http://sourceforge.net/p/pure-data/patches/
that seems to be for pd rather than externals???
it's for pd, pd-extended and externals (if they are maintained in the
repository on
I think it's here:
http://sourceforge.net/p/pure-data/patches/
Martin
On 2014-04-04 21:49, Rafael Vega wrote:
Even more stuff ;)
In the same file, oggread~.c there is a line that reads:
if((x-x_file = sys_fopen(filename-s_name, r)) 0)
But it should be:
if((x-x_file =
On 05/04/14 14:21, Martin Peach wrote:
I think it's here:
http://sourceforge.net/p/pure-data/patches/
that seems to be for pd rather than externals???
maybe a patch to debian package pd-pdogg, which could then get upstream, since
for some (especially older) externals this may be the most
