Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-29 Thread Ferenc Kovacs
On Wed, May 29, 2013 at 11:09 AM, Dominic Black wrote: > I think it's best to keep it where it is, as people have already > downloaded the repo from there and moving it may cause people problems > pulling future updates. > > ok, that means less work for me ;) -- Ferenc Kovács @Tyr43l - http://

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-29 Thread Dominic Black
I think it's best to keep it where it is, as people have already downloaded the repo from there and moving it may cause people problems pulling future updates. On Wed, May 29, 2013 at 9:15 AM, Ferenc Kovacs wrote: > > > > On Sun, May 26, 2013 at 5:54 PM, Dominic Black wrote: > >> Submitted the

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-29 Thread Ferenc Kovacs
On Sun, May 26, 2013 at 5:54 PM, Dominic Black wrote: > Submitted the request 2 weeks ago, got the VCS account yesterday - bump for > the Pecl account? > > http://news.php.net/php.pecl.dev/10625 > > I've approved your pecl account (was waiting for the VCS account approvement), created the package

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-26 Thread Dominic Black
Submitted the request 2 weeks ago, got the VCS account yesterday - bump for the Pecl account? http://news.php.net/php.pecl.dev/10625 On Sat, May 11, 2013 at 10:35 AM, Pierre Joye wrote: > go ahead, add anyone in this thread as sponsor :) > > On Sat, May 11, 2013 at 10:48 AM, Dominic Black > w

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-11 Thread Pierre Joye
go ahead, add anyone in this thread as sponsor :) On Sat, May 11, 2013 at 10:48 AM, Dominic Black wrote: > Will anybody sponsor this? > > > On Tue, Apr 30, 2013 at 10:12 AM, Johannes Schlüter > wrote: > >> On Tue, 2013-04-30 at 11:06 +0200, Michael Wallner wrote: >> >> >> > Ah sorry, I just (inco

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-11 Thread Ferenc Kovacs
let's wait until monday so others have also a last chance, if nobody volunteers (or objects) until, go ahead and refer me as a sponsor. 2013.05.11. 10:48, "Dominic Black" ezt írta: > Will anybody sponsor this? > > > On Tue, Apr 30, 2013 at 10:12 AM, Johannes Schlüter > wrote: > > > On Tue, 2013-0

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-05-11 Thread Dominic Black
Will anybody sponsor this? On Tue, Apr 30, 2013 at 10:12 AM, Johannes Schlüter wrote: > On Tue, 2013-04-30 at 11:06 +0200, Michael Wallner wrote: > > > > Ah sorry, I just (incorrectly?) remembered some spl foo not properly > > exported by headers... > > > Then those might be bugs and should be f

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-30 Thread Dominic Black
Hi guys, Thanks for all the input - this was my first attempt an a PHP extension, so a lot of it was trail and error and trying to work out the documentation. I've made the suggested changes, and fixed a couple of other things that I noticed while doing it. Code is up on github. What is the best

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-30 Thread Johannes Schlüter
On Tue, 2013-04-30 at 11:06 +0200, Michael Wallner wrote: > Ah sorry, I just (incorrectly?) remembered some spl foo not properly > exported by headers... > Then those might be bugs and should be fixed in the core. Adding custom declarations for core things might be an "emergency" solution but sh

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-30 Thread Michael Wallner
On 30 April 2013 10:57, Johannes Schlüter wrote: > On Tue, 2013-04-30 at 10:05 +0200, Michael Wallner wrote: > > > > - the spl_ce_BadFunctionCallException must not be declared static, but > > extern. > > Neither. One should include ext/spl/spl_exceptions.h and use the > declaration from the heade

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-30 Thread Johannes Schlüter
On Tue, 2013-04-30 at 10:05 +0200, Michael Wallner wrote: > > - the spl_ce_BadFunctionCallException must not be declared static, but > extern. Neither. One should include ext/spl/spl_exceptions.h and use the declaration from the header instead of declaring yourself. In this specific case though

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-30 Thread Michael Wallner
On 29 April 2013 11:30, Dominic Black wrote: > > Current source code is at; https://github.com/DomBlack/php-scrypt > Just some comments: - the spl_ce_BadFunctionCallException must not be declared static, but extern. - if you depend on extensions like SPL and hash, delcare it with ZEND_MODULE_DE

Re: [PECL-DEV] Addition of php-scrypt to pecl

2013-04-29 Thread Alexey Zakhlestin
On 29.04.2013, at 13:30, Dominic Black wrote: > Hi, > > I would like to submit my extension PHP-Scrypt to be added PECL. > > It adds scrypt hashing functionality to PHP along with a pick > params function which allows the extension to manipulate the difficulty > settings based on your server h