[PECL-DEV] Re:[PECL-DEV] Apply for maintenance and add PECL Extensions
Hi: http://news.php.net/php.pecl.dev/15288 this is my account application address, is still waiting for the review, it has been half a month, I am still waiting, ask the community to handle it, thank you! Viest 在2018年04月26日 18:32,Anatol Belski 写道: Hi Viest, On Thu, 2018-04-26 at 01:21 +0800, dev wrote: > Hi: > > Thank you very much for the case provided by "Anatol Belskit>", which was very helpful to me! > > I modified the project (https://github.com/viest/php-ext-excel-export > ) and used valgrind to test the memory process. If there are other > problems with the project, I will make quick changes! > > Thanks to the help of "Anatol Belski ", I believe PHP's > ecology will be getting better and better. > thanks for checking the comments. Your fixes look good so far. I've found a place which can potentially cause a memory leak. See https://gi thub.com/viest/php-ext-excel-export/blob/master/kernel/excel.c#L160 . For example if the filename method would be called multiple times successive. Other than that, IMO the quality should be now acceptable. It's now to see for perhaps more comments. Processing the account request might take some time, but someone from the admin team would sure come to it. Regards Anatol
[PECL-DEV] 回复:[PECL-DEV] Apply for maintenance and add PECL Extensions
Hi I am very happy to have your reply. I would like to confirm that the extension can join PECL? dev 邮箱:d...@service.viest.me 签名由 网易邮箱大师 定制 在2018年04月25日 02:07,Anatol Belski 写道: Hi, On Thu, 2018-04-05 at 00:03 +0800, 王杰新 wrote: > Hi: I have a new PHP extension and a maintenance extension that I > want to add to PECL; New extensions: This extension solves the > problem that PHP exports excel slowly and has a large memory > footprint, which is very desirable; Url: > https://github.com/viest/php-ext-excel-export I went for a quick review. An issue is with the global variable excel_res, see https://github.com/viest/php-ext-excel-export/blob/master/excel_writer. c#L21 That means - multiple objects may access and modify it, per fact it's not possible - in the thread safe build, it will lead to access violations and crashes The proper way to handle it is to encapsulate the resource into the object. Every object needs to have a separate instance of the excel resource. Also here - https://github.com/viest/php-ext-excel-export/blob/master/k ernel/excel.c#L453 . While the private properties might be usable, you can save them into the object struct - for both simplicity and faster access. For the next steps, you also could think about serialization, or disable it at least. Other that that, the dependency lib libxlsxwriter seems to be BSD licenced. Please correct me, if I'm wrong. In general, I think this ext could find it's place in PECL. > Maintenance extensions: This is a PHP extension for fast string > search and replace. It is 2 by StringUtils. PHP. It supports multiple > search terms. We use It as a replacement for PHP 's STRTR, which is > extremely missile in certain cases. The Chinese script conversion is > one of those cases. This extension USES a Commentz - Walter style > algorithm for multiple search terms, or a Boyer Moore - algorithm for > single search terms. Url: https://github.com/viest/php-ext-ffs Some of the sources are under GPL, which is not accepted in PECL. At some places you use long instead of zend long also. If it's possible to replace GPL'd implementations, one could look further. Regards Anatol
[PECL-DEV] Apply for add PECL Extensions
Everybody is good: I have applied to join the pecl an extension, and this is a used to export excel file extensions, can be used in smaller memory under rapid export excel files, and can be set to a cell in the excel format, and can also create formulas and data on the file creation stage screening, this is very useful to the company data report; Our company has been using it; The address of the project: https://github.com/viest/php-ext-excel-export In order to facilitate more people to use this extension quickly, apply to join PECL. I hope to get your reply.
[PECL-DEV] Apply for maintenance and add PECL Extensions
Hi: I have a new PHP extension and a maintenance extension that I want to add to PECL; New extensions: This extension solves the problem that PHP exports excel slowly and has a large memory footprint, which is very desirable; Url: https://github.com/viest/php-ext-excel-export Maintenance extensions: This is a PHP extension for fast string search and replace. It is 2 by StringUtils. PHP. It supports multiple search terms. We use It as a replacement for PHP 's STRTR, which is extremely missile in certain cases. The Chinese script conversion is one of those cases. This extension USES a Commentz - Walter style algorithm for multiple search terms, or a Boyer Moore - algorithm for single search terms. Url: https://github.com/viest/php-ext-ffs
[PECL-DEV] Apply for maintenance and add PECL Extensions
Hi: I have a new PHP extension and a maintenance extension that I want to add to PECL; New extensions: This extension solves the problem that PHP exports excel slowly and has a large memory footprint, which is very desirable; Url: https://github.com/viest/php-ext-excel-export Maintenance extensions: This is a PHP extension for fast string search and replace. It is 2 by StringUtils. PHP. It supports multiple search terms. We use It as a replacement for PHP 's STRTR, which is extremely missile in certain cases. The Chinese script conversion is one of those cases. This extension USES a Commentz - Walter style algorithm for multiple search terms, or a Boyer Moore - algorithm for single search terms. Url: https://github.com/viest/php-ext-ffs