Re: rawhide: Can't locate ExtUtils/CBuilder.pm

2018-03-01 Thread Petr Pisar
On Thu, Mar 01, 2018 at 10:33:25AM +, Paul Howarth wrote:
> That'll be because Server-Starter's Build.PL has
> 
>  "c_source => [qw()],"
> 
> And that's generated by Minilla, so all non-XS Minilla-based dists are
> likely to be affected.
> 
Indeed. I reported a bug against Minilla
 and sent a patch to
Module-Build .

I also applied the patch to perl-Module-Build-0.42.24-7.fc29. Since then
noarch Minilla-generated packages should build again.

-- Petr


signature.asc
Description: PGP signature
___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org


Re: rawhide: Can't locate ExtUtils/CBuilder.pm

2018-03-01 Thread Ralf Corsepius

On 03/01/2018 11:33 AM, Paul Howarth wrote:

On Thu, 1 Mar 2018 11:17:18 +0100
Petr Pisar  wrote:


On Thu, Mar 01, 2018 at 09:38:08AM +0100, Ralf Corsepius wrote:

Hi,

perl-Plack fails to build in rawhide with
this error[1]


Sorry, of course this was perl-Server-Starter, not perl-Plack.


...
+ /usr/bin/perl Build.PL --installdirs=vendor
Can't locate ExtUtils/CBuilder.pm in @INC (you may need to install
the ExtUtils::CBuilder module) (@INC contains:
/builddir/build/BUILD/Server-Starter-0.34/_build/lib /usr/local/lib64/perl5
/usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
/usr/share/perl5/vendor_perl/Module/Build/Base.pm line 5295.
...

f26, f27 and f28 build fine.

What is going on here? perl-Plack does not carry any direct
dependency on ExtUtils::CBuilder, so my guess would be a dependency
is missing somewhere else.
   


is happennning due to GCC removal from F29 build root.

If you have a package with XS modules and use Module::Build, you need
to build-require ExtUtils::CBuilder.

In case of Server-Starter, there seems to be a bug in
Module::Build::Base. It invokes auto_require() that for some reason
has $self->c_source set to [], and thus it decides it needs a
compiler and hence ExtUtils::CBuilder.

I think this condition in auto_require() should be corrected:

 $self->needs_compiler( keys %$xs_files || defined
$self->c_source );

and also the reason why $self->c_source is [] instead of undef should
be investigated.


That'll be because Server-Starter's Build.PL has

  "c_source => [qw()],"

And that's generated by Minilla, so all non-XS Minilla-based dists are
likely to be affected.
I am not familiar with Minilla, but you seem to have a point. At least, 
removing this line from Build.PL lets building perl-Server-Starter 
succeed for rawhide:

https://koji.fedoraproject.org/koji/taskinfo?taskID=25390138

Ralf
___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org


Re: rawhide: Can't locate ExtUtils/CBuilder.pm

2018-03-01 Thread Paul Howarth
On Thu, 1 Mar 2018 11:17:18 +0100
Petr Pisar  wrote:

> On Thu, Mar 01, 2018 at 09:38:08AM +0100, Ralf Corsepius wrote:
> > Hi,
> > 
> > perl-Plack fails to build in rawhide with
> > this error[1]
> > 
> > ...
> > + /usr/bin/perl Build.PL --installdirs=vendor
> > Can't locate ExtUtils/CBuilder.pm in @INC (you may need to install
> > the ExtUtils::CBuilder module) (@INC contains:
> > /builddir/build/BUILD/Server-Starter-0.34/_build/lib /usr/local/lib64/perl5
> > /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
> > /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
> > /usr/share/perl5/vendor_perl/Module/Build/Base.pm line 5295.
> > ...
> >
> > f26, f27 and f28 build fine.
> > 
> > What is going on here? perl-Plack does not carry any direct
> > dependency on ExtUtils::CBuilder, so my guess would be a dependency
> > is missing somewhere else.
> >   
> 
> is happennning due to GCC removal from F29 build root.
> 
> If you have a package with XS modules and use Module::Build, you need
> to build-require ExtUtils::CBuilder.
> 
> In case of Server-Starter, there seems to be a bug in
> Module::Build::Base. It invokes auto_require() that for some reason
> has $self->c_source set to [], and thus it decides it needs a
> compiler and hence ExtUtils::CBuilder.
> 
> I think this condition in auto_require() should be corrected:
> 
> $self->needs_compiler( keys %$xs_files || defined
> $self->c_source );
> 
> and also the reason why $self->c_source is [] instead of undef should
> be investigated.

That'll be because Server-Starter's Build.PL has

 "c_source => [qw()],"

And that's generated by Minilla, so all non-XS Minilla-based dists are
likely to be affected.

Paul.

___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org


Re: rawhide: Can't locate ExtUtils/CBuilder.pm

2018-03-01 Thread Petr Pisar
On Thu, Mar 01, 2018 at 09:38:08AM +0100, Ralf Corsepius wrote:
> Hi,
> 
> perl-Plack fails to build in rawhide with
> this error[1]
> 
> ...
> + /usr/bin/perl Build.PL --installdirs=vendor
> Can't locate ExtUtils/CBuilder.pm in @INC (you may need to install the
> ExtUtils::CBuilder module) (@INC contains:
> /builddir/build/BUILD/Server-Starter-0.34/_build/lib /usr/local/lib64/perl5
> /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
> /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
> /usr/share/perl5/vendor_perl/Module/Build/Base.pm line 5295.
> ...
>
> f26, f27 and f28 build fine.
> 
> What is going on here? perl-Plack does not carry any direct dependency on
> ExtUtils::CBuilder, so my guess would be a dependency is missing somewhere
> else.
> 

is happennning due to GCC removal from F29 build root.

If you have a package with XS modules and use Module::Build, you need to
build-require ExtUtils::CBuilder.

In case of Server-Starter, there seems to be a bug in Module::Build::Base. It
invokes auto_require() that for some reason has $self->c_source set to [], and
thus it decides it needs a compiler and hence ExtUtils::CBuilder.

I think this condition in auto_require() should be corrected:

$self->needs_compiler( keys %$xs_files || defined $self->c_source );

and also the reason why $self->c_source is [] instead of undef should be
investigated.

-- Petr


signature.asc
Description: PGP signature
___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org


rawhide: Can't locate ExtUtils/CBuilder.pm

2018-03-01 Thread Ralf Corsepius

Hi,

perl-Plack fails to build in rawhide with
this error[1]

...
+ /usr/bin/perl Build.PL --installdirs=vendor
Can't locate ExtUtils/CBuilder.pm in @INC (you may need to install the 
ExtUtils::CBuilder module) (@INC contains: 
/builddir/build/BUILD/Server-Starter-0.34/_build/lib 
/usr/local/lib64/perl5 /usr/local/share/perl5 
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl 
/usr/lib64/perl5 /usr/share/perl5 .) at 
/usr/share/perl5/vendor_perl/Module/Build/Base.pm line 5295.

...

f26, f27 and f28 build fine.

What is going on here? perl-Plack does not carry any direct dependency 
on ExtUtils::CBuilder, so my guess would be a dependency is missing 
somewhere else.



Ralf



[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=1052034
https://kojipkgs.fedoraproject.org//work/tasks/4038/25384038/build.log
___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org