Re: is_deeply() and code refs

2005-06-27 Thread Michael G Schwern
On Tue, Jun 28, 2005 at 12:21:48AM +0100, Fergal Daly wrote: > That's only 2 months old (according to CPAN) before that it would have > just failed or passed (failed in this case). Is it in bleadperl? I'd > be amazed if no one anywhere was using is_deeply with coderefs. It was undefined, accidenta

Re: is_deeply() and code refs

2005-06-27 Thread Michael G Schwern
On Mon, Jun 27, 2005 at 11:34:58PM +0100, Fergal Daly wrote: > Forgetting philosphical arguments about what's the right thing to do, > I think the strongest point against this is that there may be people > out there who expect the current behaviour The current behavior is to vomit all over the use

Re: is_deeply() and code refs

2005-06-27 Thread Michael G Schwern
On Mon, Jun 27, 2005 at 11:20:07AM +0100, Fergal Daly wrote: > > I'm perfectly happy to punt this problem over to B::Deparse and let them > > figure it out. As it stands B::Deparse is the best we can do with code > > refs. What's the alternative? > > I'd argue that currently the best you can do

Re: is_deeply() and code refs

2005-06-27 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, On Monday 27 June 2005 00:37, Michael G Schwern wrote: > On Sun, Jun 26, 2005 at 12:57:05PM +0100, Fergal Daly wrote: > > 1 the refs came from \&somefunc > > 2 the refs come from evaling strings of code > > 3 the refs are closures and therefore have some d

Re: Fwd: [CPAN Upload: P/PE/PETDANCE/Test-Harness-2.51_02.tar.gz: [EMAIL PROTECTED]

2005-06-27 Thread Andy Lester
On Mon, Jun 27, 2005 at 09:25:02AM +0100, Steve Hay ([EMAIL PROTECTED]) wrote: > Aww - I was beginning to like the timer output now the Abe graciously > fixed Test-Smoke to understand it. Set HARNESS_TIMER in your environment. xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com

Re: Fwd: [CPAN Upload: P/PE/PETDANCE/Test-Harness-2.51_02.tar.gz: [EMAIL PROTECTED]

2005-06-27 Thread Steve Hay
Andy Lester wrote: >I've just uploaded Test::Harness 2.51_02. It turns off the timer by >default, and adds a --timer switch to prove. Please try it out and see >if all is well because I'm going to make it 2.52 tomorrow. > Aww - I was beginning to like the timer output now the Abe graciously fi

Re: is_deeply() and code refs

2005-06-27 Thread Fergal Daly
On 6/27/05, Michael G Schwern <[EMAIL PROTECTED]> wrote: > On Mon, Jun 27, 2005 at 01:41:30AM +0100, Fergal Daly wrote: > > I'm not sure there is a right way to deparse closures (in general). > > For example if a variable is shared between 2 closures then it only > > makes sense to deparse both of

Re: Test::More diagnostic change... again

2005-06-27 Thread Michael G Schwern
On Mon, Jun 27, 2005 at 11:08:40AM +0200, David Landgren wrote: > I ranted a while back about s/got/received/ Yeah, that's a different issue. -- Michael G Schwern [EMAIL PROTECTED] http://www.pobox.com/~schwern Reality is that which, when you stop believing in it, doesn't go away.

Re: Fwd: [CPAN Upload: P/PE/PETDANCE/Test-Harness-2.51_02.tar.gz: [EMAIL PROTECTED]

2005-06-27 Thread Michael G Schwern
On Mon, Jun 27, 2005 at 09:25:02AM +0100, Steve Hay wrote: > Has the timer output confused other things besides Test-Smoke that you > know of? If not then perhaps leave the timer output on by default and > have a switch to turn it off? I believe some of Module::Build's tests got confused. Mayb

Re: Test::More diagnostic change... again

2005-06-27 Thread David Landgren
Michael G Schwern wrote: I just went to go patch in the code ref stuff to is_deeply() and found that I had unfinished changes to the diagnostic output. Remember, it was about including the description in the failure diagnostics. So instead of this: /Users/schwern/tmp/test...NOK 1

Re: is_deeply() and code refs

2005-06-27 Thread Fergal Daly
On 6/26/05, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > For 3, it looks like B::Deparse does't handle the data at all so even > > if the deparsed subs are identical they may behave totally > > differently. > > This will simply have to be a caveat. Fortunately, if B::Deparse ever gets > this