Re: skip vs todo vs $other_thing

2007-12-03 Thread Eric Wilhelm
# from Chris Dolan # on Sunday 02 December 2007 17:35: The problem with skipped tests is that they're easier for developers   to ignore than TODO tests. This is true, but if the test can correctly detect whether it should skip, that's probably a better way to go. An option for the *developer*

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread A. Pagaltzis
* Ovid [EMAIL PROTECTED] [2007-12-02 16:50]: Breaking the toolchain is bad. You can almost imagine Curtis murmuring those words even in his sleep… Regards, -- Aristotle Pagaltzis // http://plasmasturm.org/

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread Adrian Howard
On 3 Dec 2007, at 04:34, Michael G Schwern wrote: [snip] This doesn't mean that people don't use dies_ok() when they should use throws_ok(). Every tool is open to abuse. The solution is not to remove the tool, but figure out why it's being abused. Maybe the answer is as simple as

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread Adrian Howard
On 3 Dec 2007, at 10:26, A. Pagaltzis wrote: * Ovid [EMAIL PROTECTED] [2007-12-02 16:50]: Breaking the toolchain is bad. You can almost imagine Curtis murmuring those words even in his sleep… I have lost count of the number of times Andy/Ovid said this over the LPW weekend :-) Adrian

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean unexpectedly succeeded?

2007-12-03 Thread Eric Wilhelm
# from nadim khemir # on Monday 03 December 2007 15:11: There is not simple solution to this problem. There is, but the data needs to be more complicated than a boolean. Please. Calling it failure just gets everyone hung-up on semantics (and rightly so, because computers are awfully picky

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread nadim khemir
On Sunday 02 December 2007 18:48, Chris Dolan wrote: ... In this fashion, we use TODO tests to track when bugs in our dependent packages get fixed, and then when we can remove workarounds therefore. Chris This discussion is interresting and it's always educating to understand why other

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread Michael G Schwern
So I read two primary statements here. 1) Anything unexpected is suspicious. This includes unexpected success. 2) Anything unexpected should be reported back to the author. The first is controversial, and leads to the conclusion that TODO passes should fail. The second is not controversial,

Why not run a test without a plan?

2007-12-03 Thread Michael G Schwern
use Test::More; pass(); plan tests = 2; pass(); Why shouldn't this work? Currently you get a You tried to run a test without a plan error, but what is it really protecting the test author from? Historically, there was a clear technical reason. It used to be that

Re: Why not run a test without a plan?

2007-12-03 Thread David Golden
Michael G Schwern [EMAIL PROTECTED] wrote: It also makes it technically possible to allow the test to change it's plan mid-stream, though the consequences and interface for that do require some thought. With some sugar, that could actually be quite handy for something like test blocks. E.g.:

Re: Why not run a test without a plan?

2007-12-03 Thread Eric Wilhelm
# from David Golden # on Monday 03 December 2007 19:55: With some sugar, that could actually be quite handy for something like test blocks.  E.g.: {   plan add = 2;   ok( 1, wibble );   ok(1, wobble ); } or maybe make the block a sub block { subplan 2; ok(1, wibble); ok(1, wobble); };

Re: Why not run a test without a plan?

2007-12-03 Thread Michael G Schwern
David Golden wrote: Michael G Schwern [EMAIL PROTECTED] wrote: It also makes it technically possible to allow the test to change it's plan mid-stream, though the consequences and interface for that do require some thought. With some sugar, that could actually be quite handy for something

Re: Why not run a test without a plan?

2007-12-03 Thread Michael G Schwern
Eric Wilhelm wrote: # from David Golden # on Monday 03 December 2007 19:55: With some sugar, that could actually be quite handy for something like test blocks. E.g.: { plan add = 2; ok( 1, wibble ); ok(1, wobble ); } or maybe make the block a sub block { subplan 2;

Re: shouldn't UNEXPECTEDLY SUCCEEDED mean failure?

2007-12-03 Thread A. Pagaltzis
* Michael G Schwern [EMAIL PROTECTED] [2007-12-04 03:00]: So I read two primary statements here. 1) Anything unexpected is suspicious. This includes unexpected success. 2) Anything unexpected should be reported back to the author. The first is controversial, and leads to the