Re: use Test::More no_plan => $plan;

2008-09-08 Thread Aristotle Pagaltzis
* Ovid <[EMAIL PROTECTED]> [2008-09-09 08:35]: > This reminds me of all of the regexes people write to match > "proper" HTML: sometimes something simple is all you need :) As I wrote in response to Eric, I was actually trying to get as near a comprehenive list of things that need fixing as possibl

Re: use Test::More no_plan => $plan;

2008-09-08 Thread Aristotle Pagaltzis
* Eric Wilhelm <[EMAIL PROTECTED]> [2008-09-09 07:45]: > But, uh... what are you looking for exactly? I was hoping to make a nearly-comprehensive list of modules which make this mistake, like I did back when the “`use_ok` prior to setting a plan silently succeeds” was fixed; assuming the list wasn

Re: use Test::More no_plan => $plan;

2008-09-08 Thread Ovid
--- On Tue, 9/9/08, Aristotle Pagaltzis <[EMAIL PROTECTED]> wrote: > I tried to use Google CodeSearch, but for some reason all > my > regexes that I feed it match all the cases I want to > exclude. > > I tried variations on > > > use\s+Test::More.*no_plan\s*[')/]\s*[^;] > > but that matches

Re: use Test::More no_plan => $plan;

2008-09-08 Thread Michael G Schwern
Aristotle Pagaltzis wrote: > * Ovid <[EMAIL PROTECTED]> [2008-09-08 12:55]: >> In the developer release of Test::Simple, Test::Builder has >> been altered to die if you have any arguments after 'no_plan'. >> This means that some previously passing tests will fail. In >> fact, there are two test pro

Re: use Test::More no_plan => $plan;

2008-09-08 Thread Eric Wilhelm
# from Aristotle Pagaltzis # on Monday 08 September 2008 21:50: >    use\s+Test::More.*no_plan\s*[')/]\s*[^;] > >but that matches pretty much every `use Test::More` line with >`no_plan` on it ever written, regardless of what follows. > >If anyone can see something that I can’t, please tell me. /.

Re: use Test::More no_plan => $plan;

2008-09-08 Thread Aristotle Pagaltzis
* Ovid <[EMAIL PROTECTED]> [2008-09-08 12:55]: > In the developer release of Test::Simple, Test::Builder has > been altered to die if you have any arguments after 'no_plan'. > This means that some previously passing tests will fail. In > fact, there are two test programs in Moose 0.57 which have th

Re: Module::Build 0.2809 release coming, should we test it?

2008-09-08 Thread Eric Wilhelm
# from Andreas J. Koenig # on Monday 08 September 2008 15:16: >Since yesterday I have downloaded and analysed ~56000 testreports from >cpantesters and found ~135 distros that have been tested by both MB >0.2808 and 0.2808_03. There is only one result (Test-Group-0.12) that >looks bad but it turns

Re: Test::Most 'die' unless $smoking;

2008-09-08 Thread David Golden
On Mon, Sep 8, 2008 at 12:20 PM, Ovid <[EMAIL PROTECTED]> wrote: > What's the 'canonical' way to check to see if my tests are being run by a > smoker? I can't find anything in Test::Smoke about this (I might be blind). At least for CPAN Testers, the canonical way is $ENV{AUTOMATED_TESTING}. I d

Test::Most 'die' unless $smoking;

2008-09-08 Thread Ovid
If someone uses Test::Most and either has the environment DIE_ON_FAIL or BAIL_ON_FAIL set to true, or has 'die' or 'bail' in the import list, they'll likely be disappointed by failing test results sent back as they'll likely be incomplete. What's the 'canonical' way to check to see if my tests

Re: use Test::More no_plan => $plan;

2008-09-08 Thread David E. Wheeler
On Sep 8, 2008, at 03:49, Ovid wrote: In the developer release of Test::Simple, Test::Builder has been altered to die if you have any arguments after 'no_plan'. This means that some previously passing tests will fail. In fact, there are two test programs in Moose 0.57 which have this and

Re: reasonable reporting

2008-09-08 Thread David Cantrell
On Fri, Sep 05, 2008 at 11:56:02AM -0700, Eric Wilhelm wrote: > It should not be a "big red deal" if an author omits the declaration of > requiring perl 5.8.mumble+. At this point, it is a reasonable > assumption that code "should" run on 5.8.8 and 5.10.+, but an > unreasonable assumption that

Re: The relation between CPAN Testers and quality (or why CPAN Testers sucks if you don't need it)

2008-09-08 Thread David Cantrell
On Fri, Sep 05, 2008 at 11:36:10AM -0700, chromatic wrote: > It's a little bit like trying to have a discussion with someone who's upset > but won't tell you why, and you have to guess and hope you don't make things > worse before you get a useful answer. Thankfully, unlike in personal relation

Re: passing the baton onwards (was Re: The relation between CPAN Testers and quality (or why CPAN Testers sucks if you don't need it))

2008-09-08 Thread David Cantrell
On Fri, Sep 05, 2008 at 04:07:43PM +0100, Nicholas Clark wrote: > On Thu, Sep 04, 2008 at 02:19:26PM -0400, Greg Sabino Mullane wrote: > > Careful attention and responsiveness to CPAN testers and to rt.cpan.org is > > the best cure for this. > Alternatively, I could just not upload code to CPAN, an

Re: [ANNOUNCE] Test::More 0.81_01

2008-09-08 Thread Andreas J. Koenig
> On Sat, 06 Sep 2008 15:47:58 -0700, Michael G Schwern <[EMAIL PROTECTED]> > said: > http://test-more.googlecode.com/files/Test-Simple-0.81_01.tar.gz This version breaks the test for DAGOLDEN/Sub-Uplevel-0.1901.tar.gz t/05_honor_prior_override # Failed test 'use Sub::Uplevel;'

use Test::More no_plan => $plan;

2008-09-08 Thread Ovid
In the developer release of Test::Simple, Test::Builder has been altered to die if you have any arguments after 'no_plan'. This means that some previously passing tests will fail. In fact, there are two test programs in Moose 0.57 which have this and thus fail to pass: use Test::More no_pla