On Tue, Dec 22, 2009 at 09:03:42PM -0800, Joshua ben Jore wrote:
> On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
> > A little experimentation with a small disk image shows that close() will
> > error if there's no disk left. No need to check every print. And a close()
>
> You have t
Joshua ben Jore wrote:
On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
A little experimentation with a small disk image shows that close() will
error if there's no disk left. No need to check every print. And a close()
wrapper is trivial. It does mean there needs to be a close() fo
Marvin Humphrey wrote:
On Tue, Dec 22, 2009 at 09:03:42PM -0800, Joshua ben Jore wrote:
On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
A little experimentation with a small disk image shows that close() will
error if there's no disk left. No need to check every print. And a close(
On Tue, Dec 22, 2009 at 9:29 PM, Marvin Humphrey wrote:
> On Tue, Dec 22, 2009 at 09:03:42PM -0800, Joshua ben Jore wrote:
>> On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
>> > A little experimentation with a small disk image shows that close() will
>> > error if there's no disk left.
On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
> A little experimentation with a small disk image shows that close() will
> error if there's no disk left. No need to check every print. And a close()
> wrapper is trivial. It does mean there needs to be a close() for every
> open() whi
On Tue, Dec 22, 2009 at 4:29 PM, Michael G Schwern wrote:
> A little experimentation with a small disk image shows that close() will
> error if there's no disk left. No need to check every print. And a close()
You have to check every print. Most prints will just extend the buffer
but some print
On Tuesday 22 December 2009 at 14:23, Michael G wrote:
> Putting in error checking at some key locations is fine, but the prospect of
> adding `or die "Can't print $foo: $!"` to every print and close makes me
> want to claw my eyeballs out. Its unfortunate MakeMaker can't rely on
> autodie and
Joshua ben Jore wrote:
Fortunately there is one key location where MakeMaker does almost all its
writing to disk, ExtUtils::MakeMaker->flush. A simple patch to check that
would be lovely. If you want to write and insert a safe _print() wrapper
method and scatter that around that's fine, too.
On Tue, Dec 22, 2009 at 2:23 PM, Michael G Schwern wrote:
> Joshua ben Jore wrote:
>>
>> The just-released EU::MM 6.56 repeats this pattern frequently:
>>
>> open my($fh), '>', ...
>> or croak("Can't open ... for writing: $!");
>> ...
>> print $fh ...; # <<< no error checking
>>
Joshua ben Jore wrote:
The just-released EU::MM 6.56 repeats this pattern frequently:
open my($fh), '>', ...
or croak("Can't open ... for writing: $!");
...
print $fh ...; # <<< no error checking
close $fh ...; # <<< no error checking
Grepping for code:
egrep -rnH '
On Tue, Dec 22, 2009 at 07:03:49AM -0800, Joshua ben Jore wrote:
> Where is EU::MM's version control? I'd like to submit a patch adding a bunch
> of:
>
> or croak("Can't write '$fn': $!");
Good plan. (At least, in my opinion)
http://search.cpan.org/~mschwern/ExtUtils-MakeMaker-6.56/
says
On Mon, Dec 21, 2009 at 11:19 PM, Chris 'BinGOs' Williams
wrote:
> On Mon, Dec 21, 2009 at 04:15:22PM -0500, David Golden wrote:
>> You need to be asking on cpan-testers-discuss. Copying that list now.
>>
>> -- David
>>
>> On Mon, Dec 21, 2009 at 4:02 PM, Joshua ben Jore wrote:
>> > The CPAN smo
12 matches
Mail list logo
