Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-12 Thread Michael G Schwern
On Fri, Jan 11, 2002 at 05:03:46PM +0200, Jarkko Hietaniemi wrote: The name of the function and order of arguments are all up for discussion. Thanks, applied. About the name: I think it's an awful name... doesn't tell me at least at all what it's for (except maybe for doubling as

[PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Michael G Schwern
As long ago promised, here's a patch to pull the logic out of t/run/kill_perl.t and make it into a t/test.pl function. This means its no longer necessary to pile segfault checks into t/run/kill_perl.t. They can be placed in the appropriate test file like so: kill_perl(PROG, EXPECT, {},

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 04:26:27AM -0500, Michael G Schwern wrote: As long ago promised, here's a patch to pull the logic out of t/run/kill_perl.t and make it into a t/test.pl function. This means its no longer necessary to pile segfault checks into t/run/kill_perl.t. They can be placed in

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
PS There was also a bug in runperl(). All switches were being lost. Well, this change made several tests (like run/switches) to barf. So I backed out that hunk. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. --

Re: [PATCH t/run/kill_perl.t t/test.pl] Seperating kill_perl()

2002-01-11 Thread Jarkko Hietaniemi
On Fri, Jan 11, 2002 at 05:18:10PM +0200, Jarkko Hietaniemi wrote: PS There was also a bug in runperl(). All switches were being lost. Well, this change made several tests (like run/switches) to barf. So I backed out that hunk. Urk, so now three of kill_perl tests tests are failing...