RE: Encode should stay undefphobia

2002-05-01 Thread Paul Marquess
From: Nick Ing-Simmons [mailto:[EMAIL PROTECTED]] > Paul Marquess <[EMAIL PROTECTED]> writes: > >Good catch Nick. > > > >Instead of completely backing out the "defined $str or return" change, if > >you change it to > > > > unless (defined $str) { > > warnif('uninitialized', 'Use of Uniniti

[PATCH] Let Guess.pm handles uninitialized argument.

2002-05-01 Thread Autrijus Tang
This way is self-descriptory; it makes -w happier. :) /Autrijus/ --- /home/autrijus/perl/ext/Encode/lib/Encode/Guess.pm Fri Apr 26 11:40:12 2002 +++ /usr/local/lib/perl5/site_perl/5.7.3/i386-freebsd-thread-multi/Encode/Guess.pm + Wed May 1 19:34:06 2002 @@ -69,16 +69,20 @@ my $class

Re: [PATCH] Let Guess.pm handles uninitialized argument.

2002-05-01 Thread Dan Kogai
On Wednesday, May 1, 2002, at 09:19 , Autrijus Tang wrote: > This way is self-descriptory; it makes -w happier. :) > > /Autrijus/ XieXie. Applied. Dan the Encode Maintainer

Re: [Encode] 1.66 Released

2002-05-01 Thread Jarkko Hietaniemi
On Wed, May 01, 2002 at 02:58:13PM +0900, Dan Kogai wrote: > My fever is down at last when I released Encode-1.66, available as > follows; > > Whole: > http://www.dan.co.jp/~dankogai/Encode-1.66.tar.gz or CPAN > Diff against current: 264 lines > http://www.dan.co.jp/~dankogai/current

Encode, charnames and utf8heavy

2002-05-01 Thread Dan Kogai
On Wednesday, May 1, 2002, at 10:30 , Jarkko Hietaniemi wrote: > Thanks, upgraded. > > A bit of noise from ext/PerlIO/t/fallback.t: > > ./perl -Ilib ext/PerlIO/t/fallback.t > 1..8 > ok 1 - opened iso-8859-1 file > "\N{U+20ac}" does not map to iso-8859-1 at ext/PerlIO/t/fallback.t line > 21. > ok

Re: [Encode] 1.66 Released

2002-05-01 Thread Jarkko Hietaniemi
> Also, is it intentional that there is no \N{U+} syntax...? Uhhh. What I meant to ask that "was it intentional to use the \N{U+...} syntax, since currently there is no such syntax". I blame low caffeine levels. > That was planned at some point but as of there is no such thing: > > ../per

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Dan Kogai
On Wednesday, May 1, 2002, at 10:57 , Dan Kogai wrote: > Okay, I'll change the error message in the next one so it would say > > "\x{abcd}" does not map to iso-8859-1 at ext/PerlIO/t/fallback.t line > 21. > > Autrijus just sent me a patch so it won't take long. Done in my repository. Was > > p

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Jarkko Hietaniemi
> Speaking of charnames and utf8heavy, charname::viacode() is incredibly > slow (I tried to use it extensively to pretty-comment ucm files. I gave Yes, it is. It's hack. (Regexps and a small cache. It *really* sucked without that cache...) (And I just remembered that viacode() returning an

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Jarkko Hietaniemi
> Is there anything I should fix before Encode 1.67 ? (ahem, besides djgpp I think we are in pretty good shape. Unless NI-S finds something evil using Tk... > which I am still waiting for the news from Laszlo) > > Dan the Encode Maintainer -- $jhi++; # http://www.iki.fi/jhi/ # There

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Dan Kogai
On Wednesday, May 1, 2002, at 11:04 , Jarkko Hietaniemi wrote: > Yes, it is. It's hack. (Regexps and a small cache. It *really* sucked > without that cache...) Oh yes. I had to say I almost got a hangover :P > (And I just remembered that viacode() returning an undef when there's > no corresp

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Jarkko Hietaniemi
> > I don't think people should be much writing those definitions by hand. > > It would be easy to have a more user-friendly interface for that. > > At least we should document it is delimited by a single tab (Oh my > python!) or better yet, replace the \t to \s+ in the regex that parses Oh my

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Jarkko Hietaniemi
On Wed, May 01, 2002 at 11:19:14PM +0900, Dan Kogai wrote: > On Wednesday, May 1, 2002, at 11:04 , Jarkko Hietaniemi wrote: > > Yes, it is. It's hack. (Regexps and a small cache. It *really* sucked Ooops. So goes my memo...ry. It's not a small cache, it can grow to be really big... > > with

[Patch] ext/PerlIO/t/fallback.t gets haircut

2002-05-01 Thread Dan Kogai
jhi, > A bit of noise from ext/PerlIO/t/fallback.t: > > ./perl -Ilib ext/PerlIO/t/fallback.t > 1..8 > ok 1 - opened iso-8859-1 file > "\N{U+20ac}" does not map to iso-8859-1 at ext/PerlIO/t/fallback.t line > 21. > ok 2 - perlqq escapes > ok 3 - opened iso-8859-1 file > ok 4 - HTML escapes > ok 5

Re: Encode, charnames and utf8heavy

2002-05-01 Thread Dan Kogai
On Wednesday, May 1, 2002, at 11:23 , Jarkko Hietaniemi wrote: > perlunicode.pod and "User-defined Character Properties" already > documents it. I guess accepting \s+ is okay... but as I said, > people shouldn't be doing that by hand (much). And here is the patch that fixes this. [ \t]+ is pick

Re: [Patch] ext/PerlIO/t/fallback.t gets haircut

2002-05-01 Thread Jarkko Hietaniemi
> I know NI-XS will fix and enhance this test soon but for the time being > you can use this for peace of mind. For the time being, applied. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. -- Jack Cohen

Re: Change 16302: Provide the \N{U+HHHH} syntax before we forget.

2002-05-01 Thread Philip Newton
On Wed, 1 May 2002 07:00:05 -0700, [EMAIL PROTECTED] (Jarkko Hietaniemi) wrote: > Change 16302 by jhi@alpha on 2002/05/01 12:54:24 > > Provide the \N{U+} syntax before we forget. Do we also want to support U-HH? I seem to recall from somewhere that U+ went to U+ and that c

Re: Change 16308: Encode tweak from Dan Kogai.

2002-05-01 Thread Philip Newton
On Wed, 1 May 2002 09:45:05 -0700, [EMAIL PROTECTED] (Jarkko Hietaniemi) wrote: > if (check & ENCODE_DIE_ON_ERR) { > Perl_croak( > - aTHX_ "\"\\N{U+%" UVxf "}\" does not map to %s", > + aTHX_ "\"\\x{%04" UVxf "}\" does not

Re: Change 16308: Encode tweak from Dan Kogai.

2002-05-01 Thread Dan Kogai
On Thursday, May 2, 2002, at 03:03 , Philip Newton wrote: > On Wed, 1 May 2002 09:45:05 -0700, [EMAIL PROTECTED] (Jarkko Hietaniemi) wrote: > >> if (check & ENCODE_DIE_ON_ERR) { >> Perl_croak( >> -aTHX_ "\"\\N{U+%" UVxf "}\" does not map to %s", >>