[perl #126955] [BUG] more .perl string quoting problems

On Mon, 21 Dec 2015 11:09:40 -0800, zef...@fysh.org wrote: > Elizabeth Mattijsen via RT wrote: > >All of that goodness now in 591783d116a56d4b2c54f . > > You left a stray line in IO::Path.perl, which calls PERLIFY-STR in > sink context. > > >Indeed! Now, if this had been in a Pull Request, I

Re: [perl #126955] [BUG] more .perl string quoting problems

Elizabeth Mattijsen via RT wrote: >All of that goodness now in 591783d116a56d4b2c54f . You left a stray line in IO::Path.perl, which calls PERLIFY-STR in sink context. >Indeed! Now, if this had been in a Pull Request, I could have just >clicked on Merge, which would have been less work for me

Re: [perl #126955] [BUG] more .perl string quoting problems

> On 21 Dec 2015, at 18:06, Zefram wrote: > Elizabeth Mattijsen via RT wrote: >> There is a subtle difference between Str.perl and >> Rakudo::Internals.PERLIFY-STR: The former puts double quotes around, the >> latter doesn't. > > Yes, hence the doubling when you call the

Re: [perl #126955] [BUG] more .perl string quoting problems

> On 20 Dec 2015, at 23:18, Zefram wrote: > > Elizabeth Mattijsen via RT wrote: >> Fixed with ae8d9809c432f071643384 > > It's good that you're now factoring out the escaping code. This means > that these methods (including for IO::Path) are now correct. But the > factoring is

Re: [perl #126955] [BUG] more .perl string quoting problems

> On 21 Dec 2015, at 16:58, Zefram wrote: > > Elizabeth Mattijsen via RT wrote: >> Good point. Followed your suggestion in 8ddfff5533d4d77dbd7da65 . > > You're now duplicating the delimiters for those two. For IO::Path you've > removed the superfluous pipe escaping but

Re: [perl #126955] [BUG] more .perl string quoting problems

Elizabeth Mattijsen via RT wrote: >Good point. Followed your suggestion in 8ddfff5533d4d77dbd7da65 . You're now duplicating the delimiters for those two. For IO::Path you've removed the superfluous pipe escaping but retain the poor factoring. -zefram

Re: [perl #126955] [BUG] more .perl string quoting problems

Elizabeth Mattijsen via RT wrote: >There is a subtle difference between Str.perl and >Rakudo::Internals.PERLIFY-STR: The former puts double quotes around, the >latter doesn't. Yes, hence the doubling when you call the former and also wrap the result in quotes. >I'm afraid we'll have to settle

Re: [perl #126955] [BUG] more .perl string quoting problems

Elizabeth Mattijsen via RT wrote: >Fixed with ae8d9809c432f071643384 It's good that you're now factoring out the escaping code. This means that these methods (including for IO::Path) are now correct. But the factoring is still flawed, in that you've inlined what remains of the body of Str.perl

Re: [perl #126955] [BUG] more .perl string quoting problems

> On 18 Dec 2015, at 08:21, Zefram (via RT) > wrote: > > # New Ticket Created by Zefram > # Please include the string: [perl #126955] > # in the subject line of all future correspondence about this issue. > # https://rt.perl.org/Ticket/Display.html?id=126955 >

[perl #126955] [BUG] more .perl string quoting problems

# New Ticket Created by Zefram # Please include the string: [perl #126955] # in the subject line of all future correspondence about this issue. # https://rt.perl.org/Ticket/Display.html?id=126955 > The roles CompUnit::Repository::Locally and IO::Local each have a bug similar to [perl