Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery via RT
On Mon, Jul 17, 2017 at 2:49 AM, Joachim Durchholz via RT < perl6-bugs-follo...@perl.org> wrote: > 1) It cannot handle non-runtime code that one might want to filter. > 2) It hardcodes the definition of what's interesting. > 3) You cannot have runtime code that you *want* to be included in the >

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery
On Mon, Jul 17, 2017 at 2:49 AM, Joachim Durchholz via RT < perl6-bugs-follo...@perl.org> wrote: > 1) It cannot handle non-runtime code that one might want to filter. > 2) It hardcodes the definition of what's interesting. > 3) You cannot have runtime code that you *want* to be included in the >

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz via RT
> See this: > https://github.com/rakudo/rakudo/blob/6c76ed0abe352316eb58283fa6ce6b8150fc6830/src/core/Backtrace.pm#L144 > > It goes like this: > > # now *that's* an evil hack > next if $file.ends-with('BOOTSTRAP.nqp') > || $file.ends-with('QRegex.nqp')

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz via RT
Am 17.07.2017 um 09:32 schrieb Brandon Allbery: > On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz > wrote: > > I think the whole concept of defining what's "interesting" in > a backtrace by looking at the file name is pretty

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz via RT
Am 17.07.2017 um 11:34 schrieb jn...@jnthn.net via RT: > The code in question is implemented in NQP, which doesn't have a generalized > traits mechanism. Ahh, may bad, this being NQP files flew right by me and I didn't see it. I retract the traits idea - adding that just for this issue might be

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Zoffix Znet via RT
On Mon, 17 Jul 2017 09:25:26 -0700, alex.jakime...@gmail.com wrote: > I think the purpose of the ticket was stated clearly in the first message. > > Feel free to change the comment in the source code to “This is a hack but > there's no point to improve it” and close the ticket. > > To me it felt

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Zoffix Znet via RT
On Mon, 17 Jul 2017 09:25:26 -0700, alex.jakime...@gmail.com wrote: > I think the purpose of the ticket was stated clearly in the first message. > > Feel free to change the comment in the source code to “This is a hack but > there's no point to improve it” and close the ticket. > > To me it felt

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Aleks-Daniel Jakimenko-Aleksejev via RT
I think the purpose of the ticket was stated clearly in the first message. Feel free to change the comment in the source code to “This is a hack but there's no point to improve it” and close the ticket. To me it felt like the intention was to improve this part later, but no TODO comment was

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Zoffix Znet via RT
On Mon, 17 Jul 2017 08:33:12 -0700, alex.jakime...@gmail.com wrote: > I don't think this ticket needs so much discussion… It's basically > about > implementing the damn thing properly (and coming up with a way to do > it along > the way). What problems does the current implementation have? What

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Zoffix Znet via RT
On Mon, 17 Jul 2017 08:33:12 -0700, alex.jakime...@gmail.com wrote: > I don't think this ticket needs so much discussion… It's basically > about > implementing the damn thing properly (and coming up with a way to do > it along > the way). What problems does the current implementation have? What

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Aleks-Daniel Jakimenko-Aleksejev via RT
I don't think this ticket needs so much discussion… It's basically about implementing the damn thing properly (and coming up with a way to do it along the way). On 2017-07-16 21:17:22, alex.jakime...@gmail.com wrote: > See this: >

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz
Am 17.07.2017 um 11:34 schrieb jn...@jnthn.net via RT: The code in question is implemented in NQP, which doesn't have a generalized traits mechanism. Ahh, may bad, this being NQP files flew right by me and I didn't see it. I retract the traits idea - adding that just for this issue might be

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery via RT
On Mon, Jul 17, 2017 at 4:20 AM, Joachim Durchholz wrote: > Am 17.07.2017 um 09:32 schrieb Brandon Allbery: > > On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz > > wrote: > > > > I think the whole concept of defining

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery
On Mon, Jul 17, 2017 at 4:20 AM, Joachim Durchholz wrote: > Am 17.07.2017 um 09:32 schrieb Brandon Allbery: > > On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz > > wrote: > > > > I think the whole concept of defining

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread jn...@jnthn.net via RT
On Sun, 16 Jul 2017 23:49:55 -0700, j...@durchholz.org wrote: > 6) If somebody writes his own module in a different location but with > a > matching name (e.g. they might be writing a wrapper, or an emulator), > then these files will be filtered as well. > The filenames end in .nqp. A Perl 6

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread jn...@jnthn.net via RT
On Sun, 16 Jul 2017 23:49:55 -0700, j...@durchholz.org wrote: > 6) If somebody writes his own module in a different location but with > a > matching name (e.g. they might be writing a wrapper, or an emulator), > then these files will be filtered as well. > The filenames end in .nqp. A Perl 6

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz
Am 17.07.2017 um 09:32 schrieb Brandon Allbery: > On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz > wrote: > > I think the whole concept of defining what's "interesting" in > a backtrace by looking at the file name is pretty

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery
On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz wrote: > I think the whole concept of defining what's "interesting" in a backtrace >> by looking at the file name is pretty evil: > > So does Perl 6, actually; there's some discussion in the spec, and possibly in the docs for

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Brandon Allbery via RT
On Mon, Jul 17, 2017 at 2:40 AM, Joachim Durchholz wrote: > I think the whole concept of defining what's "interesting" in a backtrace >> by looking at the file name is pretty evil: > > So does Perl 6, actually; there's some discussion in the spec, and possibly in the docs for

Re: [perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-17 Thread Joachim Durchholz
See this: https://github.com/rakudo/rakudo/blob/6c76ed0abe352316eb58283fa6ce6b8150fc6830/src/core/Backtrace.pm#L144 It goes like this: # now *that's* an evil hack next if $file.ends-with('BOOTSTRAP.nqp') || $file.ends-with('QRegex.nqp')

[perl #131757] Untodoed evil hack in Backtrace.pm

2017-07-16 Thread via RT
# New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev # Please include the string: [perl #131757] # in the subject line of all future correspondence about this issue. # https://rt.perl.org/Ticket/Display.html?id=131757 > See this: