Re: [perl #53356] Misc. build warnings

2008-04-28 Thread chromatic
On Monday 28 April 2008 10:40:02 [EMAIL PROTECTED] wrote: Just a query, wouldn't: Index: src/key.c === --- src/key.c (revision 27216) +++ src/key.c (working copy) @@ -329,12 +329,14 @@ } case

Re: [perl #53356] Misc. build warnings

2008-04-28 Thread Andy_Bach
On 26 April 2008 chromatic wrote: src/key.c:306: warning: switch missing default case Fixed in 27195. Just a query, wouldn't: Index: src/key.c === --- src/key.c (revision 27216) +++ src/key.c (working copy) @@ -329,12 +329,14

Re: [perl #53356] Misc. build warnings

2008-04-28 Thread Andy_Bach
chromatic wrote What if the PMC passed in isn't a Key PMC, but has an integer value? Ah (sound of scales falling from my eyes) - the reason for the test/switch: if (VTABLE_isa(interp, key, CONST_STRING(interp, Key))) { switch (PObj_get_FLAGS(key) KEY_type_FLAGS) { ... is to handle

Re: [perl #53356] Misc. build warnings

2008-04-26 Thread chromatic
On Friday 25 April 2008 10:50:24 Will Coleda wrote: Miscellaneous build warnings that need to be cleaned up. src/key.c:306: warning: switch missing default case Fixed in 27195. compilers/imcc/imclexer.c:4288: warning: switch missing default case compilers/imcc/imclexer.c:4447: warning:

Re: [perl #53356] Misc. build warnings

2008-04-26 Thread Klaas-Jan Stol
On Sat, Apr 26, 2008 at 7:39 PM, chromatic [EMAIL PROTECTED] wrote: On Friday 25 April 2008 10:50:24 Will Coleda wrote: Miscellaneous build warnings that need to be cleaned up. src/key.c:306: warning: switch missing default case Fixed in 27195. compilers/imcc/imclexer.c:4288: