Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Lisandro Dalcin
Barry, I've pushed a quick fix (missing PETSC_EXTERN in TaoMonitor()) in your branch. The following prototypes in petsctao.h are also missing PETSC_EXTERN, and I think they should be more properly namespaced. PetscErrorCode VecGetSubVec(Vec, IS, PetscInt, PetscReal, Vec*); PetscErrorCode

Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Jed Brown
Lisandro Dalcin dalc...@gmail.com writes: Barry, I've pushed a quick fix (missing PETSC_EXTERN in TaoMonitor()) in your branch. The following prototypes in petsctao.h are also missing PETSC_EXTERN, and I think they should be more properly namespaced. PetscErrorCode VecGetSubVec(Vec, IS,

Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Munson, Todd S.
I am not sure that VecGetSubVec and MatGetSubMat are needed. These should only be used for the active-set methods (I hope) and there should be native PETSc equivalents used by the PETSc active-set variational inequality solvers, for example. Todd. On Feb 18, 2014, at 9:22 AM, Jed Brown

Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Jason Sarich
These functions are for eliminating the variables corresponding to active sets when performing matrix, vector operations. I don't think they were meant to be in the public interface, only for utilities in active set algorithms. Jason On Tue, Feb 18, 2014 at 9:22 AM, Jed Brown j...@jedbrown.org

Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Jed Brown
Jason Sarich jason.sar...@gmail.com writes: These functions are for eliminating the variables corresponding to active sets when performing matrix, vector operations. I don't think they were meant to be in the public interface, only for utilities in active set algorithms. Okay, can you either

Re: [petsc-dev] TaoTerminationReason - TaoConvergedReason

2014-02-18 Thread Jason Sarich
This has been updated now in barry/tao-fixes-for-petsc4py Jason On Tue, Feb 18, 2014 at 11:32 AM, Smith, Barry F. bsm...@anl.gov wrote: On Feb 18, 2014, at 10:12 AM, Jason Sarich jason.sar...@gmail.com wrote: Yes, I'll rename them under Tao and make them PETSC_INTERNAL. Thanks, move

Re: [petsc-dev] git help needed

2014-02-18 Thread Svetlana Tkachenko
You can `git reset --soft previous item in git log`, I think, switch to another branch, and commit twice (once to master and once to that branch). - Original message - From: Barry Smith bsm...@mcs.anl.gov To: petsc-dev petsc-dev@mcs.anl.gov, Karl Rupp r...@mcs.anl.gov Subject: