Re: [petsc-dev] FAS indentation

Matt, Is this patch Alp sent - a fix for one of the outstanding issues? If so - which branch should it go into? [or will you check and add it in?] Thanks, Satish On Wed, 4 Apr 2018, Dener, Alp wrote: > > Hi Matt, > > Some notes about this issue: > > 1. > > Correction to my previous

Re: [petsc-dev] FAS indentation

On Wed, 4 Apr 2018, Dener, Alp wrote: > (I didn’t wanna push directly to next without approval). Just a note: we would never commit/push directly to next. All fixes should go to the corresponding feature branch - this way they will get to master when ready [and next is never directly

Re: [petsc-dev] FAS indentation

Hi Matt, Some notes about this issue: 1. Correction to my previous email: the XYZMonitor() routines were not touched/modified in this feature branch. I misspoke about that. We modified the XYZView() only, and indeed these are the ones that appear to have some different indentations in the

Re: [petsc-dev] FAS indentation

Sounds good. I already found one case of mishandled tabs just looking at the SNES default monitor, and I’ll make sure the rest don’t have the same bug. — Alp Dener On April 3, 2018 at 6:24:42 PM, Matthew Knepley (knep...@gmail.com) wrote: On Tue, Apr 3, 2018 at 7:16

Re: [petsc-dev] FAS indentation

On Tue, Apr 3, 2018 at 7:16 PM, Dener, Alp wrote: > Sure thing! > > Matt, just to give you a bit of detail, the Monitor() calls to ASCII > viewers were changed to respect the tab levels for the parent objects > instead of manually pushing and popping tabs on the printouts. The

Re: [petsc-dev] FAS indentation

Sure thing! Matt, just to give you a bit of detail, the Monitor() calls to ASCII viewers were changed to respect the tab levels for the parent objects instead of manually pushing and popping tabs on the printouts. The code also tries to preserve the existing tab levels of the viewer though —

Re: [petsc-dev] FAS indentation

Alp, Can you please take a look at this? Thanks Barry > On Apr 3, 2018, at 4:46 PM, Matthew Knepley wrote: > > The recent indentation fix (I think) has broken the FAS solver indentation. > >Matt > > -- > What most experimenters take for granted

[petsc-dev] FAS indentation

The recent indentation fix (I think) has broken the FAS solver indentation. Matt -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener