[pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

Hi, If we close the Dashboard tab even then the requests don't stop. This is the regression of web-packing of browser.js file. Please find the attached patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/

Re: [pgAdmin4]: Webpacking of static JS/CSS

Ok. I will send rebased patch. On Thu, Jul 27, 2017 at 10:32 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > > On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Surinder, >> >> 'delete_template_files.patch' is applied any more. >> Please

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Surinder, > > 'delete_template_files.patch' is applied any more. > Please send the rebased patches. > > I have also noticed in the 'move_js_files_to_static_directory.patch', > couple of modules have two def

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi Surinder, 'delete_template_files.patch' is applied any more. Please send the rebased patches. I have also noticed in the 'move_js_files_to_static_directory.patch', couple of modules have two definitions for 'module_use_template_javascript' method. -- Thanks & Regards, Ashesh Vashi Enterpri

[pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

Hi, Please find the attached patch to fix the RM #2603: Import/Export File issues. Fixed Issues: 1. Couldn't click on the File Control once gets an error 2. The encoding is not in alphabetical order Thanks, Khsuhboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/dat

Jenkins build is back to normal : pgadmin4-master-python36 #263

See

Jenkins build is back to normal : pgadmin4-master-python35 #266

See

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Awesome - thanks, committed. On Wed, Jul 26, 2017 at 1:56 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jul 26, 2017 at 5:41 PM, Dave Page wrote: > >> >> >> On Wed, Jul 2

pgAdmin 4 commit: Store the file dialog view on toggle.

Store the file dialog view on toggle. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=831c614a60725fb5cc116ee06bdea7bb477d1f2c Author: Harshal Dhumal Modified Files -- web/pgadmin/misc/file_manager/__init__.py | 1

Jenkins build is back to normal : pgadmin4-master-python27 #267

See

Jenkins build is back to normal : pgadmin4-master-python33 #267

See

Jenkins build is back to normal : pgadmin4-master-python34 #258

See

Build failed in Jenkins: pgadmin4-master-python36 #262

See Changes: [Dave Page] Fixup tests following label changes. -- [...truncated 335.79 KB...] SynonymPutTestCase (Fetch synonym Node URL)

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi Dave, EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 26, 2017 at 5:41 PM, Dave Page wrote: > > > On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Jul 24, 2017 at 4:23 PM, Dave Pa

Jenkins build is back to normal : pgadmin4-master-python26 #388

See

Build failed in Jenkins: pgadmin4-master-python33 #266

See Changes: [Dave Page] Default the file browser view to list, and make it configurable. Fixes -- [...truncated 354.28 KB...] PhantomJS 2.1.1 (Linux 0.0

pgAdmin 4 commit: Fixup tests following label changes.

Fixup tests following label changes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af26d983e5e20c64f0f73d22ebd998f54dff1e8a Author: Murtuza Zabuawala Modified Files -- .../sqleditor/keyboard_shortcuts_spec.js | 37

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Thanks, applied. On Wed, Jul 26, 2017 at 1:40 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find a patch to fix the JS tests. > > FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used > 'inlineComment' because key shortcuts are differ

Build failed in Jenkins: pgadmin4-master-python34 #257

See Changes: [Dave Page] Default the file browser view to list, and make it configurable. Fixes -- [...truncated 354.25 KB...] PhantomJS 2.1.1 (Linux 0.0

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Hi Dave, Please find a patch to fix the JS tests. FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used ' inlineComment' because key shortcuts are different based on platform. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterpri

Build failed in Jenkins: pgadmin4-master-python26 #387

See Changes: [Dave Page] Handle control visibility properly in javascript strict mode. [Dave Page] Default the file browser view to list, and make it configurable. Fixes --

Build failed in Jenkins: pgadmin4-master-python27 #266

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform [Dave Page] Handle control visibility properly in javascript strict mode. [Dave Page] Default the file

Build failed in Jenkins: pgadmin4-master-python35 #265

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform [Dave Page] Handle control visibility properly in javascript strict mode. [Dave Page] Default the file

Build failed in Jenkins: pgadmin4-master-python36 #261

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform [Dave Page] Handle control visibility properly in javascript strict mode. [Dave Page] Default the file

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Mon, Jul 24, 2017 at 4:23 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find attache

Build failed in Jenkins: pgadmin4-master-python33 #265

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform [Dave Page] Handle control visibility properly in javascript strict mode.

pgAdmin 4 commit: Default the file browser view to list, and make it co

Default the file browser view to list, and make it configurable. Fixes #2579 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97cd74a3737aed12bd5d73905018752923b4bc98 Author: Harshal Dhumal Modified Files -- web/pgadmin/misc/file_m

Build failed in Jenkins: pgadmin4-master-python34 #256

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform [Dave Page] Handle control visibility properly in javascript strict mode.

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Looking into it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins wrote: > See 386/display/redirect?page=changes> > > Changes:

Build failed in Jenkins: pgadmin4-master-python26 #386

See Changes: [Dave Page] Update keyboard shortcuts per discussion. Also, make the labels platform -- [...truncated 357.97 KB...] PhantomJS 2.1.1 (Linux 0

Re: [pgAdmin4][Patch]: Backform control visibility fix

Thanks, applied. On Tue, Jul 25, 2017 at 1:18 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to handle the control visibility even in > the javascript strict mode. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Tw

pgAdmin 4 commit: Handle control visibility properly in javascript stri

Handle control visibility properly in javascript strict mode. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1e7254fbd361f4e73ecfd9b0fa2fa69ad9820c5 Author: Khushboo Vashi Modified Files -- .../servers/roles/templates/role/js/ro

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, applied. I also extended the code you added to ensure the labels for the Find/Replace options are now platform-correct. On Wed, Jul 26, 2017 at 10:29 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch for new shortcut keys, I have t

pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also, make

Update keyboard shortcuts per discussion. Also, make the labels platform sensitive. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fa9648a21c980c6ecdd5d87da64783b19dfab73 Author: Murtuza Zabuawala Modified Files -- docs/en_US/k

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

Hi, On Mon, Jul 24, 2017 at 4:23 PM, Dave Page wrote: > Hi > > On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to set default layout of file listing as a >> list in file manager. >> Also replaced alertify with

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 21, 2017 at 9:38