Re: Enums printout - possible bug

2017-12-14 Thread Harshal Dhumal
+pgadmin-hackers -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Dec 14, 2017 at 5:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for various data type te

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-14 Thread Murtuza Zabuawala
Yes Harshal, you are right but due to RM#2922 changes now runtime is rendering the Login page. @Dave, Please find updated patch, which will also fix the issue of user login on each request in runtime. RM#2952 RM#2922 -- ​ ​ Murtuza On Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal < harshal.dhu...

[pgAdmin4][Patch]: Allow user to select error text

2017-12-14 Thread Murtuza Zabuawala
Hi, PFA minor patch which will allow user to select the text from error message. RM#2954 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/scss/_alert.scss b/web/pgadmin/static/scss/_alert.scss index 441c40f.

[pgAdmin4][Patch]: File manager - Allow user to load the file by double clicking on it

2017-12-14 Thread Murtuza Zabuawala
Hi, PFA patch which will allow user to load the file via file manager by double clicking on the file just like native file manager. RM#2810 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/file_manager/static/j

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Murtuza Zabuawala
On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Yes, we can commit this code, It will add basic button navigation via Tab >> key. >> >> I think we should hold till our

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-14 Thread Harshal Dhumal
Hi Murtuza, Moving login related code from under decorator @app.before_first_request to @app.before_request will cause runtime user to login on each request. I think we need to find some better way. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Khushboo Vashi
On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, we can commit this code, It will add basic button navigation via Tab > key. > > I think we should hold till our final design gets ready. > I will keep the RM open until we add Tab navigation :)

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Murtuza Zabuawala
Yes, we can commit this code, It will add basic button navigation via Tab key. I will keep the RM open until we add Tab navigation :) On Wed, Dec 13, 2017 at 9:33 PM, Dave Page wrote: > Hi, > > On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patc

[pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where we were rendering Security URL's like change password, reset password in HTML templates while running in Desktop mode, we only register these security blueprints in Server mode hence it was failing with BuildError. RM#2952 Also reverted RM#2922 because it not