[pgAdmin4][RM#3179] Error message displayed if click on sql pane of Trigger function

2018-04-11 Thread Aditya Toshniwal
Hi Team, PFA patch for RM#3179 where error message was displayed when user selects the SQL tab for a trigger function. Fixed the SQL query used to fetch the definition. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions Pune | Mob - 8055837949 diff --git

Re: pgAdmin 3.0 builds

2018-04-11 Thread Khushboo Vashi
On Wed, Apr 11, 2018 at 7:30 PM, Dave Page wrote: > New builds are at https://developer.pgadmin.org/~dpage/v3.0-2/. > > These fix the Windows crash that Fahar found (which happened if the user > had a space in their usename), and fix password encryption/decryption under > Python 3. > > I have tes

Re: pgAdmin 3.0 builds

2018-04-11 Thread Christoph Berg
Re: Dave Page 2018-04-11 > New builds are at https://developer.pgadmin.org/~dpage/v3.0-2/. > > These fix the Windows crash that Fahar found (which happened if the user > had a space in their usename), and fix password encryption/decryption under > Python 3. > > Apologies for the inconvenience a

Re: Bug #3083 fix

2018-04-11 Thread Dave Page
Hi On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, > Do you still have issues in your environment? > I just tested on my MBP, and got the following failure: == ERROR: r

Re: Bug #3083 fix

2018-04-11 Thread Joao De Almeida Pereira
Hi Dave, Do you still have issues in your environment? Thanks Joao On Wed, Apr 11, 2018 at 5:56 AM Dave Page wrote: > Joao, are you looking at this? > > On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software

Re: [pgAdmin4] Changes required to support PyCrypto

2018-04-11 Thread Dave Page
Yeah, good call - pycryptodome was still installed. Committed, sorry for the noise. On Tue, Apr 10, 2018 at 6:39 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​This is the exact code we had before pycrptodom changes, Is it fresh > virtual environment? > I suspect ​some con

Re: pgAdmin 3.0 builds

2018-04-11 Thread Dave Page
New builds are at https://developer.pgadmin.org/~dpage/v3.0-2/. These fix the Windows crash that Fahar found (which happened if the user had a space in their usename), and fix password encryption/decryption under Python 3. Apologies for the inconvenience again. I still hope to release tomorrow, b

pgAdmin 4 commit: Fix password encryption/decryption on Python 3.

2018-04-11 Thread Dave Page
Fix password encryption/decryption on Python 3. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79edf40141b5886634ef71fb5bf14ec076e2adaf Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/crypto.py | 9 - 1 file

Re: pgAdmin 3.0 builds

2018-04-11 Thread Dave Page
All, As you've probably seen, there were show-stopper issues with these builds unfortunately. I'm just testing the last fix, and will create new builds ASAP and follow up here. Apologies for the inconvenience. On Tue, Apr 10, 2018 at 11:51 AM, Dave Page wrote: > The pgAdmin 3.0 builds are at h

Re: [pgAdmin4][patch]: RM #3227 pgadmin4 crashed on Windows If admin user name contains spaces

2018-04-11 Thread Dave Page
Thanks, applied. On Wed, Apr 11, 2018 at 1:20 PM, Akshay Joshi wrote: > Hi Hackers, > > Please find the attached patch to fix RM #3227 pgadmin4 crashed on > Windows If admin user name contains spaces. > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile:

pgAdmin 4 commit: Avoid a crash in the runtime if there are spaces in t

2018-04-11 Thread Dave Page
Avoid a crash in the runtime if there are spaces in the users username. Fixes #3227 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8232f26882bf049b541627a0971e32f04f4b83ae Author: Akshay Joshi Modified Files -- runtime/pgAdmin4.

[pgAdmin4][patch]: RM #3227 pgadmin4 crashed on Windows If admin user name contains spaces

2018-04-11 Thread Akshay Joshi
Hi Hackers, Please find the attached patch to fix RM #3227 pgadmin4 crashed on Windows If admin user name contains spaces. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3227.patch Description: Binary data

Re: Bug #3083 fix

2018-04-11 Thread Dave Page
Joao, are you looking at this? On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Apr 3, 2018 at 6:10 PM,

Re: pgAdmin 3.0 builds

2018-04-11 Thread Dave Page
On Wed, Apr 11, 2018 at 10:38 AM, Devrim Gündüz wrote: > > Hi, > > On Wed, 2018-04-11 at 09:17 +0100, Dave Page wrote: > > Nice work Fahar - I can reproduce the problem now! > > Will we still release tomorrow? I also need some time to find a solution > for > the setuptools issue on RHEL 7 and RHE

Re: pgAdmin 3.0 builds

2018-04-11 Thread Devrim Gündüz
Hi, On Wed, 2018-04-11 at 09:17 +0100, Dave Page wrote: > Nice work Fahar - I can reproduce the problem now! Will we still release tomorrow? I also need some time to find a solution for the setuptools issue on RHEL 7 and RHEL 6. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.

pgAdmin 4 commit: Add a couple of files for git to ignore.

2018-04-11 Thread Dave Page
Add a couple of files for git to ignore. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e467ffcfe4be7175bff423a04b0072588271f502 Author: Rahul Soshte Modified Files -- .gitignore | 1 + runtime/.gitignore | 1 + 2 files cha

Re: Ignoring web/yarn-error.log and runtime/moc_LogWindow.cpp

2018-04-11 Thread Dave Page
Thanks, applied. On Tue, Apr 10, 2018 at 8:50 PM, Rahul Soshte wrote: > These are generated files. > We can choose to ignore them. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgAdmin 3.0 builds

2018-04-11 Thread Dave Page
Nice work Fahar - I can reproduce the problem now! Akshay, can you look into this ASAP please? My calendar is full :-( On Wed, Apr 11, 2018 at 6:12 AM, Fahar Abbas wrote: > Hi Dave, > > Now i know the actual root-cause of the issue. After further > investigation, i realized that pgAdmin4 applic