Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Victoria, As per the logs, Restore job is failing only for GPDB. As I don't have setup for the greenplum database, can you please check this functionality works well in pgAdmin4 with GPDB? Thanks, Khushboo On Wed, Jun 6, 2018 at 5:13 AM, Victoria Henry wrote: > Hi Khushboo > > The tests

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo The tests are still failing and seems flaky: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/113 Sincerely, Victoria On Tue, Jun 5, 2018 at 4:50 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 5, 2018

Re: [pgadmin][patch] Electron version 4.X

Hi On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find the patch that introduces electron to our code base. > Cool. FYI, I'd like to get this into rough shape and then push it to a dev branch for fine-tuning. I

Re: [pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

Hi Akshay, LGTM and passes tests. Sincerely, Victoria On Tue, Jun 5, 2018 at 8:28 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the minor patch to move 'Notifications' tab before "Query > History" in Query Tool. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 2:03 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi > > On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote: > >> >> >> On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> The

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote: > > > On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> The problem of SQL ASCII is solved with the patch, and not related to >> setting the client encoding of the sql window. >> > > No it's not. It

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Also, there are limitations in psycopg2 as well related to encoding, which makes it even more difficult to make behaviour similar to pgAdmin3 as there are encodings and decodings done at pyscopg2 end also. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions |

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, The problem of SQL ASCII is solved with the patch, and not related to setting the client encoding of the sql window. I can see there is no SET call in pgAdmin3 for client_encoding. I can remove the SET client_encoding='UNICODE'; that will solve the problem. But, can you please let me

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 1:21 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > > On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>>

[pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

Hi Hackers, Attached is the minor patch to move 'Notifications' tab before "Query History" in Query Tool. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Move_Notifications_Tab.patch Description: Binary data

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Dave, On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA updated patch. The sqleditor change is sent separately and removed >> from current patch as suggested. >> The test cases were

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA updated patch. The sqleditor change is sent separately and removed > from current patch as suggested. > The test cases were running fine when the module was specified using --pkg

pgAdmin 4 commit: Extract the tests and refactor some of the methods.

Extract the tests and refactor some of the methods. Extract some of the ACI Tree functionalities, and decouple it from the main source. Also - create some abstractions from the repeated code around the enable/disable the schema children object create/edit/delete functionalities, and also created

pgAdmin 4 commit: Handle a potential error case in the connection statu

Handle a potential error case in the connection status monitoring. When you disconnect the server with an open sqleditor tab, exception occurs at the back end. Also, after connecting server, the sqleditor is not able to connect back because of the exception. Branch -- master Details

Re: [pgAdmin4][patch] sqleditor connection status minor patch

Thanks, applied. On Tue, Jun 5, 2018 at 5:49 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA a minor patch for sqleditor. When you disconnect the server with an > open sqleditor tab, exception occurs at the back end. Also, after > connecting server, the

pgAdmin 4 commit: Fix constraint on servers table in SQLite to allow po

Fix constraint on servers table in SQLite to allow ports < 1024. Fixes #3307 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=20ea8a69f5ef31bc5082dc3d55ef09d1e96dd926 Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Thanks, applied. On Mon, Jun 4, 2018 at 10:43 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Missed the attachment. Apologies :( > > PFA. > > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat,

Re: pgAgent 4.0 patch

Thanks, committed with those changes. Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS Bitrock installers) from git head for Fahar to test? Once he's happy with them, I'll tag and build the community packages. Thanks! On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi wrote:

pgAgent commit: Updates for 4.0 release

Updates for 4.0 release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb Modified Files -- .gitignore | 13 +++--- CMakeLists.txt | 12 --

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, PFA updated patch. The sqleditor change is sent separately and removed from current patch as suggested. The test cases were running fine when the module was specified using --pkg but were failing in complete run. Fixed that. Kindly review. Thanks and Regards, Aditya Toshniwal

Re: [pgadmin4][Patch]: Test cases for the backup module

On Tue, Jun 5, 2018 at 9:37 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Jun 4, 2018 at 8:41 PM,

Re: [pgadmin4][Patch]: Test cases for the backup module

On Tue, Jun 5, 2018 at 1:36 PM, Dave Page wrote: > Hi > > On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hi Khushboo, >>> >>> Some tests

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi On Tue, Jun 5, 2018 at 4:39 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Khushboo, >> >> Some tests are failing in greenplum: >>