[PGAGENT] Upgrade pgAgent from unpackaged version

2018-06-12 Thread Ashesh Vashi
Hi Dave, As per my conversation with Rushabh, we need to rename the pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the current version has changed. We also need to update the schema version function for the unpackaged extension. Please find the attached patch for the same.

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-12 Thread Victoria Henry
Hi Aditya, It is not possible to fire event in another tab/new browser window. For >>> example, query tool can be open in another tab. And thus, changes are not >>> reflected there. There are solutions available like updating the >>> localStorage of the browser but those are not reliable and

Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11

2018-06-12 Thread Victoria Henry
Hi Khushboo, The following change is allowing the creation of procedures in postgresql versions less then 11 and also GreenPlum --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js +++

Re: [pgadmin4][Patch]: Test cases for the backup module

2018-06-12 Thread Victoria Henry
Hi Khushboo can you explain a little bit more this while loop? cnt = 0 while 1: if cnt > 1: break # Check the process list response1 = self.tester.get('/misc/bgprocess/?_='.format( random.randint(1, 999))) self.assertEquals(response1.status_code, 200)

Re: [pgadmin4][Patch]: Support for create multiple test classes in one test file

2018-06-12 Thread Joao De Almeida Pereira
Hello Hackers, Instead of doing this change and include more test harnessing to the setup we have, do you think we can try to push to get pytest into the code base and all these features will come by default? Thanks Joao ​ On Tue, Jun 12, 2018 at 9:30 AM Akshay Joshi wrote: > Hi Hackers, > >

[pgadmin4][Patch]: Support for create multiple test classes in one test file

2018-06-12 Thread Akshay Joshi
Hi Hackers, Attached is the patch to create multiple test classes in one test file. For example: I have one test file *test_feature.py *where I wrote multiple test classes class TestX(BaseTestGenerator): class TestY(BaseTestGenerator): class TestZ(BaseTestGenerator): So with current