Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi wrote: > Hi Aditya > > On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I tried to simulate, but no luck. It works on my system :( >> > >I have tried and Feature test are failing

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Urgh. Will try to reproduce and explore possible causes of failure. On Tue, Feb 5, 2019 at 10:40 AM Akshay Joshi wrote: > Hi Aditya > > On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I tried to simulate, but no luck. It works

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Hi Aditya On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > I tried to simulate, but no luck. It works on my system :( > I have tried and Feature test are failing randomly for each run. I have verified it on OSX and Ubuntu both. > >

Japanese translation for v4.2

Hello. Updated Japanese translation for upcoming version 4.2 is in attachment. Message catalog is based on git bb25d1a9. pgadmin4-4.2-ja.7z Description: Binary data

pgAdmin4 v4.2 candidate builds

Hi All, pgAdmin4 v4.2 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-02-04-1/ Fahar, can you please verify it for release on Thursday. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Jenkins build is back to normal : pgadmin4-master-python36 #909

See

Jenkins build is back to normal : pgadmin4-master-python34 #910

See

Jenkins build is back to normal : pgadmin4-master-python27 #915

See

Jenkins build is back to normal : pgadmin4-master-python35 #902

See

pgAdmin 4 commit: Update message catalogs

Update message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb25d1a98667071e1da8470384118cea5adfd6c6 Modified Files -- web/pgadmin/messages.pot | 8472 --

pgAdmin 4 commit: Update version for release.

Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a758f8fd3aaf71566bbe14495d5dbb013583770 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

Jenkins build is back to normal : pgadmin4-master-python37 #148

See

pgAdmin 4 commit: 1) Fixed jasmine test cases.

1) Fixed jasmine test cases. 2) Bootstarp4 toggle size should be mini for triggers Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2ee5c4e8204b97da550c0f280370558f8ba2c8a Author: Aditya Toshniwal Modified Files --

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Hackers, Attached is the patch to fix jasmine test cases. Didn't realise the timezones could create issues :( Kindly review. On Mon, Feb 4, 2019 at 4:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change the dashboard test cases

Build failed in Jenkins: pgadmin4-master-python35 #901

See Changes: [akshay.joshi] Fixed API test case for dashboard graphs. -- [...truncated 1.00 MB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of

Build failed in Jenkins: pgadmin4-master-python37 #147

See Changes: [akshay.joshi] Fixed API test case for dashboard graphs. -- [...truncated 1.00 MB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of

Build failed in Jenkins: pgadmin4-master-python27 #914

See Changes: [akshay.joshi] Fixed API test case for dashboard graphs. -- [...truncated 1.00 MB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of

Build failed in Jenkins: pgadmin4-master-python34 #909

See Changes: [akshay.joshi] Fixed API test case for dashboard graphs. -- [...truncated 1.00 MB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of

Build failed in Jenkins: pgadmin4-master-python36 #908

See Changes: [akshay.joshi] Fixed API test case for dashboard graphs. -- [...truncated 1.00 MB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 530 of

Build failed in Jenkins: pgadmin4-master-python35 #900

See Changes: [Dave Page] Exclude HTTPExceptions from the all_exception_handler as they should be -- [...truncated 1001.83 KB...]

pgAdmin 4 commit: Fixed API test case for dashboard graphs.

Fixed API test case for dashboard graphs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=605b1f479925c98471fa8f6744f5b35a8856085d Author: Aditya Toshniwal Modified Files -- web/pgadmin/dashboard/tests/test_dashboard_graphs.py |

Build failed in Jenkins: pgadmin4-master-python34 #908

See Changes: [akshay.joshi] Added 'pga4dash' comment for consistency [Dave Page] Correct error message. [Dave Page] Exclude HTTPExceptions from the all_exception_handler as they should be

Build failed in Jenkins: pgadmin4-master-python36 #907

See Changes: [akshay.joshi] Added 'pga4dash' comment for consistency [Dave Page] Correct error message. [Dave Page] Exclude HTTPExceptions from the all_exception_handler as they should be

Build failed in Jenkins: pgadmin4-master-python27 #913

See Changes: [akshay.joshi] Dashboard graph optimization. Fixes #3941 [Dave Page] There are no new features in 4.1 or 4.2, just fixes and optimisations. [akshay.joshi] Added 'pga4dash' comment for

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Hackers, Attached is the patch to change the dashboard test cases to fetch server_id similar to how it is done in other test cases. Kindly review. On Mon, Feb 4, 2019 at 3:43 PM Akshay Joshi wrote: > Thanks patch applied. > > On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal < >

Build failed in Jenkins: pgadmin4-master-python37 #146

See Changes: [akshay.joshi] Dashboard graph optimization. Fixes #3941 [Dave Page] There are no new features in 4.1 or 4.2, just fixes and optimisations. [akshay.joshi] Added 'pga4dash' comment for

Build failed in Jenkins: pgadmin4-master-python35 #899

See Changes: [akshay.joshi] Dashboard graph optimization. Fixes #3941 [Dave Page] There are no new features in 4.1 or 4.2, just fixes and optimisations. [akshay.joshi] Added 'pga4dash' comment for

Re: [pgAdmin4][RM3961] - Exclude HTTPExceptions from all_exception_handler

Thanks, applied with minor PEP-8 fixes. Please remember to run "make check-pep8"!! On Mon, Feb 4, 2019 at 10:17 AM navnath gadakh wrote: > > Hi Hackers, > Please find the attached patch for RM-3961. > This is improvement to commit 1f298590400cf5d2921a07e200086e16cc22f72c > > Thanks! > > --

pgAdmin 4 commit: Exclude HTTPExceptions from the all_exception_handler

Exclude HTTPExceptions from the all_exception_handler as they should be returned as-is. Fixes #3961 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fdc1ffb38131a660adaa9bf83d6a295479793bf Author: Navnath Gadakh Modified Files

Build failed in Jenkins: pgadmin4-master-python34 #907

See Changes: [akshay.joshi] Dashboard graph optimization. Fixes #3941 [Dave Page] There are no new features in 4.1 or 4.2, just fixes and optimisations. --

pgAdmin 4 commit: Correct error message.

Correct error message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c21c07fc48d14692f1d102683bb9e0fd255ef2f Modified Files -- web/pgadmin/tools/datagrid/static/js/datagrid.js | 4 ++-- 1 file changed, 2 insertions(+), 2

pgAdmin 4 commit: Added 'pga4dash' comment for consistency

Added 'pga4dash' comment for consistency Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da83c3d1b8d3d39dab7d6bc79a47928bcced3aab Modified Files -- .../dashboard/templates/dashboard/sql/default/dashboard_stats.sql| 1 +

Build failed in Jenkins: pgadmin4-master-python36 #906

See Changes: [akshay.joshi] Dashboard graph optimization. Fixes #3941 [Dave Page] There are no new features in 4.1 or 4.2, just fixes and optimisations. --

[pgAdmin4][RM3961] - Exclude HTTPExceptions from all_exception_handler

Hi Hackers, Please find the attached patch for RM-3961. This is improvement to commit 1f298590400cf5d2921a07e200086e16cc22f72c Thanks! -- Regards, Navnath Gadakh RM-3961_v1.patch Description: Binary data

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Thanks patch applied. On Mon, Feb 4, 2019 at 3:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The poller will wait 3 times the normal > interval before sending new request if the previous request is pending. > After that, it

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

On Mon, Feb 4, 2019 at 10:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Feb 4, 2019 at 3:36 PM Dave Page wrote: > >> Hi >> >> Do we also give up waiting for the original response? >> > No, that will wait until AJAX request timeout. We do not cancel it

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Dave, On Mon, Feb 4, 2019 at 3:36 PM Dave Page wrote: > Hi > > Do we also give up waiting for the original response? > No, that will wait until AJAX request timeout. We do not cancel it explicitly. If response is received, it will be reflected. > > On Mon, Feb 4, 2019 at 9:57 AM Aditya

pgAdmin 4 commit: Dashboard graph optimization. Fixes #3941

Dashboard graph optimization. Fixes #3941 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aad7830d370f9425a359b85d3269d5616622760d Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.rst |

pgAdmin 4 commit: There are no new features in 4.1 or 4.2, just fixes a

There are no new features in 4.1 or 4.2, just fixes and optimisations. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9df89f9bd55ab170b86a362168ff125d958fa2d0 Modified Files -- docs/en_US/release_notes_4_1.rst | 7 +--

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Do we also give up waiting for the original response? On Mon, Feb 4, 2019 at 9:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The poller will wait 3 times the normal > interval before sending new request if the previous

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Hackers, Attached is the updated patch. The poller will wait 3 times the normal interval before sending new request if the previous request is pending. After that, it will send the ajax. Kindly review. On Mon, Feb 4, 2019 at 3:12 PM Dave Page wrote: > I can't get to this right now, but

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

I can't get to this right now, but Akshay, can we get it in before the release? I don't think the problem Khushboo notes is really a problem. Waiting for a response before issuing another one seems sensible... as long as there's a timeout so things don't get stuck if a response gets lost somehow.

Re: [pgAdmin4][RM3941] Dashboard graphs needs optimizations

Hi Aditya, I have reviewed the patch and it looks good to me except the logic to wait until we get the response from the AJAX request. So, in this case at a time only one request is being sent to the server. @ Dave/Ashesh, if you think this is okay then we can commit the patch. Thanks, Khushboo

Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

Hi Akshay, I tried to simulate, but no luck. It works on my system :( On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi wrote: > Hi Aditya > > I have applied your patch but following test cases are failing > consistently: > >- CopySelectedQueryResultsFeatureTest >-