Re: pgAdmin 4 - Czech translation update

Thanks, patch applied. On Tue, Apr 28, 2020 at 11:00 AM Libor M. wrote: > Hi, > I'm sorry to send this directly to yours e-mails. But I try send > e-mail to pgadmin-hackers on Sunday and Monday but there was no > moderation notification, maybe it doesn't work? > > In attachment is updated Czech

pgAdmin 4 commit: Update Czech translation.

Update Czech translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe264aafa7e2fb8eced49a5c24e13484a3552fdf Author: Libor M Modified Files -- .../translations/cs/LC_MESSAGES/messages.mo| Bin 156772 -> 187340 bytes

pgAdmin 4 commit: Fixed failed to fetch utility error when click on ref

Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447 It's a regression of #5213 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88aebb64f93a49fd8d070d082fe48c88aeb6b919 Author: Khushboo Vashi

Re: Remove Python 2 support from the desktop runtime

Did you forget to attach? — Ashesh On Mon, 27 Apr 2020 at 21:47, Dave Page wrote: > Patch for $SUBJECT attached. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- -- Thanks &

pgAdmin4 v4.21 candidate builds

Hi All, pgAdmin4 v4.21 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-04-27-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile:

Remove Python 2 support from the desktop runtime

Patch for $SUBJECT attached. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Reverting patch to remove Python 2.7 support from whe

Reverting patch to remove Python 2.7 support from wheel package to avoid any issue before 4.21 release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d1f67f3bef090b1409061830238eeb0af884dc7 Modified Files -- pkg/pip/build.sh

Re: Remove Python 2.7 support from the wheel package

On Mon, Apr 27, 2020 at 4:59 PM Akshay Joshi wrote: > > On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote: > >> Thanks - I assume not for 4.21 though? >> > > I thought it is intended for 4.21, so committed the patch. > I thought you were cutting it earlier today! I would suggest backing that

Re: Remove Python 2.7 support from the wheel package

On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote: > Thanks - I assume not for 4.21 though? > I thought it is intended for 4.21, so committed the patch. > > On Mon, Apr 27, 2020 at 4:55 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Apr

Re: Remove Python 2.7 support from the wheel package

Thanks - I assume not for 4.21 though? On Mon, Apr 27, 2020 at 4:55 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Apr 27, 2020 at 9:07 PM Dave Page wrote: > >> PFA a small patch for $SUBJECT >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >>

Re: [pgAdmin][RM5348]LDAP Authentication Support

Thanks, patch applied. On Mon, Apr 27, 2020 at 8:19 PM Abhilasha Narendra < abhilasha.naren...@enterprisedb.com> wrote: > Hi Akshay, > > PFA the updated patch. > > Regards, > Abhilasha > > > > > > > > On 27-Apr-2020, at 7:08 PM, Dave Page wrote: > > My point is that we should be consistent. If

Re: [pgAdmin][testcases] Fix for the failing test cases

Thanks, patch applied. On Mon, Apr 27, 2020 at 8:59 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to make the required changes to fix backup, restore, > maintenance test cases. > > Please review. > > -- > Thanks and Regards, > Aditya

pgAdmin 4 commit: Remove Python 2.7 support from the wheel package.

Remove Python 2.7 support from the wheel package. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b716800474cddfa3bba8fa55c141db85dde56439 Author: Dave Page Modified Files -- pkg/pip/build.sh | 2 +- pkg/pip/setup_pip.py | 60

pgAdmin 4 commit: Update version for release.

Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=50a423b142f3705d9ccb32afd25148bc57f2299e Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

pgAdmin 4 commit: Fixed API test cases for backup, restore and maintena

Fixed API test cases for backup, restore and maintenance. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b695329d2d549b6a35dd30114ed1c6019b933ece Author: Aditya Toshniwal Modified Files --

pgAdmin 4 commit: Documentation of LDAP authentication support. Fixes #

Documentation of LDAP authentication support. Fixes #5348 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbee63085c57f532158f1723dc8e8e7aa22790f6 Author: Abhilasha Narendra Modified Files --

pgAdmin 4 commit: Fixed an issue where the search object not able to lo

Fixed an issue where the search object not able to locate pg_toast_* tables in the pg_toast schema. Fixes #5441 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=99d1068f702d1b2d95419358fce566a27f22a304 Author: Aditya Toshniwal Modified Files

Remove Python 2.7 support from the wheel package

PFA a small patch for $SUBJECT -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Remove_support_for_building_the_Python_wheel_with_and_for_Python_2_7.patch Description: Binary data

[pgAdmin][testcases] Fix for the failing test cases

Hi Hackers, Attached is the patch to make the required changes to fix backup, restore, maintenance test cases. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"

Re: Patch to remove Python 2.7 support in the macOS Appbundle

On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The code looks good to me. The package building was tested by Neel and we > found that the venv was built with Python 3+ but the runtime was built > against Python 2.7. > As per Dave, Neel may have

Re: Patch to remove Python 2.7 support in the macOS Appbundle

Hi, The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7. As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the

Re: [pgAdmin][RM5348]LDAP Authentication Support

My point is that we should be consistent. If we add detailed docs for those config parameters, let's add them for everything (not necessarily today or this release of course). I do agree with Akshay that this may work better as a table. It shouldn't hold up the release though. On Mon, Apr 27,

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Thanks, patch applied. On Mon, Apr 27, 2020 at 6:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Pradip, > > The patch looks good to me. > > On Mon, Apr 27, 2020 at 6:23 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Please ignore my previous patch.

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Thanks, patch applied. On Mon, Apr 27, 2020 at 3:56 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > Here is an updated patch fixing test cases. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Thanks, patch applied. On Mon, Apr 27, 2020 at 5:30 PM Satish V wrote: > Hi, > > Here is an updated patch which makes the columns(44 and more ) showing up > in the creation order rather than alphabetical sorting. Changes happen > inside the browser tree. > > Thanks & Regards > Sathish V > > On

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

Thanks, patch applied. On Mon, Apr 27, 2020 at 3:07 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > This patch also fixes the RM #5439 - User can not create server if login > done with LDAP. > > Thanks, > Khushboo > > > On

pgAdmin 4 commit: Fixed the regression where initial changes make the S

Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18748846ef0719fdd8223c023d4e3cba33487110 Author: Pradip Parkale Modified

pgAdmin 4 commit: Fixed an issue where the user is not able to create a

Fixed an issue where the user is not able to create a server if login with an LDAP account. Fixes #5439 Improved LDAP error messages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f6abcc7fad88f6c40e42d6e3511aaf380336ea1 Author: Khushboo

pgAdmin 4 commit: Fixed an issue when the user performs refresh on a la

Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76eb3e9b67d70baca69bc6e4711033ffdc52274c Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Fixed an issue where the user should not be able to a

Fixed an issue where the user should not be able to add columns in the creation order after 50 columns. Regression of the initial patch. Fixes #5043 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b80784f5a1872314ce92a60bb3d470e9a35e25e8

Re: [pgAdmin][RM5348]LDAP Authentication Support

Currently, the config.py file doesn’t have detailed information about the parameters. Do we need to update that file to include the detailed information? Regards, Abhilasha > On 27-Apr-2020, at 6:39 PM, Akshay Joshi > wrote: > > Hi Dave > > On Mon, Apr 27, 2020 at 6:23 PM Dave Page

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Hi Pradip, The patch looks good to me. On Mon, Apr 27, 2020 at 6:23 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Please ignore my previous patch. Please find the latest patch. > > On Mon, Apr 27, 2020 at 5:53 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Please ignore my previous patch. Please find the latest patch. On Mon, Apr 27, 2020 at 5:53 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. I fixed the regression where initial changes > were making the save button enabled when a

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

Hi Akshay/Aditya, Please find the updated patch. I fixed the regression where initial changes were making the save button enabled when a table dialog is opened. Also removed 'like' options from the dialog while editing table properties as there is no point in showing those to the user as those

Re: [pgAdmin][RM5348]LDAP Authentication Support

Hi Abhilasha Getting below error: Warning, treated as error: /Users/akshayjoshi/Developement/pgAdmin4/docs/en_US/getting_started.rst:31:toctree contains reference to nonexisting document ‘enabling_ldap_authentication’ I think you forgot to add ‘enabling_ldap_authentication’ file in the patch.

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hi, Here is an updated patch which makes the columns(44 and more ) showing up in the creation order rather than alphabetical sorting. Changes happen inside the browser tree. Thanks & Regards Sathish V On Thu, Apr 23, 2020 at 8:04 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Apr

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Hi Akshay, Here is an updated patch fixing test cases. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 27, 2020 at 12:27 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Akshay, flag not to run

Re: Patch to remove Python 2.7 support in the macOS Appbundle

On Mon, Apr 27, 2020 at 3:28 PM Dave Page wrote: > > > On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote: >> >>> >>> >>> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi < >>>

Re: Patch to remove Python 2.7 support in the macOS Appbundle

On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote: > >> >> >> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> As we support

Re: Patch to remove Python 2.7 support in the macOS Appbundle

On Mon, Apr 27, 2020 at 3:23 PM Dave Page wrote: > > > On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> As we support PostgreSQL >=9.5, do we need to maintain SQL templates for >> older versions? >> > > Yes, for now. We're not

Re: Patch to remove Python 2.7 support in the macOS Appbundle

On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > As we support PostgreSQL >=9.5, do we need to maintain SQL templates for > older versions? > Yes, for now. We're not actively removing support for old PostgreSQL versions, just not testing

Re: Patch to remove Python 2.7 support in the macOS Appbundle

Hi Dave, As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions? Thanks, Khushboo On Mon, Apr 27, 2020 at 3:16 PM Dave Page wrote: > The attached patch removes support for Python 2.7 in general from the > macOS appbundle build, thus also removing special

Patch to remove Python 2.7 support in the macOS Appbundle

The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

Hi Akshay, Please find the attached updated patch. This patch also fixes the RM #5439 - User can not create server if login done with LDAP. Thanks, Khushboo On Mon, Apr 27, 2020 at 1:46 PM Akshay Joshi wrote: > Hi Khushboo > > We should use the format() method instead of %. As it may create

Re: Drop Python 2 support in pgAdmin?

On Fri, Apr 24, 2020 at 6:56 PM Darren Duncan wrote: > On 2020-04-24 5:50 a.m., Dave Page wrote: > > Python 2 has been unsupported for a few months now. > > > > Does anyone object to dropping Python 2 support in pgAdmin? This > primarily > > affects our Python package - other installers and

Re: Translators: Release next week

Thanks, patch applied. On Sun, Apr 26, 2020 at 11:29 PM wrote: > hello > in attachment french translation for upcoming relase > bye > Fred > > > -- > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *Vendredi 24 Avril 2020 15:03:07 > *Objet: *Translators:

Re: [pgAdmin][RM5430] : Adding title to login page

Thanks, patch applied. On Fri, Apr 24, 2020 at 9:26 PM Yogesh Jain wrote: > Hi Hackers, > > Attached is the patch to Add app title to login page. > > Please review. > PFA. > > -- > Regards, > Yogesh Jain > 8982696654 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect*

pgAdmin 4 commit: Added title to the login page. Fixes #5430

Added title to the login page. Fixes #5430 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9daa7c7a7c6962b8092392161b0e227f24272ac6 Author: Yogesh Jain Modified Files -- docs/en_US/release_notes_4_21.rst | 1 +

pgAdmin 4 commit: Update Italian translation.

Update Italian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c9aed4d6fd7bf8604f49a11799dd0681ebc04bc Author: Domenico Sgarbossa Modified Files -- .../translations/it/LC_MESSAGES/messages.mo| Bin 161284 ->

pgAdmin 4 commit: Update French translation.

Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed106e35779afc46f3b9fc033aa312d5fa520e4f Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 165455 ->

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

Hi Khushboo We should use the format() method instead of %. As it may create problems in translation. Please fix and resend the patch. On Mon, Apr 27, 2020 at 9:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to improve the ldap error

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi Yogesh Tested on MAC OSX in both the mode (server, desktop) it is showing "/". Please reverify it. On Mon, Apr 27, 2020 at 10:58 AM Yogesh Jain wrote: > Hi Hackers, > > I have tested this patch in linux (Ubuntu 18.04) env only , which is > working fine. It will be great if someone can

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Thanks Akshay, flag not to run tests set to true when the check utility fails in-case if the binary path is not set, I will fix that issue as I did not consider more than one server scenario. On Mon, Apr 27, 2020 at 12:05 PM Akshay Joshi wrote: > Hi Murtuza > > API test cases are not running,

Re: [pgAdmin][RM3787] Issue with Stop Process button

Hi Nagesh Your patch looks good to me, but it will not solve the issue that "Richard" has mentioned in the RM. What if terminating the process takes a long time? Please consider that and provide the proper solution. On Fri, Apr 24, 2020 at 7:12 PM Nagesh Dhope wrote: > Hi Hackers, > After the

Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it

Hi Murtuza API test cases are not running, there is no error but all the tests are skipped. I have run it for EPAS/PG 9.5 to 12 where the binary path for EPAS is not set. I also found one issue where the proper error message is not shown if the binary path is not set in the Preferences dialog. I