pgAdmin 4 commit: Warn the user when connecting to a server that is old

Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4eb17afe4e6fb0d119872f9e37ecc65492efb33b Modified Files -- docs/en_US/release_notes_4_26.rs

Re: LDAP auth pathc

On Tue, Aug 25, 2020 at 8:10 PM Romulo Rodriguez wrote: > Excellent! > > Is my first contribution on an open source project. > Congratulations. This won't be your last for sure. :) -- Thanks, Ashesh Vashi > > Thanks. > > -- > > Rómulo J. Rodríguez Rojas > > rodriguezr...@gmail.com > > > On Tue,

Re: LDAP auth pathc

Excellent! Is my first contribution on an open source project. Thanks. -- Rómulo J. Rodríguez Rojas rodriguezr...@gmail.com On Tue, Aug 25, 2020 at 3:12 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Aug 24, 2020 at 11:43 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com>

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

Hi On Tue, Aug 25, 2020 at 12:49 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > > PFA v5 patch for the same. > > if required any updates in this please let me know. > Hmm, yeah - that doesn't work for me I'm afraid; it's mixing content with code. The titles should be defined in the

Re: [pgAdmin][SonarQube] Cognitive complexity

Thanks, patch applied. On Tue, Aug 25, 2020 at 4:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > The previous commit caused a regression in taking backup of table. DB and > schema backup worked fine. > Attached patch fixes the regression. > I've also added mor

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Tue, Aug 25, 2020 at 6:04 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Database: > >- Refactor this function to reduce its Cognitive Complex

pgAdmin 4 commit: Fixed regression issue in taking backup of the table.

Fixed regression issue in taking backup of the table. Added some more test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e582ffca38c05eb17e9965c69f0873199d80fe24 Author: Aditya Toshniwal Modified Files -- web/pgadmin/too

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2577e32e669d980384212a21b41e948afdd4410 Author: Nikhil Mohite Modified Files -- .../server_groups/servers/databases/__init__

pgAdmin 4 commit: 1) Enable the 'Configure' and 'View log' menu option

1) Enable the 'Configure' and 'View log' menu option when the server taking longer than usual time to start. 2) When an error occurs from the backend, the configure window opens and if the user has changed the setting of the port, it won't take any effect as we have retrieved the value of the

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Database: - Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 2. Restore: - Refactor this function to reduce its Cognitive Complexity from 60 to

Re: [pgAdmin][RM5751] Enable the runtime menu when the timeout occurs

Hi Akshay, Looks OK to me. Please commit and have Fahar do some more in-depth testing and if he finds anything else we can incrementally fix that before the next release. Thanks! On Mon, Aug 24, 2020 at 3:05 PM Akshay Joshi wrote: > Hi Dave/Hackers > > Attached is the patch to fix the followin

Re: [pgAdmin][SonarQube] Cognitive complexity

Hi Hackers, The previous commit caused a regression in taking backup of table. DB and schema backup worked fine. Attached patch fixes the regression. I've also added more test scenarios in backup test cases covering table and schema backups to catch the failure earlier. On Tue, Aug 25, 2020 at 12

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

Thanks, patch applied. Can you please make one more tweak though (obviously against the current git head) - specifically, the page titles should be more specific, e.g. Styleguide: Iconography Styleguide: Color Palette etc. This should be reflected in the title tag of the pages as well as the he

pgAdmin 4 commit: Fixed Jenkins build failure due to API test case fail

Fixed Jenkins build failure due to API test case failed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2ac6187dca3e2ad679756c5390e2a7e65131962 Modified Files -- .../foreign_servers/user_mappings/__init__.py | 14 +++

pgAdmin 4 commit: Fixed string indices must be integers issue for Postg

Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df9aaf19c2266512660db8c7f24696c40390fcc0 Modified Files -- docs/en_US/release_notes_4_26.rst

Re: [pgAdmin][SonarQube]: Cognitive complexity

Thanks, patch applied. On Mon, Aug 24, 2020 at 4:47 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. > > On Fri, Aug 21, 2020 at 11:53 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Pradip >> >> Following are the review c

Re: [pgAdmin][SonarQube] Cognitive complexity

Thanks, patch applied. On Tue, Aug 25, 2020 at 12:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > Attached is the updated patch. > > On Tue, Aug 25, 2020 at 11:38 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Please fix the foll

Re: [pgAdmin][RM5722]: Not able to drop database.

Thanks, patch applied. On Mon, Aug 24, 2020 at 4:13 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch. Now, with this patch user can drop a > database even if it is connected. > > -- > Thanks & Regards, > Pradip Parkale > Software Enginee

Re: [pgAdmin][RM-5748][RESQL] Incorrect SQL for Foreign key when creating a table

Thanks, patch applied. On Mon, Aug 24, 2020 at 5:49 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have resolved the issue in SQL statements to add foreign while creating > table RM-5748 . > PFA patch. > > > Regards, > Nikhi

Re: LDAP auth pathc

Thanks, patch applied. On Mon, Aug 24, 2020 at 11:43 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > The patch looks good to me. > > Thanks, > Khushboo > > On Mon, Aug 24, 2020 at 11:10 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please r

pgAdmin 4 commit: Simplifies the search of the LDAP user name by adding

Simplifies the search of the LDAP user name by adding to the user's search condition directly in the existing search filter. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6bd085c15a77c521cd23fd922dd366fa655b74b Author: Romulo Rodriguez Mo

pgAdmin 4 commit: Fixed incorrect reverse engineering SQL for Foreign k

Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b3d49c61a57f5e78108b132a92af9ea275d294c6 Author: Nikhil Mohite Modified Files -- docs/en_U

pgAdmin 4 commit: Ensure that the user should be able to drop the datab

Ensure that the user should be able to drop the database even if it is connected. Fixes #5722 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86bbc3a9e8c5bd139a4a29a668e38b94881b984a Author: Pradip Parkale Modified Files -- docs/

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f947f146c9ad00f249c80dbecd238931b701a4b Author: Pradip Parkale Modified Files -- web/pgadmin/browser/__init__.py

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=275c671576f08f83f0c580b6cf5ee93cb7fff3d9 Author: Aditya Toshniwal Modified Files -- .../schemas/packages/edbfuncs/__init__.py

Re: [pgAdmin][SonarQube] Cognitive complexity

Hi Akshay, Attached is the updated patch. On Tue, Aug 25, 2020 at 11:38 AM Akshay Joshi wrote: > Hi Aditya > > Please fix the following issues: > >- Add docstrings to the newly created functions. >- Fix PEP8 issue. > > > > On Mon, Aug 24, 2020 at 5:02 PM Aditya Toshniwal < > aditya.tosh