Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-13 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Tue, Sep 13, 2022 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > Review comments are as follows: > >- View/Edit Data does not work. (Cursor could not be found for the >async connection.) > > Fixed. > >- Graph Visualizer is not

[pgAdmin4][Patch]: SonarQube Vulnerabilities

2022-09-13 Thread Khushboo Vashi
Hi, I have tried to fix the vulnerabilities reported by SonarQube but it didn't work. So I added the verification of region_id (user defined input) as discussed in yesterday's meeting and am going to close these issues. Thanks, Khushboo sonarQube_vulnerabilities.patch Description: Binary data

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Sep 13, 2022 at 3:59 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Sep 13, 2022 at 3:09 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> PFA patch for resolving the following issues reported i

Re: [pgAdmin][patch] Change react-data-grid source in package.json

2022-09-13 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Sep 13, 2022 at 5:56 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please ignore again. Including more fixes. :) > > > On Tue, Sep 13, 2022 at 5:42 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Pleas

pgAdmin 4 commit: Updated keyboard shortcut documentation. Fixes #7446

2022-09-13 Thread Akshay Joshi
Updated keyboard shortcut documentation. Fixes #7446 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eb60b3892dd176f3f157c45d8fd4dbd455f21e0a Author: Fahar Abbas Modified Files -- docs/en_US/keyboard_shortcuts.rst | 161 ++

pgAdmin 4 commit: 1. Use EDB's repo for react-data-grid instead of the

2022-09-13 Thread Akshay Joshi
1. Use EDB's repo for react-data-grid instead of the personal repo. 2. Improved searching in the Search Objects. 3. Fixed react warnings in the query tool. 4. Fixed some SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2de965d7

pgAdmin 4 commit: Fixed following issues for Schema Diff:

2022-09-13 Thread Akshay Joshi
Fixed following issues for Schema Diff: 1) When some option from filter is selected, that particular type should be completely removed from top level result instead of showing identical:0 2) Copy button is missing for Difference SQL 3) Throw error when source & target server versions selected a

Re: [pgAdmin][patch] Change react-data-grid source in package.json

2022-09-13 Thread Aditya Toshniwal
Hi, Please ignore again. Including more fixes. :) On Tue, Sep 13, 2022 at 5:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please ignore the previous patch. Attached is the updated patch which > includes a few SonarQube fixes as well. > > On Tue, Sep 13, 2022 at 3:

Re: [pgAdmin][patch] Change react-data-grid source in package.json

2022-09-13 Thread Aditya Toshniwal
Hi, Please ignore the previous patch. Attached is the updated patch which includes a few SonarQube fixes as well. On Tue, Sep 13, 2022 at 3:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will: > 1. Refer EDB fork react-data-grid > 2. Improved

HEADS-UP: Redmine -> Github issue migration

2022-09-13 Thread Dave Page
All, Over the next few days we'll be migrating all the pgAdmin 4 issues in Redmine to Github. For various reasons (mostly the Github API), this is a slow process. When each issue is migrated, a prominent note will be added to the bottom of the Redmine issue warning that it has been migrated, alon

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Nikhil Mohite
Hi Akshay, On Tue, Sep 13, 2022 at 3:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > PFA patch for resolving the following issues reported in testing: > >1. When some option from filter is selected, that particular type >should be completely removed from top

[pgAdmin][patch] Change react-data-grid source in package.json

2022-09-13 Thread Aditya Toshniwal
Hi Hackers, Attached patch will: 1. Refer EDB fork react-data-grid 2. Improved searching in Search Objects. 3. React warnings in the query tool explain plan. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* "Don't Complai

Re: [pgAdmin][RM-6133]: [React] Port schema diff to React

2022-09-13 Thread Nikhil Mohite
Hi Akshay, PFA patch for resolving the following issues reported in testing: 1. When some option from filter is selected, that particular type should be completely removed from top level result instead of showing identical:0 2. Copy button is missing for Difference SQL 3. Throw error

Re: [pgAdmin 4][Patch]: #7314 - psycopg2 to psycopg3 migration

2022-09-13 Thread Akshay Joshi
Hi Khushboo Review comments are as follows: - View/Edit Data does not work. (Cursor could not be found for the async connection.) - Graph Visualizer is not working. (raise IndexError("position out of bound") backend error) - Add psycopg3 support in *setup_pip.py* inside the pkg/pip

PgAdmin-System_stats extension Patch

2022-09-13 Thread Kunal Garg
Hi, Please find the attached System Stats extension patch. As my Final Submission for GSoC. Thanks, Kunal diff --git a/web/pgadmin/dashboard/__init__.py b/web/pgadmin/dashboard/__init__.py index d13b8bdeb..4d9db7f03 100644 --- a/web/pgadmin/dashboard/__init__.py +++ b/web/pgadmin/dashboard/__ini