[pgadmin-org/pgadmin4] 8ca8b3: fix(#7474): Use index as a key for the table heade...

2024-05-15 Thread Ashesh Vashi
Branch: refs/heads/av/7474 Home: https://github.com/pgadmin-org/pgadmin4 Commit: 8ca8b30418645eca9395970a678793ad56faf6cf https://github.com/pgadmin-org/pgadmin4/commit/8ca8b30418645eca9395970a678793ad56faf6cf Author: Ashesh Vashi Date: 2024-05-15 (Wed, 15 May 2024

[pgadmin-org/pgadmin4] d09833: Separate the application name, branding & version ...

2024-02-09 Thread Ashesh Vashi
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: d09833744af8c18715f7fd9d46df48697112fcdd https://github.com/pgadmin-org/pgadmin4/commit/d09833744af8c18715f7fd9d46df48697112fcdd Author: Ashesh Vashi Date: 2024-02-09 (Fri, 09 Feb 2024) Changed

Re: Pgadmin4 System Stats Extension Design

2023-07-23 Thread Ashesh Vashi
On Mon, Jul 24, 2023 at 1:30 AM Sahil Harpal wrote: > Hello all, > Regarding the storage tab and the disk information charts, we have decided > to display two charts: > >1. A pie chart to represent the proportion of total space. >2. A bar chart to display the space available and used. >

Re: Pgadmin4 System Stats Extension Design

2023-07-12 Thread Ashesh Vashi
On Wed, Jul 12, 2023 at 4:20 PM Sahil Harpal wrote: > On Wed, 12 Jul 2023 at 10:26, Ashesh Vashi > wrote: > >> On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal >> wrote: >> >>> On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal >>> wrote: >&g

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2023 at 8:45 PM Sahil Harpal wrote: > On Tue, Jul 11, 2023 at 2:29 PM Sahil Harpal > wrote: > >> On Tue, 11 Jul 2023 at 12:04, Ashesh Vashi >> wrote: >> >>> Try preloading the extension in the PostgreSQL server. >>> e.g. Add th

Re: Pgadmin4 System Stats Extension Design

2023-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2023 at 11:58 AM Sahil Harpal wrote: > Hi, > > I have written code for the Summary and CPU tabs and would like to post it > here for review. > > I'm currently displaying the static values in the process info pie chart > because of a minor bug. The pg_sys_process_info() query

Re: Pgadmin4 System Stats Extension Design

2023-06-19 Thread Ashesh Vashi
s' prefix from these chart titles? (It looks redundant to me). > >> I have also attached the dashboard layout, as you suggested. >> > > Seems reasonable to me. A wireframe would seem like the best next step, to > confirm we're all happy with what's proposed. It's hard to visualise from a > list of bullet points. > -- Ashesh Vashi > > > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > >

[pgadmin-org/pgadmin4] c78904: 1) Correct the name of the python binary to use wi...

2023-03-27 Thread Ashesh Vashi
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c78904501d3b78359d9cf09d5d2cd82848d55a57 https://github.com/pgadmin-org/pgadmin4/commit/c78904501d3b78359d9cf09d5d2cd82848d55a57 Author: Ashesh Vashi Date: 2023-03-28 (Tue, 28 Mar 2023) Changed

Re: Proposal Dashboard design for system of pgadmin

2022-06-22 Thread Ashesh Vashi
selection of the 'Browser' tree on the left hand side. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Thu, Jun 23, 2022 at 4:

Re: [pgAdmin4][Patch]- Feature #7012 - disable master password requirement when using alternative auth source

2022-04-22 Thread Ashesh Vashi
On Fri, Apr 22, 2022 at 3:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Fri, Apr 22, 2022 at 3:28 PM Dave Page wrote: > >> >> >> On Fri, 22 Apr 2022 at 10:49, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Generally, secure

Re: Bug #6337 Patch

2021-07-22 Thread Ashesh Vashi
On Thu, Jul 22, 2021 at 2:01 PM Dave Page wrote: > > > On Thu, Jul 22, 2021 at 9:19 AM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Jul 22, 2021 at 12:27 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >

Re: Bug #6337 Patch

2021-07-22 Thread Ashesh Vashi
On Thu, Jul 22, 2021 at 12:27 PM Akshay Joshi wrote: > Hi Florian > > Thanks, the patch applied. > > I have changed the flash string from 'Account locked' to 'Your account is > locked. Please contact the Administrator.' > I have a scenario. I have only one user in pgAdmin. What would happen

pgAgent commit: Use std::string instead of std::wstring as it handles t

2021-07-14 Thread Ashesh Vashi
ixed an issue regarding the compilation of code on Windows. Fixes #6238 Signed-off-by: Ashesh Vashi Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=f8bb3f494f65eaa43b5bb698587c261631f28394 Modified Files -- CMakeLists.txt |

Re: Refactor: Registry Classes

2021-06-23 Thread Ashesh Vashi
> Done As discussed, SonarQube is not able to understand that the result object is a class, and not an object, hence - showing linter issues. I've disabled them in those lines by adding the comment '# NOSNAR' at the end. -- Thanks, Ashesh > > On Sat, Jun 19, 2021 at 11:27 AM Ashesh Vashi &

Re: Refactor: Registry Classes

2021-06-18 Thread Ashesh Vashi
On Sat, Jun 19, 2021 at 1:39 AM Ashesh Vashi wrote: > Hi Akshay, > > We do have a couple of classes, which does automatic registration of the > base classes, > and which creates single-ton objects for these base classes, when needed. > > I would be working on a patch sooner

Refactor: Registry Classes

2021-06-18 Thread Ashesh Vashi
. I realized - it will be a duplicate code at three places for the same functionalities. Hence - I worked on refactoring this registry class. Please find the patch for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterpris

Re: pgagent unicode support

2021-03-30 Thread Ashesh Vashi
On Fri, Feb 26, 2021 at 12:06 PM Neel Patel wrote: > Hi Dave/Ashesh, > > Do you have any further comments ? > Apologies for late response. Committed the patch. Dave, I've also updated the pgAgent's patch version (new version: 4.2.1), and copyright information. -- Thanks, Ashesh > > Thanks, >

pgAgent commit: Copyright update for 2021

2021-03-30 Thread Ashesh Vashi
Copyright update for 2021 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=62af7cad3353e9c7dc138bc1917314fa343dcb24 Modified Files -- CMakeLists.txt | 2 +- LICENSE | 2 +-

pgAgent commit: Bumped the version to 4.2.1

2021-03-30 Thread Ashesh Vashi
Bumped the version to 4.2.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=039f0fb1407701a5e912f6d97fca9eb52f3c72a6 Modified Files -- CMakeLists.txt | 4 ++-- pgAgent.rc | 10 +-

pgAgent commit: Improved the unicode support in pgAgent.

2021-03-30 Thread Ashesh Vashi
Improved the unicode support in pgAgent. Reviewed by: Neel Patel, Ashesh Vashi Neel also fixed the the compilation issue, and a memory leak in the patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=1cd752f105b82ed40537b67c02b69c960746c067

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-26 Thread Ashesh Vashi
On Thu, Nov 26, 2020 at 1:33 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Yes Akshay. > > I think we should go ahead adding this approach in the pgadmin faqs, we > would not be fixing this in our code as we don't know when Apple would fix > its issue. > Or, add these configs in

Re: Failed to configure the Python Environment

2020-11-22 Thread Ashesh Vashi
hows some instructions for building and > configuring env. Should I concern more? like config or something else. > I think - it covered the basics right. Please feel free to ask any specific questions. Happy Coding. -- Thanks, Ashesh > > Best regards, > Yifan > > On Nov 19, 2

Re: pgAdmin 4 commit: Fixed an issue where the query tool is not fetching m

2020-09-21 Thread Ashesh Vashi
docs/en_US/release_notes_4_27.rst | 3 ++- > > .../sqleditor/utils/is_query_resultset_updatable.py | 19 > +-- > > 2 files changed, 11 insertions(+), 11 deletions(-) > > > > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterpris

Re: LDAP auth pathc

2020-08-25 Thread Ashesh Vashi
On Tue, Aug 25, 2020 at 8:10 PM Romulo Rodriguez wrote: > Excellent! > > Is my first contribution on an open source project. > Congratulations. This won't be your last for sure. :) -- Thanks, Ashesh Vashi > > Thanks. > > -- > > Rómulo J. Rodríguez Rojas > >

pgAgent commit: Fixed an issue - when two jobs starts at the same time,

2020-08-10 Thread Ashesh Vashi
Fixed an issue - when two jobs starts at the same time, and sometime - it ends up creating the same name as random string used as temporary directory, and because - they were fetched at the same time, the implemnetation does not find that directory exists. In order to solve the issue - we will be

Re: RM 5235 - Support external config files

2020-07-17 Thread Ashesh Vashi
s/pgadmin/config_system.py > Windows: %CommonProgramFiles%\pgadmin\config_system.py > > Please review/commit. > How about putting them in $HOME/.pgadmin/config_local.py (applicable only for runtime)? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <

pgAdmin 4 commit: Fixed a typo in the psycopg2 driver in fetching resul

2020-07-13 Thread Ashesh Vashi
Fixed a typo in the psycopg2 driver in fetching result with 'execute_scalar' while attempting to reconnect. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1889c256e1b6367025bade59b379fa5b79910f28 Modified Files --

pgAdmin 4 commit: Show horizontal scrollbar when needed in the menubar

2020-07-01 Thread Ashesh Vashi
Show horizontal scrollbar when needed in the menubar in the lower resolution, when navbar button is visible. Added appropriate CSS in the .navbar-collapse class to show scrollbar in screen resolution (992px widith) Branch -- master Details ---

Re: Patch for SonarQube code scan fixes

2020-07-01 Thread Ashesh Vashi
On Wed, Jul 1, 2020 at 5:28 PM Dave Page wrote: > > > On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >>

Re: Patch for SonarQube code scan fixes

2020-07-01 Thread Ashesh Vashi
On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Functions files: > >- Remove the unused local variable "args" > > 2. node.js file in browser/static: > >- "j" hides or

pgAdmin 4 commit: Fix the dialog size when zoom level is changed of the

2020-07-01 Thread Ashesh Vashi
Fix the dialog size when zoom level is changed of the browser. The screen.width & screen.height does not reflect the values of the height and width respectively when zoom level is changed for the browser. It is better to review the calculated height and width based on the window.innerHeight and

pgAdmin 4 commit: Do not let browser autocomplete the password field wh

2020-07-01 Thread Ashesh Vashi
Do not let browser autocomplete the password field while connecting a database server. Set the autocomplete attribute of the password field to 'new-password' to let browser know, we require a new password for the password, and do not autocomplete it. Branch -- master Details ---

Re: Move pgAdmin git repo to Github?

2020-05-21 Thread Ashesh Vashi
(Pull Request) for patch submission? -- Thanks, Ashesh Vashi > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >

pgAdmin 4 commit: Fixed the errors, and warnings reported by pylama.

2020-05-08 Thread Ashesh Vashi
Fixed the errors, and warnings reported by pylama. TODO:: - Don't use unicode in Python 3 for removing the support of Python 2 ( psycopg2 driver - __init__.py, server_manager.py). - Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion. Branch -- master Details ---

Re: Remove Python 2 support from the desktop runtime

2020-04-27 Thread Ashesh Vashi
L Company > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi>

pgAdmin 4 commit: Recreate the node item in the tree, when 'id' has bee

2020-04-22 Thread Ashesh Vashi
Recreate the node item in the tree, when 'id' has been changed of the node. Fixes #5053 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=637c80c38b7929c4c3153b2628bcb80a8b3d625c Modified Files --

pgAdmin 4 commit: Fixed validation errors in view/materialized view jav

2020-04-22 Thread Ashesh Vashi
Fixed validation errors in view/materialized view javascript to determine the number columns chagned. It was trying to execute 'replace' and 'includes' function on undefined values instead of string value. Also - changed the warning message, and separated the 'Do you want to continue?' syntax in

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

2020-04-15 Thread Ashesh Vashi
On Wed, 15 Apr 2020 at 18:21, Ashesh Vashi wrote: > > > On Wed, 15 Apr 2020 at 18:18, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> We are sending the data to backend and depending on errors from backend. Any >>

Re: pgAdmin 4 - next gettext usage fixes

2020-04-15 Thread Ashesh Vashi
On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers/Libor, > > The changes like below are incorrect. Try "Count rows" from a table's > context menu. > > -info=gettext("Table rows counted: %s" % count), > > +

pgAdmin 4 commit: Using 'is_valid_ipaddress' utility function everywher

2020-04-14 Thread Ashesh Vashi
Using 'is_valid_ipaddress' utility function everywhere Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a4641889c3798e0509a360bf2070305c30fb245 Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 13

pgAdmin 4 commit: A valid ip address can be IPv4/IPv6

2020-04-14 Thread Ashesh Vashi
A valid ip address can be IPv4/IPv6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9c84edf9a6714dbb73b771745831ff55c46f818 Modified Files -- web/pgadmin/utils/ip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Merged adjustanct 'if' statements when allowed.

2020-04-14 Thread Ashesh Vashi
Merged adjustanct 'if' statements when allowed. Also - removed the unused variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a930c6617b0a788093346860da76f2467bdd3a3b Modified Files -- web/pgAdmin4.py | 13

pgAdmin 4 commit: We don't need to pass gettext for inline CSS transfor

2020-04-14 Thread Ashesh Vashi
We don't need to pass gettext for inline CSS transforation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c5883bce0cf885579a5e8a813716fc25df0f3d1 Modified Files -- .../databases/schemas/tables/constraints/foreign_key/__init__.py

pgAdmin 4 commit: [Authentication] Some of the base class functions are

2020-04-14 Thread Ashesh Vashi
[Authentication] Some of the base class functions are not static function, but - methods. Hence - 'self' should be used, and not 'cls'. Also - use a constant for duplicate string literal in LDAP authentication implementation. Branch -- master Details ---

pgAdmin 4 commit: [Foreign Key] Removed 1 unexpected arguments; 'get_no

2020-04-14 Thread Ashesh Vashi
[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects 5 positional arguments. Also, - Using 'gettext' instead of '_'. - Using constant string for 'foreign_key not found' error message. Branch -- master Details ---

pgAdmin 4 commit: Moved the ip-address check functionality to a separat

2020-04-08 Thread Ashesh Vashi
Moved the ip-address check functionality to a separate file to improve the maintainability of the code. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a34f61b24209cc4abc1bced1d30ce0ef1cbe57f Modified Files --

pgAdmin 4 commit: Fixed expected output status code, as 410 should be t

2020-04-08 Thread Ashesh Vashi
Fixed expected output status code, as 410 should be the status code for the object (CAST) not exists in the database server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a550b569ff5aadb8c2d99cbef4a4233ab00e413 Modified Files

pgAdmin 4 commit: Fixed pep8 issue

2020-04-08 Thread Ashesh Vashi
Fixed pep8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=775e61c248ca2d85c6b992bef337146cb4d0646d Modified Files -- .../server_groups/servers/databases/casts/__init__.py | 15 +++ 1 file changed, 7

pgAdmin 4 commit: Fixed a typo in previous commit

2020-04-08 Thread Ashesh Vashi
Fixed a typo in previous commit Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa7ced4ef1eb9e1cb7c9b4505416be36ba681d52 Modified Files -- web/pgadmin/tools/schema_diff/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1

pgAdmin 4 commit: Various misc fixes:

2020-04-08 Thread Ashesh Vashi
Various misc fixes: - Using the 'gettext' as oppose to '_', which is not defined - Define missing variables - Fixed escape character in string with double quote - Removed some dead code in a test case - Removed unnecessary self assignment Includes some fixes for Accessibility improvements - Use

pgAdmin 4 commit: [TABLES] Do not assign the paramter values, use separ

2020-04-08 Thread Ashesh Vashi
[TABLES] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b3e1f1e65c32555dcbd788ea880de27053595a6 Modified Files --

pgAdmin 4 commit: [Exclusion Constraint] Fixed an typo - it should have

2020-04-08 Thread Ashesh Vashi
[Exclusion Constraint] Fixed an typo - it should have been assignment Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c693d158e15287fd391fe2e637a6041978733a2 Modified Files --

pgAdmin 4 commit: [EDB Package Functions] [Functions] Fixed typos:

2020-04-08 Thread Ashesh Vashi
[EDB Package Functions] [Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details ---

pgAdmin 4 commit: [Rules] Removing unnecessary 'if' condition

2020-04-08 Thread Ashesh Vashi
[Rules] Removing unnecessary 'if' condition Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fe687eb5505df5ad4fe7bbd37f8aa5f1dea955a Modified Files -- .../servers/databases/schemas/tables/rules/__init__.py | 7 +++

pgAdmin 4 commit: [Packages] Fixed a typo

2020-04-08 Thread Ashesh Vashi
[Packages] Fixed a typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7afa30d0ca51e311169aad05da638f44016c91f Modified Files -- .../server_groups/servers/databases/schemas/packages/__init__.py| 2 +- 1 file changed, 1

pgAdmin 4 commit: [Functions] Fixed typos:

2020-04-08 Thread Ashesh Vashi
[Functions] Fixed typos: - 'gettext' should be used as '_' is not defined - Identical expressions should not be used on both sides of a binary operator. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f21921bb0fbe48aa766c2e4b6847ed15362396

pgAdmin 4 commit: [Domain] Existing expression will expression will alw

2020-04-08 Thread Ashesh Vashi
[Domain] Existing expression will expression will always result into false Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6c03a6b75db88461efa5064326559e01899f2b4 Modified Files --

pgAdmin 4 commit: [COLLATIONS] Do not assign the paramter values, use s

2020-04-08 Thread Ashesh Vashi
[COLLATIONS] Do not assign the paramter values, use separate variable for new value Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=068b81224559c0b841c84bd6b9e8721979aa5a19 Modified Files --

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

2020-04-08 Thread Ashesh Vashi
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID. > > As per the current implementation, we completely ignored OID and instead > considered the name

pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de

2020-04-08 Thread Ashesh Vashi
Using the 'gettext' as oppose to '_', which is not defined in these files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a84a62def860cbb11fda2476cf1d1818dfac0f08 Modified Files --

pgAdmin 4 commit: Using the 'gettext' as oppose to '_', which is not de

2020-04-08 Thread Ashesh Vashi
Using the 'gettext' as oppose to '_', which is not defined in the file Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f0847b95dcb9eb73f6027d491e55d2b9e76c70f Modified Files --

pgAdmin 4 commit: [Accessibility] Use semantic markup to mark emphasize

2020-04-08 Thread Ashesh Vashi
[Accessibility] Use semantic markup to mark emphasized or special text. Reference: https://www.w3.org/TR/WCAG20-TECHS/H49.html Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=073e310a5a2f05b32a454a9fc6904dd0b12b0ba0 Modified Files

pgAdmin 4 commit: [LDAP Authentication] Use more secure protocol TSL v1

2020-04-08 Thread Ashesh Vashi
[LDAP Authentication] Use more secure protocol TSL v1.2 for security reason Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9e95d13e6f86a284037b10cb739095f09e8b4ee Modified Files -- web/pgadmin/authenticate/ldap.py | 2 +- 1 file

Re: disable create server

2020-03-27 Thread Ashesh Vashi
On Fri, Mar 27, 2020 at 4:01 PM Dave Page wrote: > > > On Fri, Mar 27, 2020 at 4:24 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Mar 27, 2020 at 3:56 AM Pavy Manuel wrote: >> >>> Hello, >>> >>> I'm new in the pgadmin list. >>> I try to deploy pgadmin4 on

pgAgent commit: Copyright update

2020-03-04 Thread Ashesh Vashi
Copyright update Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=041987f9b8f6a2d76a58c96e682a393c388f627b Modified Files -- CMakeLists.txt | 2 +- LICENSE | 2 +- cmake/MakeExt.cmake

Re: PgAgent leap year problem

2020-03-03 Thread Ashesh Vashi
s resource (.rc) files. -- Thanks, Ashesh > > Thanks, > Neel Patel > > On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Mar 4, 2020 at 10:53 AM Neel Patel >> wrote: >> >>> Hi Mehmet, >

pgAgent commit: Use 'YEAR' part of a date to determine the leap year.

2020-03-03 Thread Ashesh Vashi
Use 'YEAR' part of a date to determine the leap year. In order to calculate the last day of the month, we were using 'DAY' part of a date to determine the leap year, which was wrong. We should have used 'YEAR' part for the date for that caculation as proposed in this change. Original Patch by:

Re: PgAgent leap year problem

2020-03-03 Thread Ashesh Vashi
On Wed, Mar 4, 2020 at 10:53 AM Neel Patel wrote: > Hi Mehmet, > > It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed > and tested, it is working fine. > > Dave/Ashesh:- Can we commit this patch ? > Mehmet, Thanks for your patch. Changes look good except it does not take

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Ashesh Vashi
her places. > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi>

Re: node.js: "getView:generate_url" has explicit with_id=false

2020-02-10 Thread Ashesh Vashi
On Tue, Feb 11, 2020 at 10:49 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Feb 10, 2020 at 11:13 PM Radoslaw Garbacz < > radoslaw.garb...@xtremedatainc.com> wrote: > >> Hi, >> >> I am just getting familiar with the sources. >> >> As the title, when requesting

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-20 Thread Ashesh Vashi
Have you seen any improvements in performance? On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use https://pypi.org/project/cheroot/ instead of > current flask dev server. cheroot is a stable production ready

pgAdmin 4 commit: Fixed any typo - we were using the function

2019-12-13 Thread Ashesh Vashi
Fixed any typo - we were using the function 'TreeNode.prototype.hasParent(...)' to find the server parent node instead of 'TreeNode.prototype.anyParen(...)'. Branch -- master Details ---

Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode

2019-12-13 Thread Ashesh Vashi
ify a user when running in dekstop mode. > I tested it without --user parameter and it successfully imported the > servers.json configuration. > > Should I submit a patch ? First time contributing to Pgadmin :) > Please do. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA:

pgAdmin 4 commit: Fixes # 4778 - Implement the query plan analyzer

2019-10-08 Thread Ashesh Vashi
Fixes # 4778 - Implement the query plan analyzer Look 'n' Feel and implementation logic are inspired from 'http://explain.depsez.com'. It now creates three tabs under the 'Explain' panel when executing a query using the Explain Analyze/Explain button from the toolbar of the Query tool.

PATCH: RM #4778 - Query Plan Analyser

2019-10-03 Thread Ashesh Vashi
t; 100 times - Orange (Between Red & Yellow Color) > 10 times - Yellow Color Also - if actual rows >= plan rows then it shows up arrow, , else it shows down arrow. Statistics -> It contains a HTML table for the statistics per Node Type, and a HTML table for the statistics per table. P

Re: Docker build simplification

2019-09-11 Thread Ashesh Vashi
On Tue, Sep 10, 2019 at 11:21 PM Dave Page wrote: > The attached patch simplifies the Docker container build so that it can be > done entirely using "docker build" in the root of a source tree. It also > enables building the container from a tarball, not just a git checkout. > This does mean

pgAdmin 4 commit: Update yarn.lock to update the vulnerable javascripts

2019-09-03 Thread Ashesh Vashi
Update yarn.lock to update the vulnerable javascripts i.e. eslint-utils >= 1.4.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d4429fa64da4408f5479c68d07016de595f6bd4 Modified Files -- web/yarn.lock | 495

Re: [pgAdmin][RM4681] Increase cache control max age for static files

2019-08-28 Thread Ashesh Vashi
ing will be done for at least 1 year. I am still kind of confused, what should be the caching time? But - we can go ahead with this change. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedi

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-22 Thread Ashesh Vashi
that's the case. > +1 -- Thanks, Ashesh > > >> >> The rest of the issues need some debugging since I have never encountered >> these failures while executing on Jenkins. >> >> Thanks and regards, >> Shubham Agarwal >> >> On Thu, Aug 2

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-22 Thread Ashesh Vashi
On Thu, Aug 22, 2019 at 2:43 PM Akshay Joshi wrote: > > > On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Akshay, >> >> On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-22 Thread Ashesh Vashi
Akshay, On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi wrote: > Nice work! > It's big patch, and also improvement over last status. Can we commit the patch, as to avoid any merging issues later? -- Thanks, Ashesh > > I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG > 9.4,

Re: pgAdmin4 v4.11 candidate builds

2019-07-23 Thread Ashesh Vashi
On Tue, Jul 23, 2019 at 7:18 PM Devrim Gündüz wrote: > > Hi Akshay, > > On Tue, 2019-07-23 at 11:01 +0530, Akshay Joshi wrote: > > pgAdmin4 v4.11 candidate builds and source can be found at > > https://developer.pgadmin.org/builds/2019-07-23-1/ > > Where can I get some info about html_theme

Re: [pgAdmin4][Patch]: Feature #4202 Implement new framework to test Reverse Engineering SQL

2019-06-17 Thread Ashesh Vashi
On Mon, Jun 17, 2019 at 11:54 AM Akshay Joshi wrote: > Hi Dave/Hackers > > On Fri, Jun 14, 2019 at 6:10 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Fri, Jun 14, 2019 at 1:59 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jun 13, 2019 at 12:52 PM Akshay Joshi < >>>

Re: Extension Developing Roadmap

2019-03-11 Thread Ashesh Vashi
On Mon, Mar 11, 2019 at 5:24 PM Dave Page wrote: > > > On Sun, Mar 10, 2019 at 12:20 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> On Sun, 10 Mar 2019, 11:45 Batuhan Osman Taşkaya, < >> batuhanosmantask...@gmail.com> wrot

Re: Extension Developing Roadmap

2019-03-10 Thread Ashesh Vashi
On Sun, 10 Mar 2019, 11:45 Batuhan Osman Taşkaya, < batuhanosmantask...@gmail.com> wrote: > I am trying to add support for pgbackrest tool to pgadmin. I added a > module local pgadmin repo but i couldn't figure out how to execute a > command in the server and get the result of command back. How

pgAdmin 4 commit: Use 'set_config(...)' function to update the 'bytea_o

2019-02-07 Thread Ashesh Vashi
Use 'set_config(...)' function to update the 'bytea_output' settings instead of 'UPDATE' statement, which is not allowed in the the read-only instances. Reported by: Robert J. Rotter Solution provided by: Tom Lane Fixes #3973 Branch -- master Details ---

pgAdmin 4 commit: Removing the font smoothing for the firefox as per fe

2019-02-07 Thread Ashesh Vashi
Removing the font smoothing for the firefox as per feedback from Chethana Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8efdc43177351a1642c3664d522b60e71d83681f Modified Files -- web/pgadmin/static/scss/_bootstrap.overrides.scss

pgAdmin 4 commit: Adding font-smoothing CSS for the OSX for making the

2019-02-07 Thread Ashesh Vashi
Adding font-smoothing CSS for the OSX for making the fonts more eye-pleasing and softer to match it with the proposed design. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c65608946910be765395eabbce1f0a5d132dfe9 Modified Files

Re: [pgAdmin4] UnicodeDecodeError in directory name.

2019-02-06 Thread Ashesh Vashi
And - probably sample names would be helpful. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi>

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-31 Thread Ashesh Vashi
comments. -- Thanks, Ashesh > > On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Aditya, >> >> On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-30 Thread Ashesh Vashi
the menu is called (menu toggling), it will close the existing submenu(s) too. Please review it, and let me know. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi <http://www.linkedin.co

Re: [pgAdmin4][RM3865] Difficult to resize Query Tool

2019-01-30 Thread Ashesh Vashi
Hi Dave, I was having conversation with Aditya about "What should be the mouse hover (resize selection) area of the splitters?". I asked him to set it to 5px. But - he has different opinion, was in favor to keep it around '11px'. Please advise. -- Thanks & Regards, Ashesh Vash

pgAdmin 4 commit: Show the help string separate block in the calendar c

2019-01-29 Thread Ashesh Vashi
Show the help string separate block in the calendar control to align the input, and calendar button properly in case of help string is present. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e8f8042790c7d68f20e0d468d06ed533daad08f Modified

pgAdmin 4 commit: Increase the width, and show the pointer cursor of th

2019-01-29 Thread Ashesh Vashi
Increase the width, and show the pointer cursor of the button under the sortable backgrid header Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=430be1c4cb5989c0f87c32a8f2cb1b23b2089192 Modified Files --

pgAdmin 4 commit: Override the font-family defined by bootstrap

2019-01-29 Thread Ashesh Vashi
Override the font-family defined by bootstrap Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1858596253a765f5ac4652871d97d48a21bd3240 Modified Files -- web/pgadmin/static/scss/resources/_default.variables.scss | 8 +--- 1 file

Re: Remove hacky way to open/close the dropdown-submenu

2019-01-21 Thread Ashesh Vashi
Any update? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi wrote: > Hi Adi

Remove hacky way to open/close the dropdown-submenu

2019-01-17 Thread Ashesh Vashi
other better approach. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> pgadmin_submenu_open.patch Description: Binary data

pgAdmin 4 commit: Define some of the variables in _default.variables.sc

2019-01-14 Thread Ashesh Vashi
Define some of the variables in _default.variables.scss with '!default' suffix to allow override them while defining another theme. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6735c30292f1b75eba762d00b456fd631195a4d8 Modified Files

pgAdmin 4 commit: Fixed a typo in the wizard.js, which was not allowing

2019-01-14 Thread Ashesh Vashi
Fixed a typo in the wizard.js, which was not allowing to show the maximize button in the Grant Wizard. Also - change the CSS to set the top to '0' of the ajs-content (alertify content container) for the frameless dialogs. Branch -- master Details ---

pgAdmin 4 commit: pgBrowser tree does not need to save tree state, when

2019-01-01 Thread Ashesh Vashi
pgBrowser tree does not need to save tree state, when 'browser' module is initialized from the tools like query editor, debugger, etc. Refs #3559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b9c841c155e1ecfd1092e262750dc28a1a598d7

  1   2   3   4   5   >