Re: [pgAdmin][RM5410] Package Body is not being removed

2020-04-23 Thread Shubham Agarwal
Patch looks good to me. Please go ahead and commit the code. On Thu, Apr 23, 2020 at 4:25 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > I will be reviewing this patch. > > On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi < > akshay.jo...@enterprisedb.com>

Re: [pgAdmin][RM5410] Package Body is not being removed

2020-04-23 Thread Shubham Agarwal
o popped up the warning > message. > > Please review it. > > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-04-21 Thread Shubham Agarwal
ution of >>> API/Features tests remains the same. >>> >>> >>> Thanks, >>> Yogesh Mahajan >>> QA - Team >>> EnterpriseDB Corporation >>> >>> Phone: +91-9741705709 >>> >> >> >> -- >> *

Re: [pgAdmin4 Patch - RM 4440]

2020-04-15 Thread Shubham Agarwal
On Wed, Apr 15, 2020 at 4:31 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Apr 15, 2020 at 4:29 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA patch containing the fix and the resql test case

[pgAdmin4 Patch - RM 4440]

2020-04-15 Thread Shubham Agarwal
Hi Team, PFA patch containing the fix and the resql test cases. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company

[pgAdmin4 - Bug #5387]

2020-04-14 Thread Shubham Agarwal
Hi Team, PFA the patch for displaying mode in properties of func/proc if all args are "IN" -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company rm_5387_v1.patch Description: Binary data

[pgAdmin4][Patch]: RM 4445 - Ensure all object names in the title line of the reverse-engineered SQL are *not* quoted.

2020-04-13 Thread Shubham Agarwal
Hi Team, Please find the patch attached for RM-4445. The patch contains following things- 1. Fixes for each node. 2. Fixes for Resql test cases -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company rm_4445_v1.patch Description: Binary data

Re: Fixes for pgAdmin feature tests

2019-12-03 Thread Shubham Agarwal
-expansion of the children nodes for maintaining the synchronization. On Thu, Nov 21, 2019 at 5:22 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Nov 21, 2019 at 3:40 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> Att

Re: Fixes for pgAdmin feature tests

2019-11-21 Thread Shubham Agarwal
Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA feature test fixture patch containing the following things: >> >> 1. Added an attribute '

Re: Fixes for pgAdmin feature tests

2019-11-19 Thread Shubham Agarwal
up_role is added and used to expand tree. 3. Functions for enabling and disable auto_commit and auto_rollback are made more precise. 4. Some scrolling problem is addressed in view_data_dml_query test. 5. Handled the stale element reference exception in query_tool_journey_test Regards, Shubham Agarw

Re: Fixes for pgAdmin feature tests

2019-11-15 Thread Shubham Agarwal
:19 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> PFA patch containing some more fixes for random feature test failures. >> >> Thanks and

Re: Fixes for pgAdmin feature tests

2019-11-12 Thread Shubham Agarwal
Hi Team, PFA patch containing some more fixes for random feature test failures. Thanks and regards, Shubham Agarwal On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi wrote: > Thanks, patch applied with a minor change. Menu for 'Delete Drop' server > has been changed to 'Remove

Fixes for pgAdmin feature tests

2019-11-10 Thread Shubham Agarwal
Hi Team, Attached is the patch containing fixes for the failed feature test cases. This patch contains- 1. Newly created function for traversing the browser tree. 2. Some synchronization issue fixes. 3. Modified locators. 4. Test cases fix for the recent commits. -- Thanks & Regards, Shu

Re: RE-SQL tests patch for FTS parsers node

2019-09-02 Thread Shubham Agarwal
Hi Team, PFA patch for M-SQL test cases for FTS parsers. Thanks & Regards, Shubham Agarwal On Mon, Jul 15, 2019 at 4:33 PM Dave Page wrote: > Thanks, applied. > > On Mon, Jul 15, 2019 at 11:42 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >>

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-27 Thread Shubham Agarwal
Hi Akshay, PFA the patch with fixed review comments. On Thu, Aug 22, 2019 at 4:26 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Yes, I agreed too. > The only thinking was if the test case objective is to check the debugger, > then it should fail instead of skip

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-22 Thread Shubham Agarwal
Vashi wrote: > On Thu, Aug 22, 2019 at 4:04 PM Dave Page wrote: > >> >> >> On Thu, Aug 22, 2019 at 11:26 AM Shubham Agarwal < >> shubham.agar...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> Thanks for the overall review and comment

Re: pgAdmin4 Feature Tests intermittent failures fix

2019-08-22 Thread Shubham Agarwal
cute the test cases. The rest of the issues need some debugging since I have never encountered these failures while executing on Jenkins. Thanks and regards, Shubham Agarwal On Thu, Aug 22, 2019 at 2:45 PM Ashesh Vashi wrote: > On Thu, Aug 22, 2019 at 2:43 PM Akshay Joshi < > akshay.

RE-SQL tests patch for FTS parsers node

2019-07-15 Thread Shubham Agarwal
Hi Team, PFA patch for RE-SQL tests cases for FTS parsers node. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company resql_fts_parser.patch Description: Binary data

Re: SCSS change for reset button and help text

2018-11-28 Thread Shubham Agarwal
Hi Team, Please ignore the previous patch and find the updated patch with one more additional change of displaying the Not allowed pointer on the disabled or read only text controls. On Tue, Nov 27, 2018 at 5:12 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, &

Re: pgadmin_page functions updated

2018-06-26 Thread Shubham Agarwal
having some another idea to achieve this using CSS Selector than please suggest. Thanks and Regards, Shubham Agarwal On Fri, Jun 15, 2018 at 4:11 AM, Dave Page wrote: > > > On Fri, Jun 15, 2018 at 6:32 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi

Re: pgadmin_page functions updated

2018-06-15 Thread Shubham Agarwal
Hi Khushboo, Yes i agree, currently we are not changing the functions that are already written but will use css selectors in all the upcoming new test cases. Thanks and regards, Shubham Agarwal On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:

pgadmin_page functions updated

2018-06-14 Thread Shubham Agarwal
t with wait till element to be clickable. Please find the attached patch. -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company pgadmin_page.patch Description: Binary data